Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX to ME0 SimHit #9526

Merged
merged 19 commits into from Jun 10, 2015
Merged

BUGFIX to ME0 SimHit #9526

merged 19 commits into from Jun 10, 2015

Conversation

clacaputo
Copy link
Contributor

ME0NumberingScheme::baseNumberToUnitNumber, argument changed from MuonBaseNumber to MuonBaseNumber&

Added more LogDebug and test files.

Added the ME0 Digi customization.

pietverwilligen and others added 19 commits June 5, 2015 18:17
@pietverwilligen
add more debug info
fef7536
@pietverwilligen
add more debug info
2733369
@pietverwilligen
add more debug info
bd8fb92
@pietverwilligen
add more debug info
69d5058
@pietverwilligen
add more debug info
049e4be
@pietverwilligen
add more debug info
d123e68
@pietverwilligen
test gen-sim for ME0
c100d07
@pietverwilligen
test gen-sim for ME0
9ff5207
@pietverwilligen
dont know anymore what i changed in this customs file
f446ef7
@pietverwilligen
dont know anymore what i changed in this customs file
ded66bc
@pietverwilligen
more clear instructions
ef209ea
@pietverwilligen
more clear instructions
f8207ea
@pietverwilligen
more clear instructions
8757095
@pietverwilligen
more clear instructions
9d5ddab
@clacaputo
Merged ME0SimHitDebug_v2 from repository pietverwilligen
d0f625a
@clacaputo
ME0 SimHit DetectorID FIXED
cab9687 
The detID assigned for the ME0 detector is no more 0

modified:   Geometry/MuonNumbering/interface/ME0NumberingScheme.h
modified:   Geometry/MuonNumbering/src/ME0NumberingScheme.cc
- In baseNumberToUnitNumber, argument changed from MuonBaseNumber to MuonBaseNumber&
@clacaputo
Merged ME0SimHit_DetectorID from repository clacaputo
dda580f
@clacaputo
Merge tag 'CMSSW_7_5_X_2015-06-09-1100' into ME0SimHit_DetectorID
c21ce31
@clacaputo
Merge branch 'ME0SimHit_DetectorID' of https://github.com/clacaputo/c…
f27a109 
…mssw into ME0SimHit_DetectorID
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jun 9, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2015

A new Pull Request was created by @clacaputo (Claudio) for CMSSW_7_5_X.

BUGFIX to ME0 SimHit

It involves the following packages:

Geometry/GEMGeometryBuilder
Geometry/MuonNumbering
RecoLocalMuon/GEMRecHit
SLHCUpgradeSimulations/Configuration
SimG4CMS/Muon
SimMuon/GEMDigitizer

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @bellan, @jhgoh, @Martin-Grunewald, @makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jun 9, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 10, 2015
@cmsbuild
Merge pull request #9526 from clacaputo/ME0SimHit_DetectorID
62e0312 
BUGFIX to ME0 SimHit
@cmsbuild cmsbuild merged commit 62e0312 into cms-sw:CMSSW_7_5_X Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed geometry-approved reconstruction-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@clacaputo @cmsbuild @slava77 @cvuosalo @civanch @davidlange6 @pietverwilligen