Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onia2mumu #9571

Merged
merged 15 commits into from Jun 17, 2015
Merged

Onia2mumu #9571

merged 15 commits into from Jun 17, 2015

Conversation

alberto-sanchez
Copy link
Member

Code for BPH compactSKIM. We add Onia2MuMu package, low energy photon conversion
selector package and the cff file for skimming.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for CMSSW_7_5_X.

Onia2mumu

It involves the following packages:

HeavyFlavorAnalysis/Onia2MuMu
HeavyFlavorAnalysis/PhotonConversion
HeavyFlavorAnalysis/compactSKIM

The following packages do not have a category, yet:

HeavyFlavorAnalysis/Onia2MuMu
HeavyFlavorAnalysis/PhotonConversion
HeavyFlavorAnalysis/compactSKIM

@cmsbuild can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jun 11, 2015

Please rename compactSKIM to CompactSkim to follow package naming style
On Jun 11, 2015 12:06 PM, "cmsbuild" notifications@github.com wrote:

A new Pull Request was created by @alberto-sanchez
https://github.com/alberto-sanchez (Alberto Sanchez Hernandez) for
CMSSW_7_5_X.

Onia2mumu

It involves the following packages:

HeavyFlavorAnalysis/Onia2MuMu
HeavyFlavorAnalysis/PhotonConversion
HeavyFlavorAnalysis/compactSKIM

The following packages do not have a category, yet:

HeavyFlavorAnalysis/Onia2MuMu
HeavyFlavorAnalysis/PhotonConversion
HeavyFlavorAnalysis/compactSKIM

@cmsbuild https://github.com/cmsbuild can you please review it and
eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
If you are a L2 or a release manager you can ask for tests by saying
'please test' in the first line of a comment.
@Degano https://github.com/degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.


Reply to this email directly or view it on GitHub
#9571 (comment).

@cmsbuild
Copy link
Contributor

Pull request #9571 was updated. @cmsbuild can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jun 11, 2015

Sorry for piecemeal review:
HeavyFlavorAnalysis/CompactSkim has only two files. It's not meaningful to make a new package for this. Please move the files to HeavyFlavorAnalysis/Skimming

@slava77
Copy link
Contributor

slava77 commented Jun 11, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #9571 was updated. @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@Degano - could you assign this package to analysis tools? THanks!

davidlange6 added a commit that referenced this pull request Jun 17, 2015
@davidlange6 davidlange6 merged commit 4b8ea6f into cms-sw:CMSSW_7_5_X Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants