Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in BeamSpot IOV creation in PCL #9586

Merged

Conversation

rmanzoni
Copy link
Contributor

Fix faulty Lumi Section counter restart that caused the max number of LS grouped into an IOV to be 59 rather than 60 as thought. This affects the Prompt Calibration Loop.

Can cause a mismatch for the 2012 replayed runs, but notice of this change has been propagated over the relevant hyper news and experts are aware.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_7_5_X.

Fix inconsistency in BeamSpot IOV creation in PCL

It involves the following packages:

Calibration/TkAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jun 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Jun 15, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 16, 2015
…esting

Fix inconsistency in BeamSpot IOV creation in PCL
@cmsbuild cmsbuild merged commit 7a3b4fe into cms-sw:CMSSW_7_5_X Jun 16, 2015
@rmanzoni rmanzoni deleted the CMSSW_7_5_X_60LS_harvesting branch June 17, 2015 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants