New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for valid pointers in GetJetConstituentsQuick (Port of PR#752 from 72X) #9637
Conversation
A new Pull Request was created by @heilman for CMSSW_7_5_X. Check for valid pointers in GetJetConstituentsQuick (Port of PR#752 from 72X) It involves the following packages: DataFormats/JetReco @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Adding a check for a valid pointer to Jet::GetJetConstituentsQuick. No change in monitored quantities would be expected. The code changes are satisfactory. Jenkins tests against baseline CMSSW_7_5_X_2015-06-15-2300 show no significant differences. Extended tests of workflow 140.53_RunHI2011 for the previous version of this PR (#9539) also showed no differences. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Check for valid pointers in GetJetConstituentsQuick (Port of PR#752 from 72X)
This was not ported forward from CMSSW_7_2_X. This change adds pointer checking to GetJetConstituentsQuick(). This prevents errors when looping over genJet constituents that have been dropped from miniAOD.