Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TrackingParticleFactory::vectorIsInsideVolume(...) function in TrackingTruthAccumulator #9681

Merged
merged 1 commit into from Jun 19, 2015

Conversation

jiafulow
Copy link
Contributor

In the function, the check of vertex z position should be using the absolute value.

I suspect this is an accidental bug. It should not affect anyone who uses official samples, and it should not affect any validation plots because the default in trackingTruthProducer_cfi.py has

    ignoreTracksOutsideVolume = cms.bool(False)

When the switch is false, the check of vertex position is not done. It only matters when a person decides to switch it on to get only the tracking particles and tracking vertices inside the tracker, as specified by the parameters

    volumeRadius = cms.double(120.0),
    volumeZ = cms.double(300.0),

However, as it is, the cut on vertex z is applied as a single-sided cut, rather than as a double-sided cut. I believe the expected behavior should be the latter, but I guess it's really up to the experts to decide.

This was first discussed on the pull request #9680 . As suggested by @mark-grimes, this is a duplicated pull request, but instead for the CMSSW_6_2_X_SLHC release.

… TrackingTruthAccumulator

The check of vertex z position should be using the absolute value
@mark-grimes
Copy link

please test

@cmsbuild cmsbuild added this to the Next CMSSW_6_2_X_SLHC milestone Jun 19, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jiafulow for CMSSW_6_2_X_SLHC.

Update TrackingParticleFactory::vectorIsInsideVolume(...) function in TrackingTruthAccumulator

It involves the following packages:

SimGeneral/TrackingAnalysis

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @appeltel, @rovere, @cerati, @trocino, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Jun 19, 2015

@jiafulow , you did this PR for 6_2_X and not 7_5_X

@mark-grimes
Copy link

@civanch, it needs to go in separately for 6_2_X_SLHC until we have fully merged the upgrade code into 7_5_X. I assume the 7_5_X pull request is coming.

@jiafulow
Copy link
Contributor Author

Hi @civanch

I've just opened a separate pull request on 7_5_X

@cmsbuild
Copy link
Contributor

@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Jun 19, 2015
Update TrackingParticleFactory::vectorIsInsideVolume(...) function in TrackingTruthAccumulator
@cmsbuild cmsbuild merged commit 2bf89c4 into cms-sw:CMSSW_6_2_X_SLHC Jun 19, 2015
@jiafulow jiafulow deleted the patch-2 branch August 10, 2016 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants