Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation improvements -- Fixed warnings, added processType to SimVertex #970

Merged
merged 1 commit into from Oct 2, 2013

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Oct 2, 2013

After migration to the new TrackingParticle number of forced compillation warning where left in Tracker/History sub-package. Partially these warnings are connected with the fact that the new TrackingParticle does not keep vector of PSimHits anymore. Other warnings were due to absence access to Geant4 process type. This type is added to SimVertex because it is a natural property of verteces and not of hits. All warning disabled, no change of real results.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2013

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_0_X.

fixed warnings, added processType to SimVertex

It involves the following packages:

SimDataFormats/Vertex
SimTracker/TrackHistory

@smuzaffar, @civanch, @nclopezo, @mdhildreth, @giamman can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@civanch
Copy link
Contributor Author

civanch commented Oct 2, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Oct 2, 2013

ktf added a commit that referenced this pull request Oct 2, 2013
Simulation improvements -- Fixed warnings, added processType to SimVertex
@ktf ktf merged commit e43aa29 into cms-sw:CMSSW_7_0_X Oct 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants