New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old files removed #9701
Old files removed #9701
Conversation
A new Pull Request was created by @dnash86 for CMSSW_5_3_X. Old files removed It involves the following packages: Configuration/Generator @vciulli, @cmsbuild, @covarell, @bendavid, @thuer can you please review it and eventually sign? Thanks. |
@dnash86 can you confirm this removes ALL files from Configuration/Generator/data which are now present in the external? |
@bendavid The list of files to remove matched the list sent by the requesters that the new requests run on. The other procedure could be to list those present in the external, and remove the filenames matching those, but I thought the easiest/best guarantee was to take the list of updated files provided by the analyzers themselves for removal. |
Can you explicitly check that there are no other duplicates compared to what is in https://github.com/cms-data/Configuration-Generator/tree/53X_incremental ? |
I checked, via this procedure: git clone -b 53X_incremental git@github.com:dnash86/Configuration-Generator.git Configuration-Generator I then tried to remove everything in that list from the directory I sent the pull from, and commit changes, and got a "nothing to commit" message. |
I will shortly be setting up a PR to the cms-data repository, with the updated slha files. |
PR to cms-data is set up, so we are ready to request a new CMSSW_5_3_X release, please advise on what else can be done to help. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Old SLHA files removed, new ones in https://github.com/cms-data/Configuration-Generator/tree/53X_incremental