Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize makeTrackValidationPlots.py script #9949

Merged

Conversation

makortel
Copy link
Contributor

This PR generalizes the makeTrackValidationPlots.py script introduced in #9882 to make plots for all subfolders of "Tracking/Track" folder of the first of the DQM files given as command line arguments (feature requested by @lveldere). Add also --ignoreMissing command line flag to allow skipping missing histograms/subfolders.

In addition, switch the plotting to use the profile histograms in the DQM files instead of the 2D histograms nhits_vs_eta and chi2_vs_eta that were cleaned up in #9524.

There should be no effect on standard workflows.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

Generalize makeTrackValidationPlots.py script

It involves the following packages:

Validation/RecoTrack

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@makortel makortel force-pushed the makeTrackValidationPlotsUpdate branch from a31046a to a7d1ed8 Compare June 29, 2015 09:55
@makortel
Copy link
Contributor Author

Noticed a small bug right after pushing "submit PR" button, fixed and squashed to the existing commit.

@cmsbuild
Copy link
Contributor

Pull request #9949 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@lveldere
Copy link
Contributor

Hi Matti

I have some troubles running this.
I've put 2 DQM files in ~lveldere/public/matti

I run

./Validation/RecoTrack/scripts/makeTrackValidationPlots.py fullsim_harvest.root fastsim_harvest.root

This complaints about some histograms not found.
Which I fixed by setting drawArgs["ignoreMissing"] = True,
but after that I still don't get pdf files...

Thanks

Lukas

@makortel
Copy link
Contributor Author

Thanks, I'll take a look (and close this for time being).

@makortel makortel closed this Jun 29, 2015
@makortel
Copy link
Contributor Author

@lveldere The missing histograms were due to 2D-histograms nhits_vs_eta and chi2_vs_eta that were cleaned up in #9524. As they were used only to make "ProfileX()", I switched the plotting to use the profiles existing in DQM file (should've done this in #9524...). In addition, I added --ignoreMissing flag to makeTrackValidationPlots.py that allows the script to continue making plots if some histograms/folders are missing (e.g. your example fastsim-file does not have jetCoreRegionalStepSeeds_quickAssociatorByHits folder), and made sure to loop over only subdirectories of Tracking/Track (#9201 added also summary histograms there).

@makortel makortel reopened this Jun 29, 2015
@cmsbuild
Copy link
Contributor

Pull request #9949 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@lveldere
Copy link
Contributor

Great, that works! Thanks.

@deguio
Copy link
Contributor

deguio commented Jul 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Jul 6, 2015
Generalize makeTrackValidationPlots.py script
@davidlange6 davidlange6 merged commit 1110644 into cms-sw:CMSSW_7_6_X Jul 6, 2015
@makortel makortel deleted the makeTrackValidationPlotsUpdate branch October 20, 2016 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants