fix: no need to resync again (#1336)

syncByName had retry from officialNpmRegistry when officialNpmReplicate request error
cnpm · May 25, 2018 · 0121de3 · 0121de3
1 parent 5334375
commit 0121de3
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/controllers/sync_module_worker.js b/controllers/sync_module_worker.js
@@ -296,13 +296,15 @@ SyncModuleWorker.prototype.next = function* (concurrencyId) {
   // try to sync from official replicate when source npm registry is not cnpmjs.org
   const registry = config.sourceNpmRegistryIsCNpm ? config.sourceNpmRegistry : config.officialNpmReplicate;
 
-  let versions = yield this.syncByName(concurrencyId, name, registry);
-  if (versions && versions.length === 0 && registry === config.officialNpmReplicate) {
-    // need to sync sourceNpmRegistry also
-    // make sure package data be update event replicate down.
-    // https://github.com/npm/registry/issues/129
-    versions = yield this.syncByName(concurrencyId, name, config.officialNpmRegistry);
-  }
+  yield this.syncByName(concurrencyId, name, registry);
+  // no need to resync again, syncByName had retry from officialNpmRegistry when officialNpmReplicate request error
+  // let versions = yield this.syncByName(concurrencyId, name, registry);
+  // if (versions && versions.length === 0 && registry === config.officialNpmReplicate) {
+  //   // need to sync sourceNpmRegistry also
+  //   // make sure package data be update event replicate down.
+  //   // https://github.com/npm/registry/issues/129
+  //   versions = yield this.syncByName(concurrencyId, name, config.officialNpmRegistry);
+  // }
 };
 
 SyncModuleWorker.prototype.syncByName = function* (concurrencyId, name, registry) {
@@ -340,7 +342,7 @@ SyncModuleWorker.prototype.syncByName = function* (concurrencyId, name, registry
         return;
       }
 
-      // retry from officialNpmRegistry
+      // retry from officialNpmRegistry when officialNpmReplicate fail
       this.log('[c#%d] [%s] retry from %s', concurrencyId, name, config.officialNpmRegistry);
       try {
         var result = yield npmSerivce.request(packageUrl, { registry: config.officialNpmRegistry });