#5951: PatchNodes are showing/hiding their geometry now when visibili…

…ty changes
codereader · May 1, 2022 · 354ceb5 · 354ceb5
1 parent 2d437bd
commit 354ceb5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/radiantcore/patch/PatchNode.cpp b/radiantcore/patch/PatchNode.cpp
@@ -283,6 +283,14 @@ void PatchNode::updateAllRenderables()
     _renderableCtrlPoints.queueUpdate();
 }
 
+void PatchNode::hideAllRenderables()
+{
+    _renderableSurfaceSolid.hide();
+    _renderableSurfaceWireframe.hide();
+    _renderableCtrlLattice.hide();
+    _renderableCtrlPoints.hide();
+}
+
 void PatchNode::clearAllRenderables()
 {
     _renderableSurfaceSolid.clear();
@@ -354,8 +362,8 @@ void PatchNode::onPreRender(const VolumeTest& volume)
     }
     else
     {
-        _renderableCtrlPoints.clear();
-        _renderableCtrlLattice.clear();
+        _renderableCtrlPoints.hide();
+        _renderableCtrlLattice.hide();
 
         // Queue an update the next time it's rendered
         _renderableCtrlPoints.queueUpdate();
@@ -504,12 +512,11 @@ void PatchNode::onVisibilityChanged(bool visible)
 
     if (!visible)
     {
-        // Disconnect our renderable when the node is hidden
-        clearAllRenderables();
+        hideAllRenderables();
     }
     else
     {
-        // Update the vertex buffers next time we need to render
+        // Queue an update, renderables are automatically shown in onPreRender
         updateAllRenderables();
     }
 }
diff --git a/radiantcore/patch/PatchNode.h b/radiantcore/patch/PatchNode.h
@@ -155,6 +155,7 @@ class PatchNode final :
 	void transformComponents(const Matrix4& matrix);
 
     void updateAllRenderables();
+    void hideAllRenderables();
     void clearAllRenderables();
 };
 typedef std::shared_ptr<PatchNode> PatchNodePtr;