From 3908cce4f6b86c75e6771418606fbf98be316d87 Mon Sep 17 00:00:00 2001
From: codereader <greebo@angua.at>
Date: Tue, 17 Nov 2020 09:04:00 +0100
Subject: [PATCH] #5108: Add some tests covering the file type registry

---
 test/FileTypes.cpp                     | 67 ++++++++++++++++++++++++++
 test/Makefile.am                       |  1 +
 tools/msvc/Tests/Tests.vcxproj         |  1 +
 tools/msvc/Tests/Tests.vcxproj.filters |  1 +
 4 files changed, 70 insertions(+)
 create mode 100644 test/FileTypes.cpp

diff --git a/test/FileTypes.cpp b/test/FileTypes.cpp
new file mode 100644
index 0000000000..7ee9a7482a
--- /dev/null
+++ b/test/FileTypes.cpp
@@ -0,0 +1,67 @@
+#include "RadiantTest.h"
+
+#include "ifiletypes.h"
+
+namespace test
+{
+
+using FileTypesTest = RadiantTest;
+
+TEST_F(FileTypesTest, WildcardRegistered)
+{
+    auto patterns = GlobalFiletypes().getPatternsForType("*");
+
+    ASSERT_EQ(patterns.size(), 1);
+    ASSERT_EQ(patterns.front().extension, "*");
+}
+
+TEST_F(FileTypesTest, Registration)
+{
+    auto customType = "_custom";
+    auto anotherType = "_custom2";
+
+    // Register two sets of patterns, one for each of the custom types
+    GlobalFiletypes().registerPattern(customType, FileTypePattern("Name1", "ext1", "*.ext1"));
+    GlobalFiletypes().registerPattern(customType, FileTypePattern("Name2", "ext2", "*.ext1"));
+
+    GlobalFiletypes().registerPattern(anotherType, FileTypePattern("Name1", "ext1", "*.ext1"));
+    GlobalFiletypes().registerPattern(anotherType, FileTypePattern("Name2", "ext2", "*.ext2"));
+
+    // Retrieve the patterns for one file type
+    auto patterns = GlobalFiletypes().getPatternsForType(customType);
+
+    // The registration for anotherType should not interfere with the query
+    ASSERT_EQ(patterns.size(), 2);
+    ASSERT_NE(std::find_if(patterns.begin(), patterns.end(), [](const FileTypePattern& p) { return p.extension == "ext1"; }), patterns.end());
+    ASSERT_NE(std::find_if(patterns.begin(), patterns.end(), [](const FileTypePattern& p) { return p.extension == "ext2"; }), patterns.end());
+}
+
+TEST_F(FileTypesTest, IconRegistration)
+{
+    auto customType = "_custom";
+    auto anotherType = "_custom2";
+    auto icon1 = "icon1.png";
+    auto icon2 = "icon2.png";
+
+    // Register two sets of patterns, one for each of the custom types
+    GlobalFiletypes().registerPattern(customType, FileTypePattern("Name1", "ext1", "*.ext1", icon1));
+    GlobalFiletypes().registerPattern(customType, FileTypePattern("Name2", "ext2", "*.ext1", icon2));
+
+    // Here a different icon for the same extension is registered
+    GlobalFiletypes().registerPattern(anotherType, FileTypePattern("Name1", "ext1", "*.ext1", icon2)); 
+    GlobalFiletypes().registerPattern(anotherType, FileTypePattern("Name2", "ext2", "*.ext2"));
+
+    // Check if an icon can be found
+    auto foundIcon = GlobalFiletypes().getIconForExtension("ext1");
+
+    // It's not defined which icon will be returned if two patterns define an icon
+    ASSERT_TRUE(foundIcon == icon1 || foundIcon == icon2);
+
+    // For ext2 there is only one icon registered
+    ASSERT_TRUE(GlobalFiletypes().getIconForExtension("ext2") == icon2);
+
+    // Query an unregistered extension
+    ASSERT_TRUE(GlobalFiletypes().getIconForExtension("no_ext_like_this") == std::string());
+}
+
+}
diff --git a/test/Makefile.am b/test/Makefile.am
index a91cbcdcd3..ad72c43ab3 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -32,6 +32,7 @@ drtest_SOURCES = math/Matrix4.cpp \
                  CSG.cpp \
                  HeadlessOpenGLContext.cpp \
                  FacePlane.cpp \
+                 FileTypes.cpp \
                  Materials.cpp \
                  MapExport.cpp \
                  Models.cpp \
diff --git a/tools/msvc/Tests/Tests.vcxproj b/tools/msvc/Tests/Tests.vcxproj
index 3805a6488b..f99613b45c 100644
--- a/tools/msvc/Tests/Tests.vcxproj
+++ b/tools/msvc/Tests/Tests.vcxproj
@@ -69,6 +69,7 @@
     <ClCompile Include="..\..\..\test\CSG.cpp" />
     <ClCompile Include="..\..\..\test\Face.cpp" />
     <ClCompile Include="..\..\..\test\FacePlane.cpp" />
+    <ClCompile Include="..\..\..\test\FileTypes.cpp" />
     <ClCompile Include="..\..\..\test\HeadlessOpenGLContext.cpp" />
     <ClCompile Include="..\..\..\test\MapExport.cpp" />
     <ClCompile Include="..\..\..\test\Materials.cpp" />
diff --git a/tools/msvc/Tests/Tests.vcxproj.filters b/tools/msvc/Tests/Tests.vcxproj.filters
index ecf16b57ec..ebd25ba80d 100644
--- a/tools/msvc/Tests/Tests.vcxproj.filters
+++ b/tools/msvc/Tests/Tests.vcxproj.filters
@@ -26,6 +26,7 @@
     <ClCompile Include="..\..\..\test\Models.cpp" />
     <ClCompile Include="..\..\..\test\Face.cpp" />
     <ClCompile Include="..\..\..\test\Selection.cpp" />
+    <ClCompile Include="..\..\..\test\FileTypes.cpp" />
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="..\..\..\test\HeadlessOpenGLContext.h" />