From 39d50c052aef91cfd1498bbc892b714a8fb47480 Mon Sep 17 00:00:00 2001 From: codereader Date: Thu, 28 Dec 2017 07:38:34 +0100 Subject: [PATCH] Algorithm functions should throw exceptions instead of displaying Messageboxes, adjust changeEntityClassname() function accordingly. --- radiant/selection/algorithm/Entity.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/radiant/selection/algorithm/Entity.cpp b/radiant/selection/algorithm/Entity.cpp index a0e27215ab..5c177dc737 100644 --- a/radiant/selection/algorithm/Entity.cpp +++ b/radiant/selection/algorithm/Entity.cpp @@ -103,8 +103,7 @@ void setEntityClassname(const std::string& classname) { if (classname.empty()) { - wxutil::Messagebox::ShowError(_("Cannot set classname to an empty string.")); - return; + throw std::runtime_error(_("Cannot set classname to an empty string.")); } if (classname == "worldspawn")