#5532: Set material type on choice

codereader · Mar 12, 2021 · 8521dbe · 8521dbe
1 parent 975ec22
commit 8521dbe
Show file tree

Hide file tree

Showing 7 changed files with 40 additions and 0 deletions.
diff --git a/include/ishaders.h b/include/ishaders.h
@@ -236,6 +236,9 @@ class Material
 	/// Surface Type (wood, stone, surfType15, ...)
 	virtual SurfaceType getSurfaceType() const = 0;
 
+    // Set the surface type of this material
+    virtual void setSurfaceType(SurfaceType type) = 0;
+
 	/// Get the deform type of this material
 	virtual DeformType getDeformType() const = 0;
 

diff --git a/libs/materials/ParseLib.h b/libs/materials/ParseLib.h
@@ -39,6 +39,19 @@ inline std::string getStringForSurfaceType(Material::SurfaceType type)
     return std::string();
 }
 
+inline Material::SurfaceType getSurfaceTypeForString(const std::string& surfaceTypeString)
+{
+    for (const auto& pair : SurfaceTypeMapping)
+    {
+        if (surfaceTypeString == pair.first)
+        {
+            return pair.second;
+        }
+    }
+
+    return Material::SURFTYPE_DEFAULT;
+}
+
 constexpr std::pair<const char*, Material::SortRequest> PredefinedSortValues[]
 {
     { "subview", Material::SORT_SUBVIEW },

diff --git a/radiant/ui/materials/MaterialEditor.cpp b/radiant/ui/materials/MaterialEditor.cpp
@@ -155,6 +155,8 @@ void MaterialEditor::setupMaterialProperties()
         typeDropdown->AppendString(pair.first);
     }
 
+    typeDropdown->Bind(wxEVT_CHOICE, &MaterialEditor::_onMaterialTypeChoice, this);
+
     auto* sortDropdown = getControl<wxComboBox>("MaterialSortValue");
 
     sortDropdown->AppendString(""); // empty string for undefined
@@ -1084,4 +1086,12 @@ void MaterialEditor::updateStageControls()
     }
 }
 
+void MaterialEditor::_onMaterialTypeChoice(wxCommandEvent& ev)
+{
+    if (!_material) return;
+
+    auto selectedString = getControl<wxChoice>("MaterialType")->GetStringSelection();
+    _material->setSurfaceType(shaders::getSurfaceTypeForString(selectedString.ToStdString()));
+}
+
 }
diff --git a/radiant/ui/materials/MaterialEditor.h b/radiant/ui/materials/MaterialEditor.h
@@ -92,6 +92,7 @@ class MaterialEditor :
 
     void _onTreeViewSelectionChanged(wxDataViewEvent& ev);
     void _onStageListSelectionChanged(wxDataViewEvent& ev);
+    void _onMaterialTypeChoice(wxCommandEvent& ev);
 
     // Shortcut
     template<typename ObjectClass>

diff --git a/radiantcore/shaders/CShader.cpp b/radiantcore/shaders/CShader.cpp
@@ -185,6 +185,12 @@ Material::SurfaceType CShader::getSurfaceType() const
 	return _template->getSurfaceType();
 }
 
+void CShader::setSurfaceType(SurfaceType type)
+{
+    ensureTemplateCopy();
+    _template->setSurfaceType(type);
+}
+
 Material::DeformType CShader::getDeformType() const
 {
 	return _template->getDeformType();

diff --git a/radiantcore/shaders/CShader.h b/radiantcore/shaders/CShader.h
@@ -72,6 +72,7 @@ class CShader final :
 	ClampType getClampType() const override;
 	int getSurfaceFlags() const override;
 	SurfaceType getSurfaceType() const override;
+    void setSurfaceType(SurfaceType type) override;
 	DeformType getDeformType() const override;
 	IShaderExpressionPtr getDeformExpression(std::size_t index) override;
     std::string getDeformDeclName() override;

diff --git a/radiantcore/shaders/ShaderTemplate.h b/radiantcore/shaders/ShaderTemplate.h
@@ -207,6 +207,12 @@ class ShaderTemplate final
 		return _surfaceType;
 	}
 
+    void setSurfaceType(Material::SurfaceType type)
+    {
+        if (!_parsed) parseDefinition();
+        _surfaceType = type;
+    }
+
 	Material::DeformType getDeformType()
 	{
 		if (!_parsed) parseDefinition();