From bae10272ee1c4bab7af2b4dbba0e588e46f45d99 Mon Sep 17 00:00:00 2001 From: codereader Date: Sun, 19 Feb 2017 06:29:07 +0100 Subject: [PATCH] Fix GroupDialog tabs behaviour in OSX. --- plugins/uimanager/GroupDialog.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/uimanager/GroupDialog.cpp b/plugins/uimanager/GroupDialog.cpp index 0dc372b8ae..f20a8328b5 100644 --- a/plugins/uimanager/GroupDialog.cpp +++ b/plugins/uimanager/GroupDialog.cpp @@ -281,9 +281,6 @@ wxWindow* GroupDialog::addPage(const PagePtr& page) page->page->Reparent(_notebook.get()); _notebook->InsertPage(insertPosition, page->page, page->tabLabel, false, imageId); - // Call Show() on the tab content again, otherwise it ends up invisible in OSX - page->page->Show(); - // Add this page by copy to the local list _pages.insert(std::make_pair(page->position, Page(*page))); @@ -318,6 +315,9 @@ void GroupDialog::updatePageTitle(int pageNumber) void GroupDialog::onPageSwitch(wxBookCtrlEvent& ev) { updatePageTitle(ev.GetSelection()); + + // Be sure to skip the event, otherwise pages stay hidden + ev.Skip(); } } // namespace ui