Skip to content

Commit

Permalink
- fixed: menu sounds no longer got the CHANF_UI flag.
Browse files Browse the repository at this point in the history
  • Loading branch information
coelckers committed Jan 4, 2020
1 parent a588c24 commit 4646273
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion wadsrc/static/zscript/ui/menu/menu.zs
Expand Up @@ -284,7 +284,7 @@ class Menu : Object native ui version("2.4")

static void MenuSound(Sound snd)
{
S_StartSound (snd, CHAN_VOICE, CHANF_MAYBE_LOCAL, snd_menuvolume, ATTN_NONE);
S_StartSound (snd, CHAN_VOICE, CHANF_MAYBE_LOCAL|CHAN_UI, snd_menuvolume, ATTN_NONE);
}

deprecated("4.0") static void DrawConText (int color, int x, int y, String str)
Expand Down
2 changes: 1 addition & 1 deletion wadsrc/static/zscript/ui/statscreen/statscreen.zs
Expand Up @@ -715,7 +715,7 @@ class StatusScreen abstract play version("2.5")

static void PlaySound(Sound snd)
{
S_StartSound(snd, CHAN_VOICE, CHANF_MAYBE_LOCAL, 1, ATTN_NONE);
S_StartSound(snd, CHAN_VOICE, CHANF_MAYBE_LOCAL|CHANF_UI, 1, ATTN_NONE);
}


Expand Down

2 comments on commit 4646273

@Doom2fan
Copy link
Contributor

@Doom2fan Doom2fan commented on 4646273 Jan 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There also seem to be extraneous MAYBE_LOCAL flags added there... The old code didn't have those there, and I don't think it'd do anything useful here.

@coelckers
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was the problem - something was badly translated. The flag is inconsequential for the menu, but it surely can be removed again.

Please sign in to comment.