Add full Python 3 compatibility #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Share this setup between tests. This makes the output order the same on Python 2 and 3. See issue #31.
This reported a different order and under Python 3 contained text marked as b'bytes'.
I had hoped that this version could be installed under Python 3, but unfortunately not. Still, let's use the latest one, so that others are not left wondering the same thing.
Created new zope2instance.rst file for this, containing what used to be the first part of blob.rst. zope2instance.rst is expected to fail on Python 3, because mailinglogger is not compatible. All other test files should pass.
They would need a compatible ``mailinglogger`` package. See issue #31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well... the integration with
plone.recipe.zope2instancecannot be tested, because itsmailingloggerdependency cannot even be installed on Python 3. See this mailinglogger issue.I opted to split out the zope2instance related tests to
zope2instance.rstand ignore this test file on Python 3. We can revisit this once compatible versions are out. The only integration we have with this recipe, is that we look for a blob_storage option if we do not have one in our own backup section.Anyway, the rest of the tests now pass. Travis will now test Python 2.6, 2.7, and 3.6.
Until now we created a mock
repozoscript in most of the test files. Now I do this in the test setup intest_docs.py. I let the repozo script put its output in a temporary file and check the output separately from the buildout output. Until now they were mixed, which gave a different order in Python 2 versus 3.