Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-ascii values in the query. #179

Merged
merged 1 commit into from Jul 17, 2017
Merged

Handle non-ascii values in the query. #179

merged 1 commit into from Jul 17, 2017

Conversation

reinhardt
Copy link
Contributor

Fixes UnicodeDecodeError when searching for non-ascii text

@reinhardt
Copy link
Contributor Author

Hey @tisto, would you have a moment to review this?
The build fails with version conflicts, is that a known issue?

@tisto
Copy link
Member

tisto commented Jul 14, 2017

@reinhardt looks like a problem with a zc.buildout version. We might want to switch to a virtualenv approach on travis to fix this.

@tisto
Copy link
Member

tisto commented Jul 14, 2017

@reinhardt pls merge master into your branch. This should fix the issue.

@reinhardt
Copy link
Contributor Author

Thanks! I've rebased.

@reinhardt
Copy link
Contributor Author

Yup, that did it!

@tisto tisto merged commit 9236698 into master Jul 17, 2017
@tisto tisto deleted the query-utf8 branch July 17, 2017 09:12
@reinhardt
Copy link
Contributor Author

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reinhardt @tisto