Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Form - Upload attachments #7983

Closed
a3020 opened this issue Jul 11, 2019 · 2 comments
Closed

Express Form - Upload attachments #7983

a3020 opened this issue Jul 11, 2019 · 2 comments

Comments

@a3020
Copy link
Contributor

a3020 commented Jul 11, 2019

A client reports that images that are uploaded via an Express Form with an HTML input field, are not sent in the form submission email.

I looked at the mail template, and these lines grabbed my attention:
https://github.com/concrete5/concrete5/blob/5d13e4c0134c24210135c17d5187d064963069a2/concrete/mail/block_express_form_submission.php#L10-L14

From the notification class, we see that 'dataSaveEnabled' should come from the block controller.
https://github.com/concrete5/concrete5/blob/3b90f4558a29a77ac320db975ee56751d5f681da/concrete/src/Express/Entry/Notifier/Notification/FormBlockSubmissionEmailNotification.php#L100

It doesn't seem that this property exists, am I correct?
https://github.com/concrete5/concrete5/blob/develop/concrete/blocks/express_form/db.xml
https://github.com/concrete5/concrete5/blob/develop/concrete/blocks/express_form/controller.php
https://github.com/concrete5/concrete5/search?q=saveData&unscoped_q=saveData

I guess this is a bug, and I assume that storeFormSubmission should be used instead.

@aembler
Copy link
Member

aembler commented Jul 11, 2019

Good catch. #7987 should fix this issue.

aembler added a commit that referenced this issue Jul 11, 2019
Fix #7983; Make default contact form in Elemental store its data again
@a3020
Copy link
Contributor Author

a3020 commented Jul 12, 2019

Thanks @aembler 💪

acohin pushed a commit to acohin/concrete5 that referenced this issue Feb 9, 2020
acohin pushed a commit to acohin/concrete5 that referenced this issue Feb 9, 2020
Fix concretecms#7983; Make default contact form in Elemental store its data again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants