Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Page Search, you cannot copy multiple pages #8521

Closed
katzueno opened this issue Apr 6, 2020 · 2 comments
Closed

In Page Search, you cannot copy multiple pages #8521

katzueno opened this issue Apr 6, 2020 · 2 comments
Labels
Bug Priority:Medium There’s a viable work around, but fixing this would make things much better. Product Areas:Sitemap Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected.

Comments

@katzueno
Copy link
Contributor

katzueno commented Apr 6, 2020

Confirmed on a fresh install of 8.5.2

When you try to copy multiple pages,
You get Call to a member function isExternalLink() on null error and cannot copy multiple pages.

image

Now you need to copy pages one by one.. which is kinda troublesome.

The trace


/Users/katz/Sites/c5852/concrete/views/dialogs/page/drag_request.php(78): Error->null |  
-- | --
/Users/katz/Sites/c5852/concrete/src/View/View.php(267): null->include |  
/Users/katz/Sites/c5852/concrete/src/View/View.php(245): Concrete\Core\View\View->renderInnerContents |  
/Users/katz/Sites/c5852/concrete/src/View/AbstractView.php(164): Concrete\Core\View\View->renderViewContents |  
/Users/katz/Sites/c5852/concrete/src/Routing/ControllerRouteAction.php(82): Concrete\Core\View\AbstractView->render |  
/Users/katz/Sites/c5852/concrete/src/Http/RouteDispatcher.php(37): Concrete\Core\Routing\ControllerRouteAction->execute |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/DispatcherDelegate.php(39): Concrete\Core\Http\RouteDispatcher->dispatch |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/MiddlewareStack.php(86): Concrete\Core\Http\Middleware\DispatcherDelegate->next |  
/Users/katz/Sites/c5852/concrete/src/Http/DefaultDispatcher.php(125): Concrete\Core\Http\Middleware\MiddlewareStack->process |  
/Users/katz/Sites/c5852/concrete/src/Http/DefaultDispatcher.php(58): Concrete\Core\Http\DefaultDispatcher->handleDispatch |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/DispatcherDelegate.php(39): Concrete\Core\Http\DefaultDispatcher->dispatch |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/ThumbnailMiddleware.php(76): Concrete\Core\Http\Middleware\DispatcherDelegate->next |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\ThumbnailMiddleware->process |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/FrameOptionsMiddleware.php(39): Concrete\Core\Http\Middleware\MiddlewareDelegate->next |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\FrameOptionsMiddleware->process |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/CookieMiddleware.php(35): Concrete\Core\Http\Middleware\MiddlewareDelegate->next |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\CookieMiddleware->process |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/ApplicationMiddleware.php(29): Concrete\Core\Http\Middleware\MiddlewareDelegate->next |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\ApplicationMiddleware->process |  
/Users/katz/Sites/c5852/concrete/src/Http/Middleware/MiddlewareStack.php(86): Concrete\Core\Http\Middleware\MiddlewareDelegate->next |  
/Users/katz/Sites/c5852/concrete/src/Http/DefaultServer.php(85): Concrete\Core\Http\Middleware\MiddlewareStack->process |  
/Users/katz/Sites/c5852/concrete/src/Foundation/Runtime/Run/DefaultRunner.php(128): Concrete\Core\Http\DefaultServer->handleRequest |  
/Users/katz/Sites/c5852/concrete/src/Foundation/Runtime/DefaultRuntime.php(102): Concrete\Core\Foundation\Runtime\Run\DefaultRunner->run |  
/Users/katz/Sites/c5852/concrete/dispatcher.php(45): Concrete\Core\Foundation\Runtime\DefaultRuntime->run |  
/Users/katz/Sites/c5852/index.php(3): null->require |  
/Users/katz/.composer/vendor/laravel/valet/server.php(158): null->require |  
@eskema
Copy link

eskema commented Apr 8, 2020

I confirm this happens also when moving (not only copying), well, the error happens before the modal that let's you choose what to do. This is a really big problem for me at the moment.

@aembler aembler added Bug Priority:Medium There’s a viable work around, but fixing this would make things much better. Product Areas:Sitemap Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected. labels Apr 8, 2020
@hissy
Copy link
Contributor

hissy commented Sep 27, 2020

Fixed on #8291

@aembler aembler closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Priority:Medium There’s a viable work around, but fixing this would make things much better. Product Areas:Sitemap Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected.
Projects
None yet
Development

No branches or pull requests

4 participants