Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noticed 404 issues for asset. "GET /logo/conversejs-filled.svg HTTP/1.1" 404 #2326

Closed
Octothorn opened this issue Nov 2, 2020 · 10 comments
Closed
Labels

Comments

@Octothorn
Copy link

Octothorn commented Nov 2, 2020

Describe the bug
looks like it may be caused by an incomplete path for the logo directory, but have not traced it back.
I see;
"./converse-notification.js: notification_icon: 'logo/conversejs-filled.svg',"
Worked around it by symlinking the logo directory to the webroot for converse.js.

logo -> ./dist/images/logo

@Echolon Echolon added the bug label Apr 2, 2021
@licaon-kter
Copy link
Contributor

Still an issue

@jcbrand jcbrand closed this as completed in 90cac3e Sep 6, 2021
@licaon-kter
Copy link
Contributor

Updated to f40a8f6, while Firefox does not show any error, Vivaldi tried and failed to download a file: dist/images/logo/conversejs-filled.png

@jcbrand
Copy link
Member

jcbrand commented Sep 7, 2021

You'll need to run make dist first, otherwise the file will not be there.

@licaon-kter
Copy link
Contributor

My script does this:

make clean
git reset --hard
git pull
npm install
make -j4 dist

...it's not enough?

@jcbrand
Copy link
Member

jcbrand commented Sep 8, 2021

That should be enough, can you check that you have this file? ./dist/images/logo/conversejs-filled.svg?

@licaon-kter
Copy link
Contributor

I do have that and 192 and 512 (these have PNGs versions too)

@jcbrand
Copy link
Member

jcbrand commented Sep 8, 2021

Then I fail to see how a 404 should occur, unless there is somewhere a relative URL being used and not an absolute URL

@licaon-kter
Copy link
Contributor

licaon-kter commented Sep 8, 2021

You've asked about SVG... I have the SVG for this file NOT the PNG the log says it wants.

For the other two I have both PNG and SVG.

The file is missing...yes

@jcbrand
Copy link
Member

jcbrand commented Sep 8, 2021

grep -r "conversejs-filled.png" src returns zero results.

That file name isn't being used anywhere in code.

@licaon-kter
Copy link
Contributor

And you are right, it was my manifest.json that had it, sorry for the noise :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants