@@ -1,15 +1,19 @@ Thank you for your willingness to help make NumPy the best array system available. -The only rules we like to follow are to try hard to keep the SVN -repository in a buildable state and to not indiscriminately muck with -what others have contributed. +We have a few simple rules: -Simple changes and obvious improvements are always welcome. Changes -that fundamentally change behavior need discussion on -numpy-discussions@scipy.org before anything is done. + * try hard to keep the SVN repository in a buildable state and to not + indiscriminately muck with what others have contributed. + * Simple changes (including bug fixes) and obvious improvements are + always welcome. Changes that fundamentally change behavior need + discussion on numpy-discussions@scipy.org before anything is + done. + + * Please add meaningful comments when you check changes in. These + comments form the basis of the change-log. + + * Add unit tests to excercise new code, and regression tests + whenever you fix a bug. -Please add meaningful comments when you check changes in. These comments -form the basis of the change-log. Add unit tests to excercise new -code, and regression tests whenever you fix a bug. DEV_README.txt @@ -6781,12 +6781,12 @@ array_data_get(PyArrayObject *self) return NULL; } nbytes = PyArray_NBYTES(self); - if PyArray_ISWRITEABLE(self) { - return PyBuffer_FromReadWriteObject((PyObject *)self, 0, (int) nbytes); - } - else { - return PyBuffer_FromObject((PyObject *)self, 0, (int) nbytes); - } + if PyArray_ISWRITEABLE(self) + return PyBuffer_FromReadWriteObject((PyObject *)self, 0, + (Py_ssize_t) nbytes); + else + return PyBuffer_FromObject((PyObject *)self, 0, + (Py_ssize_t) nbytes); } static int numpy/core/src/arrayobject.c 9d329ef2c93e47820ea0f2daa02f4607cf17c3db oliphant oliphant@94b884b6-d6fd-0310-90d3-974f1d3f35e1 http://github.com/cournape/numpy/commit/4423cbfe73cb2a64beb91cd7a022a89a027dc058 4423cbfe73cb2a64beb91cd7a022a89a027dc058 2009-03-04T09:14:10-08:00 2009-03-04T09:14:10-08:00 Minor changes to DEV_README + fix to a 64-bit issue. git-svn-id: http://svn.scipy.org/svn/numpy/trunk@6545 94b884b6-d6fd-0310-90d3-974f1d3f35e1 a9b00487aa62926e8a44144ef5bb1c85efd5922c oliphant oliphant@94b884b6-d6fd-0310-90d3-974f1d3f35e1