@@ -16,4 +16,5 @@ Since I first released this library, there's been several people who have submit - Benoit Caccinolo - John Barton - Oliver Beddows -- Arthur Zapparoli \ No newline at end of file +- Arthur Zapparoli +- Dusty Doris \ No newline at end of file README @@ -39,7 +39,8 @@ module ThinkingSphinx # Check if index definition is disabled. # def self.define_indexes? - @@define_indexes ||= true + @@define_indexes = true unless defined?(@@define_indexes) + @@define_indexes == true end # Enable/disable indexes - you may want to do this while migrating data. @@ -53,7 +54,8 @@ module ThinkingSphinx # Check if delta indexing is enabled. # def self.deltas_enabled? - @@deltas_enabled ||= true + @@deltas_enabled = true unless defined?(@@deltas_enabled) + @@deltas_enabled == true end # Enable/disable all delta indexing. lib/thinking_sphinx.rb @@ -264,7 +264,7 @@ module ThinkingSphinx # normal attribute filters client.filters += options[:with].collect { |attr,val| Riddle::Client::Filter.new attr.to_s, filter_value(val) - } if options[:where] + } if options[:with] # exclusive attribute filters client.filters += options[:without].collect { |attr,val| lib/thinking_sphinx/search.rb @@ -1,5 +1,35 @@ require 'spec/spec_helper' describe ThinkingSphinx do - # + it "should define indexes by default" do + ThinkingSphinx.define_indexes?.should be_true + end + + it "should disable index definition" do + ThinkingSphinx.define_indexes = false + ThinkingSphinx.define_indexes?.should be_false + end + + it "should enable index definition" do + ThinkingSphinx.define_indexes = false + ThinkingSphinx.define_indexes?.should be_false + ThinkingSphinx.define_indexes = true + ThinkingSphinx.define_indexes?.should be_true + end + + it "should index deltas by default" do + ThinkingSphinx.deltas_enabled?.should be_true + end + + it "should disable delta indexing" do + ThinkingSphinx.deltas_enabled = false + ThinkingSphinx.deltas_enabled?.should be_false + end + + it "should enable delta indexing" do + ThinkingSphinx.deltas_enabled = false + ThinkingSphinx.deltas_enabled?.should be_false + ThinkingSphinx.deltas_enabled = true + ThinkingSphinx.deltas_enabled?.should be_true + end end \ No newline at end of file spec/unit/thinking_sphinx_spec.rb eb8ea55c2b5258d74c505bdeac953d16086b4f03 Pat Allan pat@freelancing-gods.com http://github.com/crafterm/thinking-sphinx/commit/f6b9ce423c73625a47b03fe7fd139b2be20a503b f6b9ce423c73625a47b03fe7fd139b2be20a503b 2008-04-15T17:35:23-07:00 2008-04-15T17:35:23-07:00 Adding new contributor to README, adding more bug fixes from Oliver Beddows (including specs! top marks) 07df39ab3d8c0767733cab08d2f11daa038bf198 Pat Allan pat@freelancing-gods.com