@@ -1,3 +1,7 @@ +== 0.1.1 2009-01-24 +* Bugfix: + * #cached_xml_response was being called twice if there was a cached response + == 0.1.0 2008-05-12 * 1 major enhancement: * Converted to gem from Rails plugin History.txt @@ -113,7 +113,8 @@ module EbayShopping # the DB or file system) by calling #cached_response before making the call, and passing the response to #cache_response after making it. def call(url) check_error_cache - return cached_xml_response if cached_xml_response + cached_response = cached_xml_response + return cached_response if cached_response fresh_response = _http_get(url) cache_response(fresh_response) fresh_response lib/ebay_shopping.rb @@ -101,6 +101,15 @@ class TestEbayShopping < Test::Unit::TestCase request.send(:call, "http://some.url") end + def test_should_return_cached_response_if_it_exists + cached_response = stub + request = new_ebay_request + request.expects(:cached_xml_response).returns(cached_response) + request.expects(:_http_get).never + + assert_equal cached_response, request.send(:call, "http://some.url") + end + def test_should_check_error_cache_when_call_is_made request = new_ebay_request request.stubs(:_http_get).returns(@find_items_response) test/test_ebay_shopping.rb @@ -2,7 +2,6 @@ h1. ebay_shopping h1. → 'ebay_shopping' - h2. What A Ruby library for the fast-and-simple ebay Shopping API. For details see the Introduction, or the README file. There's also a blog post detailing usage at: "http://pushrod.wordpress.com/2008/01/13/a-rubyonrails-library-for-the-ebay-shopping-api/":http://pushrod.wordpress.com/2008/01/13/a-rubyonrails-library-for-the-ebay-shopping-api/ website/index.txt 8ec1f9c3242f85033efaf5efa62c0ac79a7883cc Chris Taggart chris@windowsxponmac.home http://github.com/ctagg/ebay_shopping/commit/d96e1da20902c19a0af0cd69ac7617e074f849e4 d96e1da20902c19a0af0cd69ac7617e074f849e4

2009-01-24T05:34:30-08:00

Bugfix: #cached_xml_response was being called twice if there was a cached response 7b28ef509094270cf11cf3c5e61e3af81da4bf34 Chris Taggart chris@windowsxponmac.home