Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSRF protection #59

Closed
magnusdahlstrand opened this issue Apr 27, 2016 · 9 comments
Closed

CSRF protection #59

magnusdahlstrand opened this issue Apr 27, 2016 · 9 comments

Comments

@magnusdahlstrand
Copy link
Contributor

A middleware based approach (using https://github.com/pillarjs/csrf) exposing the CSRF token to the templating layer through a global property or helper.

@jimlambie
Copy link
Contributor

jimlambie commented Aug 6, 2016

@mdahlstrand or @adamkdean: perhaps have a look at integrating https://www.npmjs.com/package/csurf

Unsure which of you has the most time to burn at the moment, please pick it up if you're able!

@jimlambie jimlambie added this to the 1.7.0 milestone Aug 6, 2016
@jimlambie jimlambie removed this from the 1.7.0 milestone Nov 22, 2016
@adamkdean
Copy link
Contributor

I will be looking at this ticket soon. 🎟

@eduardoboucas
Copy link
Contributor

What's the status on this?

@adamkdean do you need a ✋ ?

@adamkdean
Copy link
Contributor

@eduardoboucas I believe I added the CSRF token to the view model, but the validation of the token is still pending. If you have the time to pick this up then that'd be greatly appreciated! Thanks!

@abovedave
Copy link
Contributor

BUMP on this.

You seem real close @adamkdean?

@adamkdean
Copy link
Contributor

Ah, this hasn't been picked up? I'll find some time this week or next and get this finished.

@abovedave
Copy link
Contributor

Many thanks! Some docs would be the icing on the cake too 🍰

https://github.com/dadi/docs/blob/new/docs/web.md#csrf-tokens

@adamkdean
Copy link
Contributor

I do like 🍰. I'll get you some docs as well. 🙇

@adamkdean
Copy link
Contributor

@abovebored take a look and let me know what you think. Have updated the docs also.

🍰 😋 🔏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Web 3.0
Backlog
Development

No branches or pull requests

5 participants