[do_hdqldb,do_mysql,do_oracle,do_postgres,do_sqlite3] Added support f…

…or subclasses of supported types - p.2
datamapper · Nov 14, 2009 · 441ecd5 · 441ecd5
1 parent 59923d1
commit 441ecd5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 11 deletions.
diff --git a/do_hsqldb/ext-java/src/main/java/do_hsqldb/HsqldbDriverDefinition.java b/do_hsqldb/ext-java/src/main/java/do_hsqldb/HsqldbDriverDefinition.java
@@ -40,11 +40,8 @@ public HsqldbDriverDefinition() {
     @Override
     public void setPreparedStatementParam(PreparedStatement ps,
             IRubyObject arg, int idx) throws SQLException {
-        switch (RubyType.getRubyType(arg.getType().getName())) {
+        switch (RubyType.inferRubyType(arg)) {
         case NIL:
-            // XXX ps.getParameterMetaData().getParameterType(idx) produces
-            // com.mysql.jdbc.ResultSetMetaData:397:in `getField': java.lang.NullPointerException
-            // from com.mysql.jdbc.ResultSetMetaData:275:in `getColumnType'
             ps.setNull(idx, Types.NULL);
             break;
         default:

diff --git a/do_mysql/ext-java/src/main/java/do_mysql/MySqlDriverDefinition.java b/do_mysql/ext-java/src/main/java/do_mysql/MySqlDriverDefinition.java
@@ -67,7 +67,7 @@ public IRubyObject getTypecastResultSetValue(Ruby runtime,
     @Override
     public void setPreparedStatementParam(PreparedStatement ps,
             IRubyObject arg, int idx) throws SQLException {
-        switch (RubyType.getRubyType(arg.getType().getName())) {
+        switch (RubyType.inferRubyType(arg)) {
         case NIL:
             // XXX ps.getParameterMetaData().getParameterType(idx) produces
             // com.mysql.jdbc.ResultSetMetaData:397:in `getField': java.lang.NullPointerException

diff --git a/do_oracle/ext-java/src/main/java/do_oracle/OracleDriverDefinition.java b/do_oracle/ext-java/src/main/java/do_oracle/OracleDriverDefinition.java
@@ -131,11 +131,8 @@ public IRubyObject getTypecastResultSetValue(Ruby runtime,
     @Override
     public void setPreparedStatementParam(PreparedStatement ps,
             IRubyObject arg, int idx) throws SQLException {
-        switch (RubyType.getRubyType(arg.getType().getName())) {
+        switch (RubyType.inferRubyType(arg)) {
         case NIL:
-            // XXX ps.getParameterMetaData().getParameterType(idx) produces
-            // com.mysql.jdbc.ResultSetMetaData:397:in `getField': java.lang.NullPointerException
-            // from com.mysql.jdbc.ResultSetMetaData:275:in `getColumnType'
             ps.setNull(idx, Types.NULL);
             break;
         default:

diff --git a/do_postgres/ext-java/src/main/java/do_postgres/PostgresDriverDefinition.java b/do_postgres/ext-java/src/main/java/do_postgres/PostgresDriverDefinition.java
@@ -75,7 +75,7 @@ public Properties getDefaultConnectionProperties() {
     public void setPreparedStatementParam(PreparedStatement ps,
             IRubyObject arg, int idx) throws SQLException {
         int jdbcType;
-        switch (RubyType.getRubyType(arg.getType().getName())) {
+        switch (RubyType.inferRubyType(arg)) {
         case STRING:
             jdbcType = ps.getParameterMetaData().getParameterType(idx);
             switch (jdbcType) {

diff --git a/do_sqlite3/ext-java/src/main/java/do_sqlite3/Sqlite3DriverDefinition.java b/do_sqlite3/ext-java/src/main/java/do_sqlite3/Sqlite3DriverDefinition.java
@@ -160,7 +160,7 @@ public IRubyObject getTypecastResultSetValue(Ruby runtime,
     @Override
     public void setPreparedStatementParam(PreparedStatement ps,
             IRubyObject arg, int idx) throws SQLException {
-        switch (RubyType.getRubyType(arg.getType().getName())) {
+        switch (RubyType.inferRubyType(arg)) {
         case BIG_DECIMAL:
             ps.setString(idx, ((RubyBigDecimal) arg).toString());
             break;