@@ -42,7 +42,7 @@ module ActiveMerchant BANK_ERROR = REALEX_ERROR = "Gateway is in maintenance. Please try again later." ERROR = CLIENT_DEACTIVATED = "Gateway Error" - # Unique to the Realex gateway, it requires a separate secret password used to provide refunds/credits. + # Unique to the Realex gateway, it requires a separate secret password used to provide credits/refunds. attr_accessor :refundhash def initialize(options = {}) @@ -195,7 +195,7 @@ module ActiveMerchant end def build_purchase_or_authorization_request(action, money, credit_card, options) - timestamp = Time.now.strftime('%Y%m%d%H%M%S') + timestamp = self.class.timestamp xml = Builder::XmlMarkup.new :indent => 2 xml.tag! 'request', 'timestamp' => timestamp, 'type' => 'auth' do @@ -267,7 +267,7 @@ module ActiveMerchant # <md5hash>738e83....34ae662a</md5hash> # </request> def build_rebate_request(money, options) - timestamp = Time.now.strftime('%Y%m%d%H%M%S') + timestamp = self.class.timestamp xml = Builder::XmlMarkup.new :indent => 2 xml.tag! 'request', 'timestamp' => timestamp, 'type' => 'rebate' do @@ -302,7 +302,7 @@ module ActiveMerchant # <md5hash>34e7....a77d</md5hash> # </request> def build_void_request(options) - timestamp = Time.now.strftime('%Y%m%d%H%M%S') + timestamp = self.class.timestamp xml = Builder::XmlMarkup.new :indent => 2 xml.tag! 'request', 'timestamp' => timestamp, 'type' => 'void' do @@ -333,7 +333,7 @@ module ActiveMerchant # <sha1hash>7384ae67....ac7d7d</sha1hash> # </request> def build_settle_request(options) - timestamp = Time.now.strftime('%Y%m%d%H%M%S') + timestamp = self.class.timestamp xml = Builder::XmlMarkup.new :indent => 2 xml.tag! 'request', 'timestamp' => timestamp, 'type' => 'settle' do @@ -342,9 +342,10 @@ module ActiveMerchant xml.tag! 'orderid', sanitize_order_id(options[:order_id]) xml.tag! 'pasref', options[:pasref] xml.tag! 'authcode', options[:authcode] - xml.tag! 'comments' do - xml.tag! 'comment', options[:description], 'id' => 1 - xml.tag! 'comment', 'id' => 2 + if options[:description] + xml.tag! 'comments' do + xml.tag! 'comment', options[:description], 'id' => 1 + end end xml.tag! 'sha1hash', sha1from("#{timestamp}.#{@options[:login]}.#{sanitize_order_id(options[:order_id])}") end @@ -398,6 +399,10 @@ module ActiveMerchant def sanitize_order_id(order_id) order_id.to_s.gsub(/[^a-zA-Z0-9\-_]/, '') end + + def self.timestamp + Time.now.strftime('%Y%m%d%H%M%S') + end end end end \ No newline at end of file lib/active_merchant/billing/gateways/realex.rb @@ -3,14 +3,20 @@ require 'digest/sha1' class RealexTest < Test::Unit::TestCase + class ActiveMerchant::Billing::RealexGateway + # For the purposes of testing, lets redefine some protected methods as public. + public :build_purchase_or_authorization_request, :build_rebate_request, :build_void_request, :build_settle_request + end + def setup @login = 'your_merchant_id' @password = 'your_secret' + @account = 'your_account' @gateway = RealexGateway.new( - :login => @merchant_id, - :password => @secret, - :account => '' + :login => @login, + :password => @password, + :account => @account ) @gateway_with_account = RealexGateway.new( @@ -35,7 +41,6 @@ class RealexTest < Test::Unit::TestCase @amount = 100 end - def test_in_test assert_equal :test, ActiveMerchant::Billing::Base.gateway_mode end @@ -109,6 +114,29 @@ class RealexTest < Test::Unit::TestCase assert_equal 'M', response.cvv_result['code'] end + def test_capture_xml + options = { + :pasref => '1234', + :authcode => '1234', + :order_id => '1' + } + + ActiveMerchant::Billing::RealexGateway.expects(:timestamp).returns('20090824160201') + + valid_capture_xml = <<-SRC +<request timestamp="20090824160201" type="settle"> + <merchantid>your_merchant_id</merchantid> + <account>your_account</account> + <orderid>1</orderid> + <pasref>1234</pasref> + <authcode>1234</authcode> + <sha1hash>a28e8d7ae105d98f8cf1a014786aed77bde6485a</sha1hash> +</request> +SRC + + assert_equal valid_capture_xml, @gateway.build_settle_request(options) + end + private def successful_purchase_response test/unit/gateways/realex_test.rb 1fb149614c55e98b1c594f8a1b308c9c7710e0ac David Rice davidjrice@gmail.com http://github.com/davidjrice/active_merchant/commit/56f040b229c4fec88ded451284c9a13a12b39aea 56f040b229c4fec88ded451284c9a13a12b39aea 2009-08-24T08:21:20-07:00 2009-08-24T08:21:20-07:00 Add xml generation test for realex capture request 536e11ed91b750aa3a0835348d0ca3e06c68154f David Rice davidjrice@gmail.com