@@ -51,6 +51,7 @@ IMPORTANT: This release includes the following backwards-compatibility-breaking
* create lib/tasks if not present when running script/generate rspec. Closes #687.
* fixed regression (and added spec so it won't regress again) where
render => :inline didn't render unless integrate_views was set
+ * fixed nil.with_output_buffer bug in helper specs. Closes #719.
=== Version 1.1.12 / 2009-01-11
History.txt
@@ -34,29 +34,15 @@ module Spec
attr_accessor :output_buffer
class HelperObject < ActionView::Base
+ def initialize(*args)
+ @template = self
+ super
+ end
def protect_against_forgery?
false
end
- def session=(session)
- @session = session
- end
-
- def request=(request)
- @request = request
- end
-
- def flash=(flash)
- @flash = flash
- end
-
- def params=(params)
- @params = params
- end
-
- def controller=(controller)
- @controller = controller
- end
+ attr_writer :session, :request, :flash, :params, :controller
private
attr_reader :session, :request, :flash, :params, :controller
@@ -113,7 +99,7 @@ module Spec
ActionView::Base.included_modules.reverse.each do |mod|
include mod if mod.parents.include?(ActionView::Helpers)
end
-
+
before(:each) do
@controller.request = @request
@controller.url = ActionController::UrlRewriter.new @request, {} # url_for
lib/spec/rails/example/helper_example_group.rb
@@ -204,3 +204,30 @@ module Spec
end
end
end
+
+module Bug719
+ # see http://rspec.lighthouseapp.com/projects/5645/tickets/719
+ # FIXME - helper and example provided in ticket. The example did
+ # fail initially, so running it now shows that the bug is fixed,
+ # but this doesn't serve as a good internal example.
+ module ImagesHelper
+ def hide_images_button
+ content_tag :div, :class => :hide_images_button do
+ button_to_function "Hide Images", :id => :hide_images_button do |page|
+ page[:more_images_button].toggle
+ page[:image_browser].toggle
+ end
+ end
+ end
+ end
+
+ describe ImagesHelper, :type => :helper do
+ it "should render a hide_images_button" do
+ helper.hide_images_button.should have_tag('div[class=?]','hide_images_button') do
+ with_tag('input[id=?][type=?][value=?][onclick^=?]',
+ 'hide_images_button', 'button', 'Hide Images',
+ "$("more_images_button").toggle();\n$("image_browser").toggle();;")
+ end
+ end
+ end
+end
spec/spec/rails/example/helper_example_group_spec.rb
597e76563daffa5e37ea70210252c6aec39619f1
David Chelimsky
dchelimsky@gmail.com
http://github.com/dchelimsky/rspec-rails/commit/804f8cbc0468b1fe632cfb6c488de28d0ed39155
804f8cbc0468b1fe632cfb6c488de28d0ed39155
2009-03-09T05:18:01-07:00
2009-03-09T05:17:55-07:00
fixed nil.with_output_buffer bug in helper specs
[#719 state:resolved milestone:'Next Release']
3f8fef9ec617a7ca0b2a699f4a08919dc6039927
David Chelimsky
dchelimsky@gmail.com