@@ -40,15 +40,14 @@ module Spec def tweak_backtrace(error) return if error.backtrace.nil? - error.backtrace.collect! do |line| - clean_up_double_slashes(line) - IGNORE_PATTERNS.each do |ignore| - if line =~ ignore - line = nil - break + error.backtrace.collect! do |message| + clean_up_double_slashes(message) + kept_lines = message.split("\n").select do |line| + IGNORE_PATTERNS.each do |ignore| + break if line =~ ignore end end - line + kept_lines.empty?? nil : kept_lines.join("\n") end error.backtrace.compact! end lib/spec/runner/backtrace_tweaker.rb @@ -51,6 +51,12 @@ module Spec @tweaker.tweak_backtrace(@error) @error.backtrace.should include("/a/b/c/d.rb") end + + it "should gracefully handle backtraces with newlines" do + @error.set_backtrace(["we like\nbin/spec:\nnewlines"]) + @tweaker.tweak_backtrace(@error) + @error.backtrace.should include("we like\nnewlines") + end end end end spec/spec/runner/quiet_backtrace_tweaker_spec.rb d95857c8ec3164eac3fc998ba09f41d821fb2fd6 Pat Maddox pat.maddox@gmail.com http://github.com/dchelimsky/rspec/commit/91290a511dd74c5b06bed2e2575a367af42c2345 91290a511dd74c5b06bed2e2575a367af42c2345 2008-07-12T19:15:39-07:00 2008-07-12T19:15:39-07:00 quiet backtrace tweaker filters individual lines out of multiline (ala Rails) error messages 697fe5ede486786e02e89988a75b10bc215747e5 Pat Maddox pat.maddox@gmail.com