@@ -1,17 +1,21 @@ === Maintenance +* 1 deprecation + + * deprecated ExampleMethods#implementation_backtrace - use ExampleMethods#backtrace instead + * 3 major enhancements * it { should matcher } - support for implicit receiver of #should (Joe Ferris of thoughtbot) * subject { ... } - works in conjunction with implicit receiver of #should * wrap_expectation (for wrapping multiple expectations and/or t/u assertions) -* 1 minor enhancement +* 2 minor enhancements * should throw_symbol accepts an optional argument: should throw_symbol(:sym, arg) * fixed --line for jruby (Zach Moazeni) -* 2 bug fixes +* 3 bug fixes * fixed bug where {:a => 1, :b => 2}.should include(:a, :b) failed (Yossef Mendelssohn) * only try to load Test::Unit if Test::Unit is defined History.txt @@ -4,7 +4,7 @@ module Spec extend ModuleReopeningFix - def subject # :nodoc: + def subject # :nodoc: this is somewhat experimental @subject ||= ( instance_variable_get(subject_variable_name) || instance_eval(&self.class.subject_block) || (described_class ? described_class.new : nil) ) @@ -64,20 +64,20 @@ module Spec success = execution_error.nil? || ExamplePendingError === execution_error end - def instance_variable_hash + def instance_variable_hash # :nodoc: instance_variables.inject({}) do |variable_hash, variable_name| variable_hash[variable_name] = instance_variable_get(variable_name) variable_hash end end - def eval_each_fail_fast(examples) #:nodoc: + def eval_each_fail_fast(examples) # :nodoc: examples.each do |example| instance_eval(&example) end end - def eval_each_fail_slow(examples) #:nodoc: + def eval_each_fail_slow(examples) # :nodoc: first_exception = nil examples.each do |example| begin @@ -110,13 +110,22 @@ module Spec end end - def eval_block + def eval_block # :nodoc: instance_eval(&@_implementation) end + # Provides the backtrace up to where this example was declared. def backtrace @backtrace end + + def implementation_backtrace + Kernel.warn <<-WARNING +ExampleMethods#implementation_backtrace is deprecated and will be removed +from a future version. Please use ExampleMethods#backtrace instead. +WARNING + backtrace + end private include Matchers lib/spec/example/example_methods.rb @@ -170,6 +170,28 @@ module Spec end end end + + describe "#implementation_backtrace (deprecated)" do + with_sandboxed_options do + before(:each) do + Kernel.stub!(:warn) + end + + it "sends a deprecation warning" do + example_group = Class.new(ExampleGroup) {} + example = example_group.example("") {} + Kernel.should_receive(:warn).with(/#implementation_backtrace.*deprecated.*#backtrace instead/m) + example.implementation_backtrace + end + + it "delegates to #backtrace" do + example_group = Class.new(ExampleGroup) {} + example = example_group.example("") {} + example.should_receive(:backtrace) + example.implementation_backtrace + end + end + end describe "#full_description" do it "should return the full description of the ExampleGroup and Example" do spec/spec/example/example_methods_spec.rb 19f6fb98fe540c5a79ac85a405f39cc6e90b06fd David Chelimsky dchelimsky@gmail.com http://github.com/dchelimsky/rspec/commit/931aa93fdf62c12388c4389601b739a7e723320f 931aa93fdf62c12388c4389601b739a7e723320f 2008-11-20T19:57:47-08:00 2008-11-20T19:57:38-08:00 deprecated ExampleMethods#implementation_backtrace - use ExampleMethods#backtrace instead [#609 state:resolved] c4174296337d9a7506e54abcbba6b06c361c7d27 David Chelimsky dchelimsky@gmail.com