@@ -1,20 +1,28 @@ +require 'activesupport' + module Stubble class ParameterMismatchError < StandardError end - + + class NoAccessError < StandardError + def initialize(*args) + super("Model was never accessed") + end + end + include Unimock - + module IdentifiableModel def with_id(id) self.id = id self end - + def new_record? !id end end - + module ValidModel # :nodoc: include IdentifiableModel class << self @@ -26,7 +34,7 @@ module Stubble end end end - + module InvalidModel # :nodoc: include IdentifiableModel class << self @@ -41,55 +49,77 @@ module Stubble end end end - + @@model_id = 1000 - + def next_id @@model_id += 1 end - + def build_stubs(klass, options={}) # :nodoc: + $current_stubble = {} options = {:as => :valid}.merge(options) instance_id = options[:id] ? options[:id].to_i : next_id - + instance = klass.new if options[:as] == :valid instance.extend(ValidModel) - stub_and_invoke(klass, :create) {|*params| generate_instance(instance.with_id(instance_id), options, params.first)} - stub_and_invoke(klass, :create!) {|*params| generate_instance(instance.with_id(instance_id), options, params.first)} + stub_and_invoke(klass, :create) do |*params| + __record_stubbled_klass_access + __generate_stubble_instance(instance.with_id(instance_id), options, params.first) + end + stub_and_invoke(klass, :create!) do |*params| + __record_stubbled_klass_access + __generate_stubble_instance(instance.with_id(instance_id), options, params.first) + end else instance.extend(InvalidModel) - stub_and_invoke(klass, :create) {instance.with_id(nil)} - stub_and_raise(klass, :create!, ActiveRecord::RecordInvalid.new(instance)) + stub_and_invoke(klass, :create) do + __record_stubbled_klass_access + instance.with_id(nil) + end + stub_and_invoke(klass, :create!) do + __record_stubbled_klass_access + raise ActiveRecord::RecordInvalid.new(instance) + end end - stub_and_invoke(klass, :new) {|*params| generate_instance(instance.with_id(nil), options, params.first)} - stub_and_return(klass, :all, [instance.with_id(instance_id)]) + instance.with_id(instance_id) + + stub_and_invoke(klass, :new) do |*params| + __record_stubbled_klass_access + __generate_stubble_instance(instance.with_id(nil), options, params.first) + end stub_and_invoke(klass, :find) do |*args| + __record_stubbled_klass_access args.first == :all ? [instance.with_id(instance_id)] : args.first.to_i == instance_id ? instance.with_id(instance_id) : (raise ActiveRecord::RecordNotFound.new(instance)) end + stub_and_invoke(klass, :all) { klass.find(:all) } instance end - - def generate_instance(instance, opts, params) + + def __record_stubbled_klass_access + $current_stubble[:accessed] = true + yield if block_given? + end + + def __generate_stubble_instance(instance, opts, params) if opts[:params] - expected, actual = stringify_keys(opts[:params]), stringify_keys(params) + expected = opts[:params].stringify_keys + actual = params ? params.stringify_keys : nil raise ParameterMismatchError.new("Expected params: #{expected.inspect}\n got: #{actual.inspect}") unless expected == actual end return instance end - - def stringify_keys(hash) - hash.inject({}) do |options, (key, value)| - options[key.to_s] = value - options - end + + def __verify_stubble + raise NoAccessError.new unless $current_stubble[:accessed] end - + # :call-seq: # stubbing(Thing) {|thing| ... } # stubbing(Thing, :as => invalid) {|thing| ... } @@ -99,6 +129,7 @@ module Stubble def stubbing(klass, options={:as => :valid}) instance = build_stubs(klass, options) yield instance + __verify_stubble reset end -end \ No newline at end of file +end lib/stubble/stubbing.rb @@ -20,7 +20,7 @@ module Mocha end module Unimock - include Mocha::Standalone + include Mocha::API def stub_and_return(obj, method, value) obj.stubs(method).returns(value) lib/unimock/mocha.rb @@ -10,7 +10,7 @@ module Unimock def stub_and_invoke(obj, method, &block) obj.stub(method, &block) end - + def reset $rspec_mocks.reset_all end lib/unimock/rspec.rb @@ -28,6 +28,15 @@ def raises_when_params_dont_match(method) end.to raise_error(Stubble::ParameterMismatchError, "Expected params: {\"this\"=>:that}\n got: {\"this\"=>:other}") end end + + context "but no creation method is received" do + it "raises" do + model = build_stubs(Model, :params => {:this => :that}) + expect {__verify_stubble}.to raise_error( + Stubble::NoAccessError + ) + end + end end end @@ -237,17 +246,77 @@ end context "stubbing" do it "yields the instance" do stubbing(Model) do |model| + Model.create # to suppress NoAccessError model.should_not be_nil end end - + it "tears down the stubs" do model = nil stubbing(Model) do + Model.create # to suppress NoAccessError def reset $reset_called = true end end $reset_called.should be_true end + + context "as valid" do + context "with new call" do + it "does not raise NoAccess" do + stubbing(Model) do |model| + Model.new + end + end + end + context "with find call" do + it "does not raise NoAccess" do + stubbing(Model) do |model| + Model.find(model.id) + end + end + end + context "with all call" do + it "does not raise NoAccess" do + stubbing(Model) do |model| + Model.all + end + end + end + context "with create call" do + it "does not raise NoAccess" do + stubbing(Model) do |model| + Model.create + end + end + end + context "with create! call" do + it "does not raise NoAccess" do + stubbing(Model) do |model| + Model.create! + end + end + end + end + + context "as invalid" do + context "with create call" do + it "does not raise NoAccess" do + stubbing(Model, :as => :invalid) do |model| + Model.create + end + end + end + context "with create! call" do + it "does not raise NoAccess" do + stubbing(Model, :as => :invalid) do |model| + begin + Model.create! + rescue ActiveRecord::RecordInvalid + end + end + end + end + end end spec/stubble/stubbing_spec.rb 261873a6c96d6118bc97edce1d2074ad37e51522 David Chelimsky dchelimsky@gmail.com http://github.com/dchelimsky/stubble/commit/135c64a8a449923aa399e1b251ae0acccfbba045 135c64a8a449923aa399e1b251ae0acccfbba045 2009-09-14T22:36:13-07:00 2009-09-14T22:36:13-07:00 stubble barks if never accessed f78555d503591c9cdccf53fd4fa20369adf165fe David Chelimsky dchelimsky@gmail.com