@@ -48,7 +48,13 @@ // Create the mime multipart boundary. // TODO scan `values` to ensure uniqueness of `boundary`. Loop+regen UUID if collision is discovered. - NSString *uuid = [(id)CFUUIDCreateString(kCFAllocatorDefault, CFUUIDCreate(kCFAllocatorDefault)) autorelease]; + CFUUIDRef cfUuid = CFUUIDCreate(kCFAllocatorDefault); + NSString * uuid = (id)CFUUIDCreateString(kCFAllocatorDefault, cfUuid); + CFRelease(cfUuid); +#if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_5 + uuid = NSMakeCollectable(uuid); +#endif + uuid = [uuid autorelease]; NSString *boundary = [NSString stringWithFormat:@"x-mime-boundary://%@", uuid]; //-- lib/NSURLRequest+postForm.m 15227df3de3128017fce7785853f88ba77792239 Dave Dribin dave@dribin.org http://github.com/ddribin/jrfeedbackprovider/commit/b1fb2b9c658f25f620f57f90d23aa29d2f9622a3 b1fb2b9c658f25f620f57f90d23aa29d2f9622a3 2009-05-25T12:10:46-07:00 2009-05-25T12:10:46-07:00 Fix leaked return of CFUUIDCreate() (reported by clang static analyzer). Also make GC dual-mode safe by calling NSMakeCollectable() on return of CFUUIDCreateString() 86fcc037a472c9df10401ca28d4749a5d0364267 Dave Dribin dave@dribin.org