Issues - defunkt/cache_fu

defunkt / cache_fu

282

Description:

Everyone's favorite memcached plugin for ActiveRecord.

Sort by: Priority | Votes | Last Updated

Loading…

1.

0 votes

Action caching broken
0 comments Created 2 months ago by bgreenlee

Title

Body
I spent a couple hours banging my head against the wall trying to figure out why our action caching wasn't working, until I came across this: http://www.neeraj.name/blog/articles/863-action-caching-in-broken-in-plugin-cache_fu I applied the suggested fix and it seems to work, although I'm not sure if it breaks anything else (tests don't pass for me even before the fix). (We're on Rails 2.2.2)
or cancel

I spent a couple hours banging my head against the wall trying to figure out why our action caching wasn't working, until I came across this: http://www.neeraj.name/blog/articles/863-action-caching-in-broken-in-plugin-cache_fu

I applied the suggested fix and it seems to work, although I'm not sure if it breaks anything else (tests don't pass for me even before the fix).

(We're on Rails 2.2.2)

Comments

Parsed with GitHub Flavored Markdown
2.

0 votes

avoid overriding the "cache_key" method for ActiveRecord::Base children
1 comment Created about 1 month ago by ktlacaelel

Title

Body
recent rails versions come with a nice cache_key method that concatenates class_name + id + timestamp this together with the ActiveRecord "touch" method would work great because cache expiration is automatic when the record gets updated. this method "cache_key" is being overwritten in the "cache_fu" plugin. <pre> lib/acts_as_cached/cache_methods.rb:265 </pre> <pre> 265 def cache_key 266 self.class.cache_key(cache_id) 267 end </pre> I was thinking that maybe something like this would do: <pre> return super if self.class.superclass.to_s == 'ActiveRecord::Base' self.class.cache_key(cache_id) </pre> So well, may be it needs a little bit more code and tests to be robust. but you sort of get the idea. I forked, and was thinking of making the changes but thought of confirming this Thanks for rip, cijoe, network-graphs?? and more!
or cancel
recent rails versions come with a nice cache_key method that concatenates

class_name + id + timestamp

this together with the ActiveRecord "touch" method would work great because
cache expiration is automatic when the record gets updated.

this method "cache_key" is being overwritten in the "cache_fu" plugin.
```
lib/acts_as_cached/cache_methods.rb:265
```
```
265     def cache_key
266       self.class.cache_key(cache_id)
267     end
```
I was thinking that maybe something like this would do:
```
return super if self.class.superclass.to_s == 'ActiveRecord::Base'
self.class.cache_key(cache_id)
```
So well, may be it needs a little bit more code and tests to be robust.
but you sort of get the idea.

I forked, and was thinking of making the changes but thought of confirming this

Thanks for rip, cijoe, network-graphs?? and more!
Comments
ktlacaelel Fri Oct 02 02:13:25 -0700 2009 | link
I spent a few more minutes on making it more robust

def should_override_cache_key? return true unless self.respond_to? :class return true unless self.class.respond_to? :superclass return true unless self.class.superclass.respond_to? :to_s return true unless self.class.superclass.to_s == 'ActiveRecord::Base' !self.class.respond_to? :cache_key end def cache_key should_override_cache_key? ? self.class.cache_key(cache_id) : super end
Comment
I spent a few more minutes on making it more robust <pre> def should_override_cache_key? return true unless self.respond_to? :class return true unless self.class.respond_to? :superclass return true unless self.class.superclass.respond_to? :to_s return true unless self.class.superclass.to_s == 'ActiveRecord::Base' !self.class.respond_to? :cache_key end def cache_key should_override_cache_key? ? self.class.cache_key(cache_id) : super end </pre>
or cancel
Parsed with GitHub Flavored Markdown
3.

0 votes

tests fail/ Rails site fails
1 comment Created 20 days ago by bradleyd

Title

Body
I cant seem to get cache_fu going. I inherited a site that had to be moved over locally and it keeps failing with this error: 1) Error: test_spec {When local_cache_for_request is called} 001 [get_cache should pull from the local cache on a second hit](When local_cache_for_request is called): NoMethodError: undefined method `[]' for #<Enumerable::Enumerator:0x7f3aa057cbf0> /usr/lib/ruby/gems/1.8/gems/activesupport-2.0.2/lib/active_support/core_ext/string/access.rb:43:in `first' ./lib/acts_as_cached/cache_methods.rb:184:in `cache_key' ./lib/acts_as_cached/local_cache.rb:7:in `fetch_cache' ./lib/acts_as_cached/cache_methods.rb:31:in `get_cache' ./lib/acts_as_cached/cache_methods.rb:230:in `get_cache' test/local_cache_test.rb:13:in `test_spec {When local_cache_for_request is called} 001 [get_cache should pull from the local cache on a second hit]' /usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:442:in `run' /usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:441:in `each' /usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:441:in `run' /usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:442:in `run' /usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:441:in `each' /usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:441:in `run' I am using: * memcache-client (1.7.5) * rails (2.0.2) * cache_fu verison?? Any help would be greatly appreciated.
or cancel
I cant seem to get cache_fu going. I inherited a site that had to be moved over locally and it keeps failing with this error:
1) Error: test_spec {When local_cache_for_request is called} 001 [get_cache should pull from the local cache on a second hit](When local_cache_for_request is called):
NoMethodError: undefined method `[]' for #<Enumerable::Enumerator:0x7f3aa057cbf0>
```
/usr/lib/ruby/gems/1.8/gems/activesupport-2.0.2/lib/active_support/core_ext/string/access.rb:43:in `first'
./lib/acts_as_cached/cache_methods.rb:184:in `cache_key'
./lib/acts_as_cached/local_cache.rb:7:in `fetch_cache'
./lib/acts_as_cached/cache_methods.rb:31:in `get_cache'
./lib/acts_as_cached/cache_methods.rb:230:in `get_cache'
test/local_cache_test.rb:13:in `test_spec {When local_cache_for_request is called} 001 [get_cache should pull from the local cache on a second hit]'
/usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:442:in `run'
/usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:441:in `each'
/usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:441:in `run'
/usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:442:in `run'
/usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:441:in `each'
/usr/lib/ruby/gems/1.8/gems/test-spec-0.3.0/lib/test/spec.rb:441:in `run'
```
I am using:
memcache-client (1.7.5) rails (2.0.2) * cache_fu verison??

Any help would be greatly appreciated.
Comments
bradleyd Wed Nov 11 13:53:51 -0800 2009 | link
i solved the issue. I will put this up for anyone who needs it.
Turned out that the site was written in a previous version of ruby. There is a string char method issue with rails < 2.2. So the easy fix was Copy this code to the environment.rb.

unless '1.9'.respond_to?(:force_encoding)

String.class_eval do begin remove_method :chars rescue NameError # OK end end

end

hope that helps.
Comment
i solved the issue. I will put this up for anyone who needs it. Turned out that the site was written in a previous version of ruby. There is a string char method issue with rails < 2.2. So the easy fix was Copy this code to the environment.rb. unless '1.9'.respond_to?(:force_encoding) String.class_eval do begin remove_method :chars rescue NameError # OK end end end hope that helps.
or cancel
Parsed with GitHub Flavored Markdown

Labels

Action caching broken

Comments

avoid overriding the "cache_key" method for ActiveRecord::Base children

Comments

tests fail/ Rails site fails

Comments