defunkt / facebox fork watch download tarball
public
Description: Facebook-style lightbox, built in jQuery
Homepage: http://famspam.com/facebox/
Clone URL: git://github.com/defunkt/facebox.git
Click here to lend your support to: facebox and make a donation at www.pledgie.com ! 
changed from replaceWith to replaceAll
replaceWith was causing crazy problems with the dom and removing the first 
child option tag from select boxes in facebox'd div
maddox (author)
Thu Jun 26 13:48:16 -0700 2008
commit  d307d7780736a3be62c68c64636d822ad3658090
tree    8973fa4d90cc16b439c4859abb287ace3f9531c1
parent  b24c1a8d6a2a460886efd6649494d7ae3aa0ac58
0
facebox.js 
...
256
257
258
259
 
260
261
262
 
...
256
257
258
 
259
260
261
262
 
0
@@ -256,7 +256,7 @@
0
     if (href.match(/#/)) {
0
       var url    = window.location.href.split('#')[0]
0
       var target = href.replace(url,'')
0
-      $.facebox.reveal($(target).show().replaceWith("<div id='facebox_moved'></div>"), klass)
0
+      $.facebox.reveal($(target).show().replaceAll("<div id='facebox_moved'></div>"), klass)
0
 
0
     // image
0
     } else if (href.match($.facebox.settings.imageTypesRegexp)) {

Comments

  • bryansray Thu Jul 24 22:40:37 -0700 2008

    This commit causes facebox to consume (remove) the existing div tag … therefore, only being able to display the facebox once. If you close the facebox and re-open it … you will have an empty box.

    (i apologize if this is the wrong place for this post)