defunkt / github-gem

The issue email that is sent out when an issue is added to a repository that you're watching has the "Read more..." link as this (example from #1 of this repo): http://github.com//defunkt/github-gem/issues/1/find whereas it should be: http://github.com/defunkt/github-gem/issues/#issues/1

$ github
/var/lib/gems/1.9.0/gems/defunkt-github-0.3.4/lib/github/extensions.rb:11: warning: undefining `object_id' may cause serious problem
/var/lib/gems/1.9.0/gems/defunkt-github-0.3.4/lib/github.rb:149:in `module_eval': /var/lib/gems/1.9.0/gems/defunkt-github-0.3.4/lib/commands/commands.rb:40: syntax error, unexpected ')' (SyntaxError)
  helper.tracking.sort { |(a,),(b,)| a == helper.origin ? -...
                              ^
/var/lib/gems/1.9.0/gems/defunkt-github-0.3.4/lib/commands/commands.rb:40: syntax error, unexpected '|', expecting '='
...per.tracking.sort { |(a,),(b,)| a == helper.origin ? -1 : b ...
...                               ^
/var/lib/gems/1.9.0/gems/defunkt-github-0.3.4/lib/commands/commands.rb:40: syntax error, unexpected '}', expecting keyword_end
...rigin ? 1 : a.to_s <=> b.to_s }.each do |(name,user_or_url)|
...                               ^
    from /var/lib/gems/1.9.0/gems/defunkt-github-0.3.4/lib/github.rb:149:in `load'
    from /var/lib/gems/1.9.0/gems/defunkt-github-0.3.4/lib/github.rb:66:in `block in activate'
    from /var/lib/gems/1.9.0/gems/defunkt-github-0.3.4/lib/github.rb:65:in `each'
    from /var/lib/gems/1.9.0/gems/defunkt-github-0.3.4/lib/github.rb:65:in `activate'
    from /var/lib/gems/1.9.0/gems/defunkt-github-0.3.4/bin/github:8:in `'
    from /var/lib/gems/1.9.0/bin/github:19:in `load'
    from /var/lib/gems/1.9.0/bin/github:19:in `'

Traceback looks like

/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open-uri.rb:174:in `open_loop': redirection forbidden: http://github.com/user/repo/network/members.json -> https://github.com/user/repo/network/members.json (RuntimeError)

from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open-uri.rb:132:in `open_uri'
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open-uri.rb:518:in `open'
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open-uri.rb:30:in `open'
from /Library/Ruby/Gems/1.8/gems/defunkt-github-0.3.4/lib/commands/helpers.rb:340:in `get_network_members'
from /Library/Ruby/Gems/1.8/gems/defunkt-github-0.3.4/lib/commands/network.rb:23:in `command'
from /Library/Ruby/Gems/1.8/gems/defunkt-github-0.3.4/bin/../lib/github/command.rb:25:in `send'
from /Library/Ruby/Gems/1.8/gems/defunkt-github-0.3.4/bin/../lib/github/command.rb:25:in `call'
from /Library/Ruby/Gems/1.8/gems/defunkt-github-0.3.4/bin/../lib/github.rb:74:in `invoke'
from /Library/Ruby/Gems/1.8/gems/defunkt-github-0.3.4/bin/../lib/github.rb:68:in `activate'
from /Library/Ruby/Gems/1.8/gems/defunkt-github-0.3.4/bin/github:8
from /usr/bin/github:19:in `load'
from /usr/bin/github:19

I didn't actually have an "origin" branch in this repo at first, so I added one that looks like

git remote show origin
* remote origin URL: git@github.com:user/repo.git HEAD branch: master ...

For your pulling pleasure

$ github network Error: remote 'origin' is not a github URL

origin url is:
Fetch URL: git+ssh://git@github.com/digi604/django-cms-2.0.git
Push URL: git+ssh://git@github.com/digi604/django-cms-2.0.git

It says to do gh fetch ... and gh merge ... but those are no longer available commands.

I suspect you have lumped them under the gh pull ... command instead. I would do a fork + pull but I'm a bit uncertain I've fully understood this stuff as I'm brand newbie to it.

wfarr@lawn-143-215-98-135:~/Code/github-gem$ bin/github network commits
gathering heads

=========================================================================================
These are all the commits that other people have pushed that you have not
applied or ignored yet (see 'github ignore'). Some things you might want to do:

* You can run 'github fetch user/branch' (sans '~N') to pull into a local branch for testing
* You can run 'github cherry-pick [SHA]' to apply a single patch
* You can run 'github merge user/branch' to merge a commit and all the '~N' variants.
* You can ignore all commits from a branch with 'github ignore ..user/branch'
=========================================================================================

using cached...
c325c9 (tekkub/master)           tekkub@gmail.com      Bugger, how did that get in there      2 weeks ago 
52a098 (tekkub/master~1)         tekkub@gmail.com      Add upload command                     2 weeks ago 
ce9544 (vertis/master)           vertis@coreguardian.  removed curl and replaced with net     http 
cbc00b (msadouni/master)         matthieusadouni@gmai  Fix 'operation not supported git che   E045)' on OSX 
474067 (jgdavey/master)          josh@joshuadavey.com  Adding specs and fixing typo (bug) f   2 days ago 
c628a8 (nex3/master)             nex342@gmail.com      Be noisy when GitHub                   Command#sh has  

As you can see in the case of nex3, msadouni, and vertis's commit messages, when the commit message contains '::', it breaks the parsing and doesn't show the date in the appropriate spot.

This applies to v0.4.0.

Although the command seems to work, the key ingredient (the curl command to actually create the repo on github) has a typo.

I've forked and fixed this, adding a slight bit more verbose output as well, following the pattern that Dr. Nic started in his recent enhancements.

It seems that the GitHub gem needs the json gem to work properly, as I had some issues when I installed it yesterday:

/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems      /custom_require.rb:31:in `gem_original_require': no such file to load -- json (LoadError)
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in `require'
from /Library/Ruby/Gems/1.8/gems/github-0.4.0/bin/../lib/github.rb:9
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in `require'
from /Library/Ruby/Gems/1.8/gems/github-0.4.0/bin/github:6
from /usr/bin/github:19:in `load'
from /usr/bin/github:19

The github gem should depend on the json gem, so that gem install github will install it.

I installed the github gem, but when I ran gh, I got this:

/Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require': no such file to load -- json (LoadError)
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require'
    from /usr/local/Cellar/Gems/1.8/gems/github-0.4.0/bin/../lib/github.rb:9
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require'
    from /usr/local/Cellar/Gems/1.8/gems/github-0.4.0/bin/gh:6
    from /usr/local/bin/gh:19:in `load'
    from /usr/local/bin/gh:19

I've never been able to get the 'gh create' calls to work. I tried all sorts of combinations and trying to specify the repo in different ways. Nada. So I decided to write up an issue...then I decided I'd better just look at the source. And there is, some mysterious github token! I didn't have one. So I googled and discovered that I do have one and I need to set that in my global git config.

Could you please add a line saying that you need to do this step to the install?! Unless I'm missing something how would any normal person know to do this?

Cheers,
Karl

PS A check that the token isn't empty would be good in the 'create' calls..or wherever it's needed. Perhaps that would even be enough.
'You haven't configured your GitHub API key! Please go to http://github.com/[github_user] and blah...'