@@ -1,3 +1,7 @@ +Version 0.4.2.3, 31.01.2009 +- introduced Workling.raises_exceptions. by default, this is true in test and development to help with bug tracking. +- added :threaded as the default spawn runner for test and development. helps problem tracing. + Version 0.4.2.2, 29.11.08 - turned Workling.load_path into an Array. CHANGES.markdown @@ -21,7 +21,7 @@ module Workling mattr_accessor :load_path @@load_path = [ File.expand_path(File.join(File.dirname(__FILE__), '../../../../app/workers')) ] - VERSION = "0.4.2.2" + VERSION = "0.4.2.3" # # determine the runner to use if nothing is specifically set. workling will try to detect @@ -132,6 +132,17 @@ module Workling end end + # + # Raises exceptions thrown inside of the worker. normally, these are logged to + # logger.error. it's easy to miss these log calls while developing, though. + # + mattr_accessor :raise_exceptions + @@raise_exceptions = (RAILS_ENV = "test" || RAILS_ENV = "development") + + def self.raise_exceptions? + @@raise_exceptions + end + private def self.raise_not_found(clazz, method) raise Workling::WorklingNotFoundError.new("could not find #{ clazz }:#{ method } workling. ") lib/workling.rb @@ -39,7 +39,7 @@ module Workling begin self.send(method, options) rescue Exception => e - raise e if e.kind_of? Workling::WorklingError + raise e if e.kind_of?(Workling::WorklingError) || Workling.raise_exceptions? logger.error "WORKLING ERROR: runner could not invoke #{ self.class }:#{ method } with #{ options.inspect }. error was: #{ e.inspect }\n #{ e.backtrace.join("\n") }" end end lib/workling/base.rb @@ -19,7 +19,9 @@ module Workling module Runners class SpawnRunner < Workling::Remote::Runners::Base cattr_accessor :options - @@options = { :method => :fork } + + # use thread for development and test modes. easier to hunt down exceptions that way. + @@options = { :method => (RAILS_ENV == "test" || RAILS_ENV == "development" ? :thread :fork) } include Spawn if Workling.spawn_installed? # dispatches to Spawn, using the :fork option. lib/workling/remote/runners/spawn_runner.rb @@ -42,4 +42,7 @@ require "runners/thread_runner" # worklings are in here. Workling.load_path = ["#{ plugin_root }/test/workers"] Workling::Return::Store.instance = Workling::Return::Store::MemoryReturnStore.new -Workling::Discovery.discover! \ No newline at end of file +Workling::Discovery.discover! + +# make this behave like production code +Workling.raise_exceptions = false \ No newline at end of file test/test_helper.rb cfb7055f11e8bbbf97615a868b7885a966989184 Rany Keddo rany@playtype.net http://github.com/digitalhobbit/workling/commit/5b62559387aefb5c7f33a78e7207ef665c693c58 5b62559387aefb5c7f33a78e7207ef665c693c58 2009-01-31T08:46:46-08:00 2009-01-31T08:46:46-08:00 workling now throws errors in test and development. this helps for problem analysis c16a4b9bdc224634047949121f8d90a0c63f1c37 Rany Keddo rany@playtype.net