From ebfe1b605c840700c8b8f74adf8814624f6ad664 Mon Sep 17 00:00:00 2001 From: "Dustin J. Mitchell" Date: Sun, 28 Mar 2010 16:48:01 -0500 Subject: [PATCH] (fixes #713) make triggering a stopped Loop a warnable offence --- buildbot/util/loop.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/buildbot/util/loop.py b/buildbot/util/loop.py index 572604a2105..95e9db589db 100644 --- a/buildbot/util/loop.py +++ b/buildbot/util/loop.py @@ -116,7 +116,11 @@ def when_quiet(self): return d def trigger(self): - assert self.running + # if we're triggered while not running, ignore it. We'll automatically + # trigger when the service starts + if not self.running: + print "loop triggered while service disabled; ignoring trigger" + return self._mark_runnable(run_everything=True) def _mark_runnable(self, run_everything):