@@ -863,22 +863,23 @@ void ChatService::decodeBuddyListResponse( QIODevice *responseInput ) bool idle = nowAvailableList.value(userId).toMap()["i"].toBool(); if ( _buddyInfos.contains(userId) ) { + // if the user id is already there with the same idle status, don't emit // anything - qDebug() << "checking status for " << userId; + qDebug() << "checking status for" << userId << "(" << _buddyInfos.value(userId).name() << ")"; if ( _availableBuddies.contains(userId) && ( _availableBuddies.value(userId) == idle ) ) continue; bool firstTime = !_availableBuddies.contains(userId); - qDebug() << userId << " status changed to " << idle; + qDebug() << userId << "(" << _buddyInfos.value(userId).name() << ")"<< "is" << ( idle ? "" : "not " ) << "idle"; _availableBuddies[userId] = idle; /* On first appearing, a buddy should be assumed to be online. (otherwise he's not added to the list; code wasn't well thought-out) */ - if (firstTime) - emit buddyAvailable(_buddyInfos.value(userId), true); + if (firstTime && idle) + emit buddyAvailable(_buddyInfos.value(userId), false); emit buddyAvailable(_buddyInfos.value(userId), idle); } else facebook/chatservice.cpp @@ -280,11 +280,11 @@ void FacebookAccount::slotBuddyAvailable( const Facebook::BuddyInfo &buddy, boo // server -> local if ( !contact( buddy.buddyId() ) ) { - kDebug(FBDBG) << "Contact " << buddy.buddyId() << " is not in the contact list. Ugh!"; + kDebug(FBDBG) << "Buddy " << buddy.buddyId() << "(" << buddy.name() << ")"<< " is not in the contact list. Ugh!"; return; } - qDebug() << "Contact " << buddy.buddyId() << " available"; + qDebug() << "Buddy " << buddy.buddyId() << "(" << buddy.name() << ")" << " available, " << ( idle ? "" : "not" ) << "idle"; contact( buddy.buddyId() )->setOnlineStatus( idle ? FacebookProtocol::protocol()->facebookAway : FacebookProtocol::protocol()->facebookOnline ); } @@ -293,7 +293,7 @@ void FacebookAccount::slotBuddyNotAvailable( const Facebook::BuddyInfo &buddy ) // server -> local if ( !contact( buddy.buddyId() ) ) { - kDebug(FBDBG) << "Contact " << buddy.buddyId() << " is not in the contact list. Ugh!"; + kDebug(FBDBG) << "Buddy " << buddy.buddyId() << " is not in the contact list. Ugh!"; return; } contact( buddy.buddyId() )->setOnlineStatus( FacebookProtocol::protocol()->facebookOffline ); @@ -304,7 +304,7 @@ void FacebookAccount::slotBuddyInformation( const Facebook::BuddyInfo &buddy ) // server -> local if ( !contact( buddy.buddyId() ) ) { - kDebug(FBDBG) << "Contact " << buddy.buddyId() << " is not in the contact list. Adding..."; + kDebug(FBDBG) << "Buddy " << buddy.buddyId() << "(" << buddy.name() << ")" << "is not in the contact list. Adding..."; Kopete::Group *g = Kopete::ContactList::self()->findGroup("Facebook"); addContact(buddy.buddyId(), buddy.name().isEmpty() ? buddy.buddyId() : buddy.name() , g, Kopete::Account::ChangeKABC); contact( buddy.buddyId() )->setOnlineStatus( FacebookProtocol::protocol()->facebookOffline ); facebookaccount.cpp f4822b90b7613f6e5ba8acceae25ec300b79143f Duncan Mac-Vicar P duncan@kde.org http://github.com/dmacvicar/kopete-facebook/commit/8aa3ae1328e178b42bae9d61eb6b10e37bd6c2e8 8aa3ae1328e178b42bae9d61eb6b10e37bd6c2e8 2009-08-04T14:13:09-07:00 2009-08-04T14:13:09-07:00 improve debug messages. first appareance parameter is wrong. true means idle. shot myself in the foot by using boolean parameters even if I hate them. fccfa0c9917b10d25a351c9fdea8933ca3fbf8b2 Duncan Mac-Vicar P duncan@kde.org