This repository has been archived by the owner on Nov 15, 2019. It is now read-only.
Fix for DC-797 #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't consider a change from null to Doctrine_Null to be a value modification
Setting Translation properties doesn't seem to mark a record as modified. So, this test case previously marked the Place as TDIRTY, so that it would be saved. However, this test case didn't set the Sura to TDIRTY. Now that DC-797 is fixed, and the Sura is no longer marked as TDIRTY by setting a related Place, the state must be set on both the Sura and the Place.
|
The failing test turns out to be an interesting case where it looks like the user is required to set the state of the record to dirty themselves before calling save(). And they do on one of the records in the test, but not the other. So one of the records isn't saved, now that the record isn't dirty to start with. I've fixed that test, and also added another to test the bug these changes fix. |
Currently, count(new Doctrine_Null()) returns 1. This means Doctrine_Hydrator_RecordDriver::setLastElement() will try to call getLast() on instances of Doctrine_Null and fail. Compare this to count(null), which gives 0: if Doctrine_Null is to represent null it should give the same count.
|
Going to do this on a topic branch. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Record's _isValueModified method was considering a change from null to Doctrine_Null as a modification. But the hydrator sets null fields to Doctrine_Null on objects that have an empty one-to-one relation. The end result was records being hydrated as dirty, before any modifications by the user.
More details, and a test case, in the bug report.