@@ -60,7 +60,7 @@ module Roby pp.text "no candidate for #{method_name}(#{method_options})" else first, *rem = Roby.filter_backtrace(backtrace) - pp.text "#{first}: cannot develop a #{method_name}(#{method_options.to_s[1..-2]}) method" + pp.text "cannot develop a #{method_name}(#{method_options.to_s[1..-2]}) method" pp.breakable pp.group(4, " ") do rem.each do |line| @@ -71,15 +71,22 @@ module Roby pp.breakable errors.each do |m, error| - first, *rem = *Roby.filter_backtrace(error.backtrace) - pp.text "#{first}: planning method #{m} failed" - pp.breakable - pp.text "#{first}: #{error.message}" - pp.breakable - pp.group(4, " ") do - rem.each do |line| - pp.text "from #{line}" - pp.breakable + if error.kind_of?(NotFound) + first, *rem = *Roby.filter_backtrace(error.backtrace) + pp.text "in method #{m}" + pp.breakable + error.pretty_print(pp) + else + first, *rem = *Roby.filter_backtrace(error.backtrace) + pp.text "planning method #{m} failed" + pp.breakable + pp.text "#{first}: #{error.message}" + pp.breakable + pp.group(4, " ") do + rem.each do |line| + pp.text "from #{line}" + pp.breakable + end end end end @@ -795,7 +802,7 @@ module Roby rescue NotFound => e e.method_name = name e.method_options = options - raise e + raise e.dup, e.message, caller(1) end def find_reusable_task(return_type, method_options) lib/roby/planning/model.rb a0e03f484c3feda2dde768341ac10b5c813f080f Sylvain Joyeux sylvain.joyeux@m4x.org http://github.com/doudou/roby/commit/713774aa8ae0bbb1172a868915adffc4382b5463 713774aa8ae0bbb1172a868915adffc4382b5463 2009-07-04T01:08:35-07:00 2009-06-27T09:12:49-07:00 core: improve error display for planning errors First, this commit fixes an issue where planning errors where not shown in case of recursive planning method calls. Moreover, it improves the layout of NotFound pretty-printing 357ac87850f4b3a2776cc7c43dfef75295f6ce4b Sylvain Joyeux sylvain.joyeux@m4x.org