dpp / liftweb

Current maven-scala-plugin configuration supports mixed Scala/Java project. The intention is to allow having higher flexibility.

However, Mixed Scala/Java project configuration is useful only when there are classes generated from java source has compile time dependency on classes generated from scala source. Lift doesn't have use case for such scenario currently.

There are some disadvantages of such configuration as well:

• it requires 2 compilation step => longer to compile
• it is not compatible with IDE (e.g., Eclipse likes to have the source directory define via the build.sourceDirectory)
• the build life cycle end up being a hacked one
• it has side effects on other plugins (e.g., maven-source-plugin expects sources via build.sourceDirectory by default)

When the field is NULL (which happens to be the defaultValue for MappedDateTime)

Message: java.lang.NullPointerException

net.liftweb.mapper.MappedDateTime.asJsonValue(MappedDateTime.scala:49)
com.foursquare.model.Venue$mayor_updated$.asJsonValue(Venue.scala:50001)
net.liftweb.mapper.BaseMappedField$class.asJsonField(MappedField.scala:92)
net.liftweb.mapper.MappedDateTime.asJsonField(MappedDateTime.scala:34)
com.foursquare.model.Venue$mayor_updated$.asJsonField(Venue.scala:50001)
net.liftweb.mapper.MetaMapper$$anonfun$encodeAsJSON_$bang$1$$anonfun$apply$14.apply(MetaMapper.scala:571)
net.liftweb.mapper.MetaMapper$$anonfun$encodeAsJSON_$bang$1$$anonfun$apply$14.apply(MetaMapper.scala:571)
scala.List.map(List.scala:812)
net.liftweb.mapper.MetaMapper$$anonfun$encodeAsJSON_$bang$1.apply(MetaMapper.scala:571)
net.liftweb.mapper.MetaMapper$$anonfun$encodeAsJSON_$bang$1.apply(MetaMapper.scala:568)

Flot.render() tries to put code into the head of the XHTML document, which is problematic when using Flot within a CometActor.

See http://github.com/pr1001/lift-comet-initialization-example.>

I ran into an issue where Jetty failed to restart because of Derby connection remaining active. I started a discussion on the mailing list (http://groups.google.com/group/liftweb/browse_thread/thread/78454f767280b4b5) to confirm it was an issue and wanted to create an issue along with potential fix.

Sorry I'm a bit new to Git Hub (and Git.. and Lift for that matter). I'm not sure how to submit a patch exactly but the fix is to move the Derby dependency inside of Jetty so that Jetty manages the Derby instance. This not only allows Derby to restart by also maintains database independence from the application. It is also a good idea to remove the Derby dependency or from the project dependencies or at least change to provided.

The resulting jetty configuration should look like this:

            <groupId>org.mortbay.jetty</groupId>
            <artifactId>maven-jetty-plugin</artifactId>
            <configuration>
                <contextPath>/</contextPath>
                <scanIntervalSeconds>5</scanIntervalSeconds>
            </configuration>
            <dependencies>
                <dependency>
                    <groupId>org.apache.derby</groupId>
                    <artifactId>derby</artifactId>
                    <version>10.4.2.0</version>
                </dependency>
            </dependencies>
        </plugin>

The source jars uploaded to the maven snapshot repository for lift-webkit-1.1-SNAPSHOT have no scala sources, they only have resources.

Lists work in lift-textile only if there is an empty line preceding it, but this is a deviation from the reference implementation http://textism.com/tools/textile/index.php .

Here's an example:

These are list items:
* Item 1
* Item 2

incorrectly yields:

<p>These are list items:<br></br>* Item 1<br></br>* Item 2</p>

Stateful rewrite will never be called during stateless rewrite

Stateful rewrite will not be called with Req.nil instance

Add a way of executing a function after the commit phase in mapper

All a component in Wizard to upload files

Per the HTTP spec

In this case, <!DOCTYPE ... > is on the first line and <?xml ..> on the second. This violates XML specification, <?xml ...> must be at the first line of a document.

Apparently, this doesn't cause problems with IE itself. But when using other browsers (Opera, FF) set up to mask as IE, the page fails to load and the browsers displays an error.

How to reproduce:

• load the hello-world project using

   mvn archetype:generate -U   -DarchetypeGroupId=net.liftweb   -DarchetypeArtifactId=lift-archetype-blank   -DarchetypeVersion=1.0   -DremoteRepositories=http://scala-tools.org/repo-releases   -DgroupId=demo.helloworld   -DartifactId=helloworld   -Dversion=1.0-SNAPSHOT
  

• set lift version to 1.1-M7 in pom.xml
• run the application by

   mvn jetty:run
  

• view the generated HTML page by calling (on Linux):

   wget -q -O- --user-agent='Mozilla/4.0 (compatible; MSIE 6.0; X11; Linux i686; en) Opera 10.10' 'http://localhost:8080/?' | head
  

• The page will have swapped <?xml ...> and <!DOCTYPE ...>.

Add more logic and upper bounds on connection pool stuff and maybe even some sort of exception thing

Example: id is an INTEGER, tco is a DECIMAL, the table is empty:

scala> DB.runQuery("SELECT SUM(id) FROM contracts")
res9: (List[String], List[List[String]]) = (List(sum),List(List(0)))

scala> DB.runQuery("SELECT SUM(tco) FROM contracts")
java.lang.NullPointerException
at net.liftweb.mapper.DB$.net$liftweb$mapper$DB$$asString(DB.scala:265)
at net.liftweb.mapper.DB$$anonfun$resultSetTo$1.apply(DB.scala:287)
at net.liftweb.mapper.DB$$anonfun$resultSetTo$1.apply(DB.scala:287)
at scala.List.map(List.scala:812)
at net.liftweb.mapper.DB$.resultSetTo(DB.scala:287)
at net.liftweb.mapper.DB$$anonfun$runQuery$2$$anonfun$ap...

It bases generated key fetches on the dbPrimaryKey? property instead of dbAutogenerated?

Ensure build plugin and report plugin configuration are set up explicitly. Since report plugin configuration doesn't apply to build plugin [1] although it should.

Further, in Maven 3, plugin configuration in the section no longer affects plugins in the section of the POM [2].

[1] http://groups.google.com/group/liftweb/browse_thread/thread/36b4450ec7acb7c9/e26b9f1e460b69d0 [2] http://cwiki.apache.org/MAVEN/maven-3x-compatibility-notes.html#Maven3.xCompatibilityNotes-SiteandReporting

http://groups.google.com/group/liftweb/browse_thread/thread/2f78c7bf9dcd8c79

Alex Black needs the ability to not emit an attribute conditionally at an attribute binding location.

Giving null use to suppress the attribute, but that has since stopped working, and it's using null besides.

Major ones in the list:

• maven-scala-plugin 2.3.1
• maven-changes-plugin 2.3
• maven-jar-plugin 2.3

Among other things take care of:

• Get rid of the Warning message: PT Don't override file .../pom.xml during archetype:generate
• Remove ext.vm parsing and set up velocity-macro variables to do the needful
• Enable setting lift version during archetype:generate
• Remove unnecessary dependencies from the generated archetypes
• Streamline maven-scala-plugin settings

Documentation and/or code examples of the added features/commands added to 1.1

If the connection pool is too small and the connection is acquired during a synchronized block, there can be resource starvation/deadlock

There are a number of places in AnyVar where the instance is synchronized. This locking is too coarse grained and can lead to deadlocks.

only one value is being send to the server

It appears S.render was unintentionally commented out and then removed. Can you please insert it back.

When I use ModalDialog I want to setup the css but fail,
My code would be:
ModalDialog(someHtml, "top: '10px'")

I found the ModalDialog code at Lift:
class ModalDialog(html: NodeSeq, css: Box[String]) extends JsCmd {

val toJsCmd = "jQuery.blockUI({ message: " + AltXML.toXML(Group(S.session.map(s =>
        s.fixHtml(s.processSurroundAndInclude("Modal Dialog", html))).openOr(html)), false, true, S.ieMode).encJs +
        (css.map(w => ",  css: '" + w + "' ").openOr("")) + "});"

}

the css is wrap by " ' ' " ,
but I found http://malsup.com/jquery/block/#demos
the css is wraped by "{ }"

Currently Lift's splits the suffix of an URI based on predefined rules and an significant list of known suffixes. Although this is sufficient in most cases it is not very flexible mechanism.

This is why allowing users to specify their own splitting rule though LiftRules would allow such flexibility.

Br's,
Marius

 scala> parse("\"foobar\"")
 net.liftweb.json.JsonParser$ParseException: unexpected null
 Near: "foobar
    at net.liftweb.json.JsonParser$Parser.fail(JsonParser.scala:166)
    at net.liftweb.json.JsonParser$ValStack.peek(JsonParser.scala:153)
    at net.liftweb.json.JsonParser$.newValue$1(JsonParser.scala:110)
    at net.liftweb.json.JsonParser$.parse0(JsonParser.scala:125)
    at net.liftweb.json.JsonParser$.parse(JsonParser.s...

Joni says:

Hi,

This is from JSON RFC (http://www.ietf.org/rfc/rfc4627.txt): "A JSON
text is a serialized object or array."

I checked with another parser (http://www.jsonlint.com) and it fails
too when given just JSON value:
"syntax error, unexpected TNUMBER, expecting '{' or '[' at line 1"

So perhaps a better error message is a proper fix here?

Cheers Joni

http://groups.google.com/group/liftweb/browse_thread/thread/6db3cded182fe7ca

If, for example, I have some json:

{ "user": {

"id": 12,
"name": "Harry",
"age": 31,

} }

I should be able to construct a User Mapper object such that I can then do:

val user = // build user object from json
user.age(32).save

and have the data be correctly saved back to the DB.

Hi,

Using the default MegaProtoUser trait for my User class, the following query fails on oracle but works just fine on H2:

    scala> User.findAll(By(User.superUser, false))
    java.sql.SQLException: Invalid column type
    at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:112)
    at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:146)
    at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:208)
    at oracle.jdbc.driver.OraclePreparedStatement.setObjectCritical(OraclePreparedStatement.java:9168)
    at ora...

Surprisingly however, the following statement works as it should:

    scala> User.findAll.head.superUser
    res22: object com.mi.ahl.hal.ooh.model.User#superUser = true

Is there a quick fix for this issue?

Regards, Mathias

This appears to be due to a change I made for issue 99. Turns out that I should be logging in runPreparedStatement, not exec.

http://groups.google.com/group/liftweb/browse_thread/thread/e189fc4a2726a94f

Functions created during an API request are discarded rather than merged into the Session's list of functions.

Put the determination of how to add the <? xml ?> stuff into LiftRules.

if a Ajax functions throws exceptions these are not provided to LiftRules.exceptionHander.

Br's,
Marius

to match editMenuLocParams, viewMenuLocParams, etc.

original message from the list:

Subject:    [Lift] Feature Request: deleteMenuLocParams in CRUDify
From:   tommycli <tommycli@ucla.edu>
Date:   November 23, 2009 11:50:09 PM EST
To:     Lift <liftweb@googlegroups.com>
Reply-To:   liftweb@googlegroups.com

Add deleteMenuLocParams to CRUDify.

Patch below. (I tried github, but you guys don't pull apparently).

If you use S.? or S.??, etc when not in a valid S scope (e.g. during boot time) you get an NPE from the bowels of S.?! instead of useful exception text.

Lift (and possibly Maven Scala plugin) is done best with Maven version > 2.1.x and < 3.x. Enforce that in the project model.

Probably due to Loc refactoring this functionality was accidentally removed.

Br's,
Marius

def checkbox[T](possible : Seq[T], actual : Seq[T], func : (Seq[T]) => Any, attrs : (String, String)*)

Func will only return first element in possible when it is checked or List().

From Paul O'Rorke:

since rebuilding a day or two ago with no recent code or other changes: every second time I go to click on an ajax checkbox or select widget, I get effectively no response. actually, it looks like there is a very quick spinning wheel (almost imperceptible) but the page doesn't get repainted and the database does not change.

If I use another operation that is non ajax (going in and editing an item and doing old fashioned get / posts) everything works fine after that (one time).
Or if I reload the page then if I use an ajax widget after reloading ajax works (once).

My experience of the bug:

1) load a page where the snippets are managed by a StatefulSnippet
2) some page elements (in my case select boxes) have their values update by AJAX in response to user events. This appears to work normally.
3) upon submission of the form on the page, the page is re-rendered. Logging in the submission function indicates that it is never called.
4) if I fill in the form again and resubmit after the initial failure, the form submit behaves properly.
5) I believe I've seen at least one instance (though I can't reliably reproduce this) where just a normal AJAX call (modifying one of the select boxes) caused the entire page to reload.

Within the session scope. This is the phase that should be used by CRUDify.

That returns a Box[String]

Currently, one can specify the way a Var is precalculated, but they should also support a flag for testing if the current value has been set/calculated and also support a by-name method for calculating the value if it hasn't been calculated.

Currently, the java.util.concurrent package will create a lot of threads for Actor handling. This can lead to thousands of unused threads.

Lift Actors should have a limit for the number of threads created and also support harvesting threads in the thread pool

Run lift-examples/example from SNAPSHOT (11/5) on a local server, autocompletion isn't happening on the AJAX Samples page. The rest of the Ajax stuff seems to work fine.

When running asynchronously say from a different actor the state capture when the fork happens does not capture HTTP parameters for example. This is quite useful snapshot information to have when doing parallel processing.

Br's,
Marius

I think I might have found a lift bug in the <lift:form> tag

I just did a update for ESME and certain HTML buttons (for example, "Add" in
creating a new action, etc.) no longer work. A javascript syntax error
is thrown.

The file in question is
\trunk\server\src\main\webapp\action_view\index.html. The code is here:

<lift:form> <lift:main>

This is code currently generated and which causes the syntax error.
onsubmit="liftAjax.lift_ajaxHandler(jQuery('#'+"F1008082309036RKD").serialize(),
, null, "javascript");return false;">

This older generated code is currently deployed on stax are works correctly.

onsubmit="liftAjax.lift_ajaxHandler(jQuery('#'+"F444961682037I0I").serialize(),
null, null, null);return false;">

Notice the difference in the onsubmit value.

D.

Comments

189.

0 votes

dpp

x

Lift not parsing query params under some circumstances

1 comment Created about 1 month ago by harryh

Title

Body
http://groups.google.com/group/liftweb/browse_thread/thread/592acaddac546b81
or cancel

http://groups.google.com/group/liftweb/browse_thread/thread/592acaddac546b81

Comments

dpp Tue Nov 17 06:19:07 -0800 2009 | link

The Query Params are always parsed now.

Comment
The Query Params are always parsed now.
or cancel

Parsed with GitHub Flavored Markdown

188.

0 votes

dpp

x

Emit warning if SessionVars are used with no Lift session

1 comment Created about 1 month ago by jeppenejsum

Title

Body
It is possible to set/get SessionVars even when there is no Lift session active. It would be nice to get some warnings logged in these cases. More details here: http://groups.google.com/group/liftweb/browse_thread/thread/efb58c2bd56556ef
or cancel

It is possible to set/get SessionVars even when there is no Lift session active. It would be nice to get some warnings logged in these cases.

More details here: http://groups.google.com/group/liftweb/browse_thread/thread/efb58c2bd56556ef

Comments

dpp Tue Nov 17 06:18:47 -0800 2009 | link

It's now optional. If it's the default, a fair number of Lift-related SessionVars show the warning on get during the rewrite phase (stuff in MegaProtoUser)

Comment
It's now optional. If it's the default, a fair number of Lift-related SessionVars show the warning on get during the rewrite phase (stuff in MegaProtoUser)
or cancel

Parsed with GitHub Flavored Markdown

187.

1 vote

Automated tests for examples

2 comments Created about 1 month ago by vvilhonen

Title

Body
Examples seem to broke now and then and it would be beneficial for the reader of the examples to see how lift applications can be tested automatically.
or cancel

Examples seem to broke now and then and it would be beneficial for the reader of the examples to see how lift applications can be tested automatically.

Comments

dpp Mon Nov 16 11:35:08 -0800 2009 | link

I don't think this a default. We need something specific (after discussion on the Lift list) to implement before it gets to an open ticket.

Comment
I don't think this a default. We need something specific (after discussion on the Lift list) to implement before it gets to an open ticket.
or cancel

vvilhonen Mon Nov 16 11:36:53 -0800 2009 | link

ok

Comment
ok
or cancel

Parsed with GitHub Flavored Markdown

186.

0 votes

Ability to manually create Lift session during rewrite

1 comment Created about 1 month ago by jeppenejsum

Title

Body
Normally, the Lift session is not created in the rewrite phase. It could be useful to manually force a lift session to be created. More details here: http://groups.google.com/group/liftweb/browse_thread/thread/efb58c2bd56556ef
or cancel

Normally, the Lift session is not created in the rewrite phase. It could be useful to manually force a lift session to be created.

More details here: http://groups.google.com/group/liftweb/browse_thread/thread/efb58c2bd56556ef

Comments

dpp Wed Dec 02 03:34:48 -0800 2009 | link

Similar to 197. I'm closing this one.

Comment
Similar to 197. I'm closing this one.
or cancel

Parsed with GitHub Flavored Markdown

185.

0 votes

dpp

x

MappedDouble should be able to be set from a Box

1 comment Created about 1 month ago by harryh

Title

Body
It can be set from an Option, it should be able to recognize a Box in the same way as, for example, MappedInt can.
or cancel

It can be set from an Option, it should be able to recognize a Box in the same way as, for example, MappedInt can.

Comments

dpp Tue Nov 17 06:17:50 -0800 2009 | link

Done.

Comment
Done.
or cancel

Parsed with GitHub Flavored Markdown

184.

0 votes

nuttycom

x

RequestVarEM is broken with JTA in AJAX requests due to RequestVar persistence.

0 comments Created about 1 month ago by nuttycom

Title

Body
RequestVarEM needs to use TransientRequestVar instead of RequestVar so that a new transaction is initiated on each HTTP request since transactions are scoped to the actual HTTP request by the container.
or cancel

RequestVarEM needs to use TransientRequestVar instead of RequestVar so that a new transaction is initiated on each HTTP request since transactions are scoped to the actual HTTP request by the container.

Comments

Parsed with GitHub Flavored Markdown

183.

0 votes

indrajitr

x

move changes:changes-validate to verify phase

1 comment Created about 1 month ago by indrajitr

Title

Body
changes:changes-validate can be invoked in verify phase instead of waiting till pre-site phase. Committers updating chages.xml can intercept (and fix) validation issue during the regular "mvn install" workflow.
or cancel

changes:changes-validate can be invoked in verify phase instead of waiting till pre-site phase.
Committers updating chages.xml can intercept (and fix) validation issue during the regular "mvn install" workflow.

Comments

indrajitr Fri Nov 13 18:06:38 -0800 2009 | link

changes:changes-validate invoked during "verify" phase. Closed by 9f0f04d.

Comment
changes:changes-validate invoked during "verify" phase. Closed by 9f0f04d5ab474f2352d8627106f16b2d74e32cc7.
or cancel

Parsed with GitHub Flavored Markdown

182.

0 votes

dpp

x

MetaMegaProtoUser should provide a "menus" alias for "sitemap"

1 comment Created about 1 month ago by dchenbecker

Title

Body
Just to be consistent with other menu-generating traits in Mapper (e.g. CRUDify)
or cancel

Just to be consistent with other menu-generating traits in Mapper (e.g. CRUDify)

Comments

dpp Tue Nov 17 06:17:39 -0800 2009 | link

Done.

Comment
Done.
or cancel

Parsed with GitHub Flavored Markdown

181.

0 votes

derekchenbecker

x

Add ajaxEditable method to SHtml

1 comment Created about 1 month ago by dchenbecker

Title

Body
Per http://groups.google.com/group/liftweb/browse_thread/thread/7970997492e238c0/fa8a3635eba7575f?lnk=gst&q=ajaxeditable#fa8a3635eba7575f
or cancel

Per http://groups.google.com/group/liftweb/browse_thread/thread/7970997492e238c0/fa8a3635eba7575f?lnk=gst&q=ajaxeditable#fa8a3635eba7575f

Comments

dchenbecker Fri Nov 13 15:30:18 -0800 2009 | link

Added AJAX editing to SHtml and Mapper

Closed by a371fb6

Comment
Added AJAX editing to SHtml and Mapper Closed by a371fb69cfa347d9c07ced5583a1ba1385138686
or cancel

Parsed with GitHub Flavored Markdown

180.

0 votes

indrajitr

x

cleanup vscaladoc settings

1 comment Created about 1 month ago by indrajitr

Title

Body
Most packages don't have the right baseUri for scaladoc. They need to be set up on a per package basis via packageLinkDefs system property as expected by vscaladoc.
or cancel

Most packages don't have the right baseUri for scaladoc. They need to be set up on a per package basis via packageLinkDefs system property as expected by vscaladoc.

Comments

indrajitr Fri Nov 13 14:27:12 -0800 2009 | link

Resolution pushed to master.

Comment
Resolution pushed to master.
or cancel

Parsed with GitHub Flavored Markdown

179.

0 votes

dpp

x

MappedString.valUnique should return one FieldError

1 comment Created about 1 month ago by hoffrocket

Title

Body
Currently valUnique maps each match it found to a FieldError, but should probably return one FieldError regardless of how many matches it finds.
or cancel

Currently valUnique maps each match it found to a FieldError, but
should probably return one FieldError regardless of how many matches
it finds.

Comments

dpp Tue Nov 17 06:16:32 -0800 2009 | link

Now only 1 error is reported.

Comment
Now only 1 error is reported.
or cancel

Parsed with GitHub Flavored Markdown

177.

0 votes

aboisvert

x

n.l.http.XmlResponse should take a code: Int

10 comments Created about 1 month ago by harryh

Title

Body
Pretty simple. I want to be able to send XmlResponses with a HTTP code other than 200.
or cancel

Pretty simple. I want to be able to send XmlResponses with a HTTP code other than 200.

Comments

aboisvert Thu Nov 12 12:41:04 -0800 2009 | link

Have you tried:

new XmlResponse(xml) {
  override val code = 202 // ACCEPTED
}

(Feel free to reopen if that doesn't work for you)

Comment
Have you tried: new XmlResponse(xml) { override val code = 202 // ACCEPTED } (Feel free to reopen if that doesn't work for you)
or cancel

harryh Thu Nov 12 12:43:49 -0800 2009 | link

Ya, that will work, but something a bit more convenient seems desirable. Many other response types come with companion objects with apply() methods that take a response code. Doing the same for XmlResponse (and also, while we're at it, JsonResponse) seems reasonable.

Comment
Ya, that will work, but something a bit more convenient seems desirable. Many other response types come with companion objects with apply() methods that take a response code. Doing the same for XmlResponse (and also, while we're at it, JsonResponse) seems reasonable.
or cancel

aboisvert Thu Nov 12 14:14:44 -0800 2009 | link

What response would you like to send? I'm asking because there's already a lot of pre-defined response classes in the net.liftweb.http package.

You can also easily create your own customized response class by extending NodeResponse:

case class CreatedResponse(xml: Node) extends NodeResponse {
  def docType = Empty
  def code = 201 // CREATED
  def headers = List("Content-Type" -> "text/xml; charset=utf-8")
  def cookies = Nil
  def out = xml
}

Comment
What response would you like to send? I'm asking because there's already a lot of pre-defined response classes in the net.liftweb.http package. You can also easily create your own customized response class by extending NodeResponse: case class CreatedResponse(xml: Node) extends NodeResponse { def docType = Empty def code = 201 // CREATED def headers = List("Content-Type" -> "text/xml; charset=utf-8") def cookies = Nil def out = xml }
or cancel

harryh Thu Nov 12 14:22:48 -0800 2009 | link

I want to send an XmlResponse with a response code other than 200 (400, 401, 501 primarily). I know I can do this with this code as it, but it seems like something like this:

XmlResponse(<error>invalid parameter: foo</error>, 401)

Would be nice, simple, and generally usable.

Comment
I want to send an XmlResponse with a response code other than 200 (400, 401, 501 primarily). I know I can do this with this code as it, but it seems like something like this: XmlResponse(&lt;error>invalid parameter: foo&lt;/error>, 401) Would be nice, simple, and generally usable.
or cancel

aboisvert Thu Nov 12 14:31:59 -0800 2009 | link

Ok, then I'm proposing the following for the review-board:

case class XmlCodeResponse(xml: Node, code: Int) extends NodeResponse {
def docType = Empty def headers = List("Content-Type" -> "text/xml; charset=utf-8") def cookies = Nil def out = xml }

(I assume we don't want to change the signature of the existing XmlResponse for backward compatibility)

Comment
Ok, then I'm proposing the following for the review-board: case class XmlCodeResponse(xml: Node, code: Int) extends NodeResponse { def docType = Empty def headers = List("Content-Type" -> "text/xml; charset=utf-8") def cookies = Nil def out = xml } (I assume we don't want to change the signature of the existing XmlResponse for backward compatibility)
or cancel

harryh Thu Nov 12 14:56:16 -0800 2009 | link

Replacing the XmlResponse case class with a class that takes (xml: Node, code: Int) + a companion object with two apply methods (one that takes a code, one that doesn't) should be fine I think....

Comment
Replacing the XmlResponse case class with a class that takes (xml: Node, code: Int) + a companion object with two apply methods (one that takes a code, one that doesn't) should be fine I think....
or cancel

aboisvert Thu Nov 12 15:04:12 -0800 2009 | link

You're right. Why didn't I think of that? I already pushed my fix but I'll change it.

Comment
You're right. Why didn't I think of that? I already pushed my fix but I'll change it.
or cancel

aboisvert Thu Nov 12 15:22:41 -0800 2009 | link

Here's the updated code.

class XmlResponse(val xml: Node, val code: Int, mime: String) extends NodeResponse {

  def docType = Empty

  def headers = List("Content-Type" -> mime)

  def cookies = Nil

  def out = xml
}

object XmlResponse {
  /** Construct XmlResponse with 200 OK response code and "text/xml" mime type */
  def apply(xml: Node) = new XmlResponse(xml, 200, "text/xml; charset=utf-8")

  /** Construct XmlResponse with given response code and "text/xml" mime type */
  def apply(xml: Node, code: Int) = new XmlResponse(xml, code, "text/xml; charset=utf-8")

  /** Construct XmlResponse with 200 OK response code and given mime type */
  def apply(xml: Node, mime: String) = new XmlResponse(xml, 200, mime)

  /** Construct XmlResponse with given response code and mime type */
  def apply(xml: Node, code: Int, mime: String) = new XmlResponse(xml, code, mime)
}

Comment
Here's the updated code. class XmlResponse(val xml: Node, val code: Int, mime: String) extends NodeResponse { def docType = Empty def headers = List("Content-Type" -> mime) def cookies = Nil def out = xml } object XmlResponse { /** Construct XmlResponse with 200 OK response code and "text/xml" mime type */ def apply(xml: Node) = new XmlResponse(xml, 200, "text/xml; charset=utf-8") /** Construct XmlResponse with given response code and "text/xml" mime type */ def apply(xml: Node, code: Int) = new XmlResponse(xml, code, "text/xml; charset=utf-8") /** Construct XmlResponse with 200 OK response code and given mime type */ def apply(xml: Node, mime: String) = new XmlResponse(xml, 200, mime) /** Construct XmlResponse with given response code and mime type */ def apply(xml: Node, code: Int, mime: String) = new XmlResponse(xml, code, mime) }
or cancel

harryh Thu Nov 12 15:23:58 -0800 2009 | link

Oh how much shorter this will all be when we get named + default parameters with 2.8!

Comment
Oh how much shorter this will all be when we get named + default parameters with 2.8!
or cancel

aboisvert Thu Nov 12 15:25:38 -0800 2009 | link

Indeed! I was thinking the same :)

Comment
Indeed! I was thinking the same :)
or cancel

Parsed with GitHub Flavored Markdown

176.

0 votes

dpp

x

Context rewriting exclusion does not apply to JsCmds.RedirectTo

2 comments Created about 1 month ago by Dridus

Title

Body
From JsCommands.scala case class RedirectTo(where: String) extends JsCmd { private val context = S.contextPath def toJsCmd = "window.location = " + S.encodeURL(context + where).encJs + ";" } It always writes the context in, so the redirect output to the browser has the context path on it even if where is excluded from context rewriting.
or cancel

From JsCommands.scala

case class RedirectTo(where: String) extends JsCmd {
  private val context = S.contextPath

  def toJsCmd = "window.location = " + S.encodeURL(context + where).encJs + ";"
}

It always writes the context in, so the redirect output to the browser has the context path on it even if where is excluded from context rewriting.

Comments

Dridus Mon Nov 16 06:50:11 -0800 2009 | link

Here is the temporary version I'm using to work around it:

            case class MyRedirectTo(where: String) extends JsCmd {
                private val context = S.contextPath

                def toJsCmd = "window.location = " + S.encodeURL(if (!LiftRules.excludePathFromContextPathRewriting.vend(where)) context + where else where).encJs + ";"
            }

Comment
Here is the temporary version I'm using to work around it: case class MyRedirectTo(where: String) extends JsCmd { private val context = S.contextPath def toJsCmd = "window.location = " + S.encodeURL(if (!LiftRules.excludePathFromContextPathRewriting.vend(where)) context + where else where).encJs + ";" }
or cancel

dpp Tue Nov 17 06:16:08 -0800 2009 | link

Fixed. Thanks for the bug report.

Comment
Fixed. Thanks for the bug report.
or cancel

Parsed with GitHub Flavored Markdown

174.

0 votes

dpp

x

form input names change when changing Lift versions

2 comments Created about 1 month ago by benkeeping

Title

Body
Please see thread http://groups.google.com/group/liftweb/browse_thread/thread/1b5f84876b9d16d7 Thanks
or cancel

Please see thread http://groups.google.com/group/liftweb/browse_thread/thread/1b5f84876b9d16d7

Thanks

Comments

benkeeping Wed Nov 11 12:38:40 -0800 2009 | link

Hi,
Not sure if its the right thing to do, but basing it on the first user element in the stack might be the way to go :

def locateFirstUserStackElement(stack: Array[StackTraceElement]) : StackTraceElement = {

  stack.foreach(element => {
      if (!element.toString.startsWith("net.liftweb")) return element         
  })
  stack(0)

}

def formFuncName: String = if (Props.testMode) {

val bump: Long = ((_formGroup.is openOr 0) + 1000L) * 10000L
val num: Int = formItemNumber.is
formItemNumber.set(num + 1)
import _root_.java.text._
val prefix: String = new DecimalFormat("00000000000000000").format(bump + num)
//M7 - "f" + prefix + "_" + Helpers.hashHex((new Exception).getStackTrace.toList.take(10).map(_.toString).mkString(",")))
"f" + prefix + "_" +Helpers.hashHex(locateFirstUserStackElement(new Exception().getStackTrace).getFileName) 

} else {

_formGroup.is match {
  case Full(x) => Helpers.nextFuncName(x.toLong * 10000L)
  case _ => Helpers.nextFuncName
}

}

Comment
Hi, Not sure if its the right thing to do, but basing it on the first user element in the stack might be the way to go : def locateFirstUserStackElement(stack: Array[StackTraceElement]) : StackTraceElement = { stack.foreach(element => { if (!element.toString.startsWith("net.liftweb")) return element }) stack(0) } def formFuncName: String = if (Props.testMode) { val bump: Long = ((_formGroup.is openOr 0) + 1000L) * 10000L val num: Int = formItemNumber.is formItemNumber.set(num + 1) import _root_.java.text._ val prefix: String = new DecimalFormat("00000000000000000").format(bump + num) //M7 - "f" + prefix + "_" + Helpers.hashHex((new Exception).getStackTrace.toList.take(10).map(_.toString).mkString(","))) "f" + prefix + "_" +Helpers.hashHex(locateFirstUserStackElement(new Exception().getStackTrace).getFileName) } else { _formGroup.is match { case Full(x) => Helpers.nextFuncName(x.toLong * 10000L) case _ => Helpers.nextFuncName } }
or cancel

dpp Tue Nov 17 06:15:38 -0800 2009 | link

The first 2 non-Lift, non-Scala stack frames are used to calculate the hash. This should result in more stability.

Comment
The first 2 non-Lift, non-Scala stack frames are used to calculate the hash. This should result in more stability.
or cancel

Parsed with GitHub Flavored Markdown

173.

0 votes

dpp

x

The current TestKit APIs are hard to use

2 comments Created about 1 month ago by dpp

Title

Body
Create alternative APIs that are cleaner and easier to use
or cancel

Create alternative APIs that are cleaner and easier to use

Comments

dpp Thu Nov 12 11:48:18 -0800 2009 | link

Enhancements committed up

Comment
Enhancements committed up
or cancel

dpp Thu Nov 12 11:48:26 -0800 2009 | link

Closed

Comment
Closed
or cancel

Parsed with GitHub Flavored Markdown

172.

0 votes

findOne in addition to findAll

2 comments Created about 1 month ago by awhitford

Title

Body
For Lift-Mapper, when searching for a record, I am using findAll... JPA makes a distinction between a single result object vs. a List of objects: http://java.sun.com/javaee/5/docs/api/javax/persistence/Query.html#getSingleResult() vs. http://java.sun.com/javaee/5/docs/api/javax/persistence/Query.html#getResultList() Certainly, it is convenient with Scala just to call findAll() then take the head -- but a fundamental assertion is missing: when calling getSingleResult, I am expecting only one matching item -- if the List length > 1, then that is a problem! In the mean time, I will call findAll().head to get the single result. But, I would really like it if Mapper was extended to include this concept so that I could replace it with findOne()... If more than one record returned, an exception should be thrown (or a Failure). A Box would make a lot of sense because then you have a concept for Empty.
or cancel

For Lift-Mapper, when searching for a record, I am using findAll...

JPA makes a distinction between a single result object vs. a List of objects: http://java.sun.com/javaee/5/docs/api/javax/persistence/Query.html#getSingleResult() vs. http://java.sun.com/javaee/5/docs/api/javax/persistence/Query.html#getResultList()

Certainly, it is convenient with Scala just to call findAll() then take the head -- but a fundamental assertion is missing: when calling getSingleResult, I am expecting only one matching item -- if the List length > 1, then that is a problem!

In the mean time, I will call findAll().head to get the single result. But, I would really like it if Mapper was extended to include this concept so that I could replace it with findOne()... If more than one record returned, an exception should be thrown (or a Failure). A Box would make a lot of sense because then you have a concept for Empty.

Comments

hoffrocket Tue Nov 10 08:25:16 -0800 2009 | link

what about just "find(key:Any)" or "find(by: QueryParam[A]*)"? both return a box.
Also, take a look at List.firstOption

Comment
what about just "find(key:Any)" or "find(by: QueryParam[A]*)"? both return a box. Also, take a look at List.firstOption
or cancel

dpp Tue Nov 10 16:38:09 -0800 2009 | link

As Jon points out, the find() method is what you're asking for (except find returns the first element and discards any additional elements).

Also, please do not file tickets unless you've made a post to the Lift list asking about a particular feature.

Comment
As Jon points out, the find() method is what you're asking for (except find returns the first element and discards any additional elements). Also, please do not file tickets unless you've made a post to the Lift list asking about a particular feature.
or cancel

Parsed with GitHub Flavored Markdown

171.

0 votes

derby.log file created in ${basedir} for lift-mapper

1 comment Created about 1 month ago by awhitford

Title

Body
After doing a build for lift-mapper, I see a derby.log file created in the ${basedir} (beside pom.xml, etc.). This log file was created by the unit tests. This log file should have been created in the target folder (${project.build.directory}, for example) so that a mvn clean destroys any build artifacts.
or cancel

After doing a build for lift-mapper, I see a derby.log file created in the ${basedir} (beside pom.xml, etc.). This log file was created by the unit tests. This log file should have been created in the target folder (${project.build.directory}, for example) so that a mvn clean destroys any build artifacts.

Comments

dpp Tue Nov 10 06:30:36 -0800 2009 | link

If you want to change where the derby files are located, please change the DB URL for your app. This is not a Lift bug. Generally, it's best to discuss issues on the Lift list before opening tickets.

Comment
If you want to change where the derby files are located, please change the DB URL for your app. This is not a Lift bug. Generally, it's best to discuss issues on the Lift list before opening tickets.
or cancel

Parsed with GitHub Flavored Markdown

170.

0 votes

aboisvert

x

Typo in Req.scala (very minor bug)

1 comment Created about 1 month ago by harryh

Title

Body
Missing a space after "URL" and before "was": private[liftweb] def defaultCreateNotFound(in: Req) = XhtmlResponse((<html> <body>The Requested URL{in.contextPath + in.uri}was not found on this server</body> </html>), ResponseInfo.docType(in), List("Content-Type" -> "text/html; charset=utf-8"), Nil, 404, S.ieMode)
or cancel

Missing a space after "URL" and before "was":

private[liftweb] def defaultCreateNotFound(in: Req) =
XhtmlResponse(( The Requested URL{in.contextPath + in.uri}was not found on this server ), ResponseInfo.docType(in), List("Content-Type" -> "text/html; charset=utf-8"), Nil, 404, S.ieMode)

Comments

aboisvert Thu Nov 12 12:36:40 -0800 2009 | link

Fixed.

commit bf31a83
Author: Alex Boisvert boisvert@intalio.com">boisvert@intalio.com
Date: Thu Nov 12 12:33:50 2009 -0800

Issue 170: Typo in Req.scala

Comment
Fixed. commit bf31a83ec79a05e81c04c9e94023f277711d3759 Author: Alex Boisvert <boisvert@intalio.com> Date: Thu Nov 12 12:33:50 2009 -0800 Issue 170: Typo in Req.scala
or cancel

Parsed with GitHub Flavored Markdown

169.

1 vote

aboisvert

x

Lift should allow injecting custom driver abstractions

4 comments Created about 1 month ago by lopex

Title

Body
In Driver.scala there is no way to intercept singleton method calcDriver to allow user supported driver abstractions since in DB.scala DriverType object is used explicitly.
or cancel

In Driver.scala there is no way to intercept singleton method calcDriver to allow user supported driver abstractions since in DB.scala DriverType object is used explicitly.

Comments

dpp Tue Nov 10 06:27:48 -0800 2009 | link

This is not going to change in the near term. If there a particular driver you want to implement?

Comment
This is not going to change in the near term. If there a particular driver you want to implement?
or cancel

aboisvert Thu Nov 12 17:27:17 -0800 2009 | link

How about doing someting similar to Bootstrap?

We could look for a class named "net.liftweb.DriverPF", assume that it's a PartialFunction[[Tuple3[dbName,major,minor], DriverType]] and if there's a match then we use the returned DriverType, otherwise we pick according to the static list encoded in Lift.

Probably just a few lines of code.

Comment
How about doing someting similar to Bootstrap? We could look for a class named "net.liftweb.DriverPF", assume that it's a PartialFunction[[Tuple3[dbName,major,minor], DriverType]] and if there's a match then we use the returned DriverType, otherwise we pick according to the static list encoded in Lift. Probably just a few lines of code.
or cancel

lopex Sat Nov 14 09:45:55 -0800 2009 | link

It's a jt400 (DB2 AS/400) driver, but probably will also play with db2jcc (DB2 Z/OS).

Comment
It's a jt400 (DB2 AS/400) driver, but probably will also play with db2jcc (DB2 Z/OS).
or cancel

dpp Mon Nov 16 11:37:59 -0800 2009 | link

DriverType.calcDriver is now a Connection => DriverType var

You can do something in Boot.scala to change the function to return your driver.

Comment
DriverType.calcDriver is now a Connection => DriverType var You can do something in Boot.scala to change the function to return your driver.
or cancel

Parsed with GitHub Flavored Markdown

168.

0 votes

indrajitr

x

javax.activation dependency

1 comment Created about 1 month ago by awhitford

Title

Body
If javax.activation is merely a transitive dependency for javax.mail, then it should not be explicitly declared in http://scala-tools.org/repo-releases/net/liftweb/lift/1.1-M7/lift-1.1-M7.pom Note that according to this: http://java.sun.com/products/javamail/ the Activation framework dependency is not necessary for Java 6 users because it is included. See thread: http://groups.google.com/group/liftweb/browse_thread/thread/f435fd3a0ddbd08e
or cancel

If javax.activation is merely a transitive dependency for javax.mail, then it should not be explicitly declared in http://scala-tools.org/repo-releases/net/liftweb/lift/1.1-M7/lift-1.1-M7.pom

Note that according to this: http://java.sun.com/products/javamail/
the Activation framework dependency is not necessary for Java 6 users because it is included.

See thread: http://groups.google.com/group/liftweb/browse_thread/thread/f435fd3a0ddbd08e

Comments

indrajitr Wed Nov 11 05:22:58 -0800 2009 | link

Remove transitive dependency javax.activation as javax.mail will pull that up. Closed by 0cac04c.
Make javax.mail version range narrow to avoid issues when Sun's repo is used by Lift based applications (avoids SNAPSHOT jar being downloaded from Sun's repo).

Comment
Remove transitive dependency javax.activation as javax.mail will pull that up. Closed by 0cac04cb0d05c07a222d07f980ecf9946ec49588. Make javax.mail version range narrow to avoid issues when Sun's repo is used by Lift based applications (avoids SNAPSHOT jar being downloaded from Sun's repo).
or cancel

Parsed with GitHub Flavored Markdown

167.

0 votes

aboisvert

x

indrajitr

x

No scala source file in *SNAPSHOT-sources.jar

4 comments Created about 1 month ago by jeppenejsum

Title

Body
The *SNAPSHOT-sources.jar doesn't seem to contain any scala source files, only static resources
or cancel

The *SNAPSHOT-sources.jar doesn't seem to contain any scala source files, only static resources

Comments

aboisvert Thu Nov 12 16:36:34 -0800 2009 | link

I'm using Maven 2.2.1 and I can't reproduce this on my machine.

I've checked that lift-util, lift-webkit and lift-common source packages (among others) all have appropriate .scala sources

Comment
I'm using Maven 2.2.1 and I can't reproduce this on my machine. I've checked that lift-util, lift-webkit and lift-common source packages (among others) all have appropriate .scala sources
or cancel

jeppenejsum Thu Nov 12 23:18:25 -0800 2009 | link

Strange again :-)

util & common seem to be ok.

If I do rm -rf ~/.m2/repository && mvn clean test && mvn eclipse:eclipse

And the search through all the source jars, these are the only files found:

find ~/.m2/repository/net/liftweb/ -name "*-sources.jar" -print|xargs -n 1 unzip -l|grep scala

 6332  10-23-09 03:27   net/liftweb/actor/LiftActor.scala
 1321  10-23-09 03:27   net/liftweb/actor/LAFuture.scala
 2463  10-23-09 03:27   net/liftweb/actor/LAPinger.scala
 1826  10-23-09 03:27   net/liftweb/common/Actor.scala
14352  10-23-09 03:27   net/liftweb/common/Box.scala
 4322  10-23-09 03:27   net/liftweb/util/RE.scala
 3010  10-23-09 03:27   net/liftweb/util/BindPlus.scala
 7769  10-23-09 03:27   net/liftweb/util/CombParserHelpers.scala
 2172  10-23-09 03:27   net/liftweb/util/VCardParser.scala
 4287  10-23-09 03:27   net/liftweb/util/Lazy.scala
 8053  10-23-09 03:27   net/liftweb/util/Mailer.scala
 2420  10-23-09 03:27   net/liftweb/util/ThreadGlobal.scala
 1333  10-23-09 03:27   net/liftweb/util/ValueHolder.scala
 9586  10-23-09 03:27   net/liftweb/util/Log.scala
 3264  10-23-09 03:27   net/liftweb/util/Vars.scala
 3140  10-23-09 03:27   net/liftweb/util/LD.scala
11432  10-23-09 03:27   net/liftweb/util/SecurityHelpers.scala
 6960  10-23-09 03:27   net/liftweb/util/ListHelpers.scala
 4599  10-23-09 03:27   net/liftweb/util/Slf4jLog.scala
 1749  10-23-09 03:27   net/liftweb/util/EnumWithDescription.scala
17043  10-23-09 03:27   net/liftweb/util/ClassHelpers.scala
 8685  10-23-09 03:27   net/liftweb/util/HttpHelpers.scala
 4074  10-23-09 03:27   net/liftweb/util/CSSHelpers.scala
 3729  10-23-09 03:27   net/liftweb/util/NamedPartialFunction.scala
 1628  10-23-09 03:27   net/liftweb/util/Helpers.scala
 1829  10-23-09 03:27   net/liftweb/util/KeyedCache.scala
 1593  10-23-09 03:27   net/liftweb/util/Misc.scala
 1765  10-23-09 03:27   net/liftweb/util/LRU.scala
 3272  10-23-09 03:27   net/liftweb/util/HeadHelper.scala
 1159  10-23-09 03:27   net/liftweb/util/ConcurrentLock.scala
 5006  10-23-09 03:27   net/liftweb/util/Maker.scala
 3757  10-23-09 03:27   net/liftweb/util/ActorPing.scala
 3194  10-23-09 03:27   net/liftweb/util/IOHelpers.scala
 2771  10-23-09 03:27   net/liftweb/util/Currency.scala
 1155  10-23-09 03:27   net/liftweb/util/LoanWrapper.scala
 6887  10-23-09 03:27   net/liftweb/util/BasicTypesHelpers.scala
 7399  10-23-09 03:27   net/liftweb/util/Props.scala
24153  10-23-09 03:27   net/liftweb/util/BindHelpers.scala
 5490  10-23-09 03:27   net/liftweb/util/CurrencyZone.scala
 6006  10-23-09 03:27   net/liftweb/util/JSON.scala
12572  10-23-09 03:27   net/liftweb/util/TimeHelpers.scala
 2183  10-23-09 03:27   net/liftweb/util/CodeHelpers.scala
14901  10-23-09 03:27   net/liftweb/util/PCDataMarkupParser.scala
 2030  10-23-09 03:27   net/liftweb/util/TemplateCache.scala
 4660  10-23-09 03:27   net/liftweb/util/ControlHelpers.scala
 3649  10-23-09 03:27   net/liftweb/util/SoftReferenceCache.scala
 8809  10-23-09 03:27   net/liftweb/util/StringHelpers.scala

This is with Maven 2.2.0, not sure if this changes anything since the jars seem to be downloaded ok?

Comment
Strange again :-) *util & *common seem to be ok. If I do rm -rf ~/.m2/repository && mvn clean test && mvn eclipse:eclipse And the search through all the source jars, these are the only files found: find ~/.m2/repository/net/liftweb/ -name "*-sources.jar" -print|xargs -n 1 unzip -l|grep scala 6332 10-23-09 03:27 net/liftweb/actor/LiftActor.scala 1321 10-23-09 03:27 net/liftweb/actor/LAFuture.scala 2463 10-23-09 03:27 net/liftweb/actor/LAPinger.scala 1826 10-23-09 03:27 net/liftweb/common/Actor.scala 14352 10-23-09 03:27 net/liftweb/common/Box.scala 4322 10-23-09 03:27 net/liftweb/util/RE.scala 3010 10-23-09 03:27 net/liftweb/util/BindPlus.scala 7769 10-23-09 03:27 net/liftweb/util/CombParserHelpers.scala 2172 10-23-09 03:27 net/liftweb/util/VCardParser.scala 4287 10-23-09 03:27 net/liftweb/util/Lazy.scala 8053 10-23-09 03:27 net/liftweb/util/Mailer.scala 2420 10-23-09 03:27 net/liftweb/util/ThreadGlobal.scala 1333 10-23-09 03:27 net/liftweb/util/ValueHolder.scala 9586 10-23-09 03:27 net/liftweb/util/Log.scala 3264 10-23-09 03:27 net/liftweb/util/Vars.scala 3140 10-23-09 03:27 net/liftweb/util/LD.scala 11432 10-23-09 03:27 net/liftweb/util/SecurityHelpers.scala 6960 10-23-09 03:27 net/liftweb/util/ListHelpers.scala 4599 10-23-09 03:27 net/liftweb/util/Slf4jLog.scala 1749 10-23-09 03:27 net/liftweb/util/EnumWithDescription.scala 17043 10-23-09 03:27 net/liftweb/util/ClassHelpers.scala 8685 10-23-09 03:27 net/liftweb/util/HttpHelpers.scala 4074 10-23-09 03:27 net/liftweb/util/CSSHelpers.scala 3729 10-23-09 03:27 net/liftweb/util/NamedPartialFunction.scala 1628 10-23-09 03:27 net/liftweb/util/Helpers.scala 1829 10-23-09 03:27 net/liftweb/util/KeyedCache.scala 1593 10-23-09 03:27 net/liftweb/util/Misc.scala 1765 10-23-09 03:27 net/liftweb/util/LRU.scala 3272 10-23-09 03:27 net/liftweb/util/HeadHelper.scala 1159 10-23-09 03:27 net/liftweb/util/ConcurrentLock.scala 5006 10-23-09 03:27 net/liftweb/util/Maker.scala 3757 10-23-09 03:27 net/liftweb/util/ActorPing.scala 3194 10-23-09 03:27 net/liftweb/util/IOHelpers.scala 2771 10-23-09 03:27 net/liftweb/util/Currency.scala 1155 10-23-09 03:27 net/liftweb/util/LoanWrapper.scala 6887 10-23-09 03:27 net/liftweb/util/BasicTypesHelpers.scala 7399 10-23-09 03:27 net/liftweb/util/Props.scala 24153 10-23-09 03:27 net/liftweb/util/BindHelpers.scala 5490 10-23-09 03:27 net/liftweb/util/CurrencyZone.scala 6006 10-23-09 03:27 net/liftweb/util/JSON.scala 12572 10-23-09 03:27 net/liftweb/util/TimeHelpers.scala 2183 10-23-09 03:27 net/liftweb/util/CodeHelpers.scala 14901 10-23-09 03:27 net/liftweb/util/PCDataMarkupParser.scala 2030 10-23-09 03:27 net/liftweb/util/TemplateCache.scala 4660 10-23-09 03:27 net/liftweb/util/ControlHelpers.scala 3649 10-23-09 03:27 net/liftweb/util/SoftReferenceCache.scala 8809 10-23-09 03:27 net/liftweb/util/StringHelpers.scala This is with Maven 2.2.0, not sure if this changes anything since the jars seem to be downloaded ok?
or cancel

jeppenejsum Thu Nov 12 23:19:48 -0800 2009 | link

Also, look at the archive date of those files....

Comment
Also, look at the archive date of those files....
or cancel

indrajitr Thu Dec 17 08:45:30 -0800 2009 | link

Ensure addition of scala directory to the source path list for relevant goals in subsequent phases.
Closed by dfb8521.

Comment
Ensure addition of scala directory to the source path list for relevant goals in subsequent phases. Closed by dfb852156ea4bda849cc97739b6aeb1a41adef37.
or cancel

Parsed with GitHub Flavored Markdown

166.

-1 votes

hseeberger

x

snapshot jars contains several Box.class files

6 comments Created about 1 month ago by jeppenejsum

Title

Body
There seems to be a build issue after the reorg into common. I can find e.g. net.liftweb.common.Box.class in both lift-common-1.1-SNAPSHOT lift-webkit-1.1-SNAPSHOT This causes confusion in Eclipse when you try to find the source of a class.
or cancel

There seems to be a build issue after the reorg into common.

I can find e.g. net.liftweb.common.Box.class in both

lift-common-1.1-SNAPSHOT
lift-webkit-1.1-SNAPSHOT

This causes confusion in Eclipse when you try to find the source of a class.

Comments

aboisvert Thu Nov 12 12:25:39 -0800 2009 | link

I can't reproduce with the current master codebase.

Comment
I can't reproduce with the current master codebase.
or cancel

jeppenejsum Thu Nov 12 12:54:59 -0800 2009 | link

Strange...I've just done this in a directory with the basic archetype (1.1-SNAPSHOT):

rm -rf ~/.m2/repository/
mvn clean compile

unzip -l ~/.m2/repository/net/liftweb/lift-webkit/1.1-SNAPSHOT/lift-webkit-1.1-SNAPSHOT.jar |grep Box

 3995  11-11-09 11:58   net/liftweb/common/Box$.class
 8461  11-11-09 11:58   net/liftweb/common/Box.class
 2520  11-11-09 11:58   net/liftweb/common/EmptyBox.class
 1636  11-11-09 12:02   net/liftweb/http/FirstBox$class.class
  741  11-11-09 12:02   net/liftweb/http/FirstBox.class

unzip -l ~/.m2/repository/net/liftweb/lift-common/1.1-SNAPSHOT/lift-common-1.1-SNAPSHOT.jar |grep Box

 3995  11-11-09 11:58   net/liftweb/common/Box$.class
 8461  11-11-09 11:58   net/liftweb/common/Box.class
 2520  11-11-09 11:58   net/liftweb/common/EmptyBox.class

Basically, it seems all the contents of lift-common.jar is included in lift-webkit.jar

Comment
Strange...I've just done this in a directory with the basic archetype (1.1-SNAPSHOT): rm -rf ~/.m2/repository/ mvn clean compile unzip -l ~/.m2/repository/net/liftweb/lift-webkit/1.1-SNAPSHOT/lift-webkit-1.1-SNAPSHOT.jar |grep Box 3995 11-11-09 11:58 net/liftweb/common/Box$.class 8461 11-11-09 11:58 net/liftweb/common/Box.class 2520 11-11-09 11:58 net/liftweb/common/EmptyBox.class 1636 11-11-09 12:02 net/liftweb/http/FirstBox$class.class 741 11-11-09 12:02 net/liftweb/http/FirstBox.class unzip -l ~/.m2/repository/net/liftweb/lift-common/1.1-SNAPSHOT/lift-common-1.1-SNAPSHOT.jar |grep Box 3995 11-11-09 11:58 net/liftweb/common/Box$.class 8461 11-11-09 11:58 net/liftweb/common/Box.class 2520 11-11-09 11:58 net/liftweb/common/EmptyBox.class Basically, it seems all the contents of lift-common.jar is included in lift-webkit.jar
or cancel

aboisvert Thu Nov 12 13:28:34 -0800 2009 | link

Ok, my bad. I was just looking at the target/classes directories. Looking in the generated .jars I can see the same as you.

Comment
Ok, my bad. I was just looking at the target/classes directories. Looking in the generated .jars I can see the same as you.
or cancel

hseeberger Thu Nov 12 23:26:08 -0800 2009 | link

It's a problem with the configuration of the maven-bundle-plugin. Fixing should be easy.

Comment
It's a problem with the configuration of the maven-bundle-plugin. Fixing should be easy.
or cancel

hseeberger Fri Nov 13 08:58:49 -0800 2009 | link

Commit 1e940f5

Comment
Commit 1e940f5c6702abbc80a087c5e149260037463387
or cancel

aboisvert Fri Nov 13 19:11:13 -0800 2009 | link

Fixed.

commit 18a0cc1
Author: Heiko Seeberger heiko.seeberger@googlemail.com">heiko.seeberger@googlemail.com
Date: Fri Nov 13 09:37:45 2009 +0100

Issue 166: Snapshot jars contains several Box.class files

Comment
Fixed. commit 18a0cc1875c7b2437a3fa117d07718b4b3fdb00d Author: Heiko Seeberger <heiko.seeberger@googlemail.com> Date: Fri Nov 13 09:37:45 2009 +0100 Issue 166: Snapshot jars contains several Box.class files
or cancel

Parsed with GitHub Flavored Markdown

165.

0 votes

dpp

x

MappedForeignKey : Access to .obj field after update

1 comment Created about 1 month ago by jeanadrien

Title

Body
<dl> <dt>Module</dt> <dd>Mapper</dd> <dt>Request</dt> <dd>When updating the referenced object in a MappedForeignKey column, the .is field returns the new value of the id, but the .obj field still returns the reference of the object originally loaded with the owner. The .is and .obj should be coherent.</dd> <dt>Example</dt> <dd><pre> val testUser : User = User.find(By(User.id, 1)).open_! val testAddress = testUser.homeAddress.obj; Log.debug("Current FK id is "+testUser.homeAddress.is) // returns 1 testAddress match { case Full(addr) => val anotherAddr : Address = Address.find(By(Address.id,2)).open_! Log.debug("There was an address: "+addr+". Replace it with addr id#2: "+anotherAddr); testUser.homeAddress(anotherAddr).save case _ => [...] } val retestAddress = testUser.homeAddress.obj Log.debug("Now obj is "+retestAddress); // returns a Box with the old address (id == 1) Log.debug("And is is "+testUser.homeAddress.is) // returns 2 </pre></dd> <dt>See</dt> <dd> http://groups.google.com/group/liftweb/browse_thread/thread/0041894ec33fc538/0bcb1a85658155af?hl=en#0bcb1a85658155af </dd> </dl> Regarding to this thread
or cancel

Module

Mapper

Request

When updating the referenced object in a MappedForeignKey column, the .is field returns the new value of the id, but the .obj field still returns the reference of the object originally loaded with the owner. The .is and .obj should be coherent.

Example

    val testUser : User = User.find(By(User.id, 1)).open_!
    val testAddress = testUser.homeAddress.obj;
    Log.debug("Current FK id is "+testUser.homeAddress.is) // returns 1

    testAddress match {
      case Full(addr) =>
         val anotherAddr : Address = Address.find(By(Address.id,2)).open_!
         Log.debug("There was an address: "+addr+". Replace it with addr id#2: "+anotherAddr);
          testUser.homeAddress(anotherAddr).save

      case _ =>
        [...]
    }
    val retestAddress = testUser.homeAddress.obj
    Log.debug("Now obj is "+retestAddress); // returns a Box with the old address (id == 1)
    Log.debug("And is is "+testUser.homeAddress.is) // returns 2 

See

http://groups.google.com/group/liftweb/browse_thread/thread/0041894ec33fc538/0bcb1a85658155af?hl=en#0bcb1a85658155af

Regarding to this thread

Comments

dpp Tue Nov 17 06:15:01 -0800 2009 | link

Cache cleared when field set so .obj will be refetched when setting the field

Comment
Cache cleared when field set so .obj will be refetched when setting the field
or cancel

Parsed with GitHub Flavored Markdown

164.

0 votes

dpp

x

On Review Board

x

S.notice, S.error, etc. broken from within AJAX/JSON calls

1 comment Created about 1 month ago by Dridus

Title

Body
I had some code working where the snippet generates a JSON callback which uses S.notice / S.error to push notifications back to the browser in addition to whatever JS commands the snippet decides to push down, but it seems that this is now broken in 1.1-SNAPSHOT and 1.1-M7. I can confirm that just after I call S.notice within the jsonCall that S.getNotices has the proper thing in it, but by the time LiftRules.noticesToJsCmd gets called it has vanished. I've created a modified lift-archetype-blank that demonstrates the behavior at http://www.github.com/dridus/test-missing-notices -- here is a overview of the code: In template: <lift:surround with="default" at="content"> <lift:helloWorld.callback /> <h2>Welcome to your project!</h2> <p> </p> <lift:Msgs /> <button onclick="testCallback()">Click me</button> </lift:surround> In Boot: val oldNoticesToJsCmd = LiftRules.noticesToJsCmd LiftRules.noticesToJsCmd = () => { println("at noticesToJsCmd: S.getNotices = " + S.getNotices) oldNoticesToJsCmd() } In snippet: class HelloWorld extends DispatchSnippet { val dispatch: DispatchIt = { case "callback" => renderCallback _ } def renderCallback(ns: NodeSeq): NodeSeq = { S.notice("this is the test notice from the snippet") <head>{ Script { Function("testCallback", Nil, jsonCall(JsNull, (_: Any) => { S.notice("this is the test notice from the callback") println("in callback: S.getNotices = " + S.getNotices) Noop })._2) } }</head> } } The output from this on the command line is: INFO - Service request (GET) / took 570 Milliseconds INFO - Service request (GET) /classpath/jquery.js took 15 Milliseconds INFO - Service request (GET) /ajax_request/liftAjax.js took 8 Milliseconds in callback: S.getNotices = List((net.liftweb.http.NoticeType(0),this is the test notice from the snippet,Empty), (net.liftweb.http.NoticeType(0),this is the test notice from the callback,Empty)) at noticesToJsCmd: S.getNotices = List() INFO - Service request (POST) /ajax_request/F1007892194776GPS/ took 59 Milliseconds And no notice appears.
or cancel

I had some code working where the snippet generates a JSON callback which uses S.notice / S.error to push notifications back to the browser in addition to whatever JS commands the snippet decides to push down, but it seems that this is now broken in 1.1-SNAPSHOT and 1.1-M7. I can confirm that just after I call S.notice within the jsonCall that S.getNotices has the proper thing in it, but by the time LiftRules.noticesToJsCmd gets called it has vanished.

I've created a modified lift-archetype-blank that demonstrates the behavior at http://www.github.com/dridus/test-missing-notices -- here is a overview of the code:

In template:

<lift:surround with="default" at="content">
   <lift:helloWorld.callback />

   <h2>Welcome to your project!</h2>
   <p>
   </p>

   <lift:Msgs />

   <button onclick="testCallback()">Click me</button>

</lift:surround>

In Boot:

   val oldNoticesToJsCmd = LiftRules.noticesToJsCmd

   LiftRules.noticesToJsCmd = () => {
       println("at noticesToJsCmd: S.getNotices = " + S.getNotices)
       oldNoticesToJsCmd()
   }

In snippet:

class HelloWorld extends DispatchSnippet {
   val dispatch: DispatchIt = {
       case "callback" => renderCallback _
   }

   def renderCallback(ns: NodeSeq): NodeSeq = {
       S.notice("this is the test notice from the snippet")
       <head>{ Script {
           Function("testCallback", Nil, jsonCall(JsNull, (_: Any) => {
               S.notice("this is the test notice from the callback")
               println("in callback: S.getNotices = " + S.getNotices)
               Noop
           })._2)
       } }</head>
   }
}

The output from this on the command line is:

INFO - Service request (GET) / took 570 Milliseconds
INFO - Service request (GET) /classpath/jquery.js took 15 Milliseconds
INFO - Service request (GET) /ajax_request/liftAjax.js took 8 Milliseconds
in callback: S.getNotices = List((net.liftweb.http.NoticeType(0),this is the test notice from the snippet,Empty), (net.liftweb.http.NoticeType(0),this is the test notice from the callback,Empty))
at noticesToJsCmd: S.getNotices = List()
INFO - Service request (POST) /ajax_request/F1007892194776GPS/ took 59 Milliseconds

And no notice appears.

Comments

dpp Thu Nov 12 11:48:37 -0800 2009 | link

Fixed

Comment
Fixed
or cancel

Parsed with GitHub Flavored Markdown

163.

0 votes

indrajitr

x

Lift pom needs to be updated for new scala-tools.org hudson policies.

1 comment Created about 1 month ago by jsuereth

Title

Body
Lift's pom needs to be changed for the new nexus/hudson policies on scala-tools.org. I have a forked repo (jsuereth/liftweb) with the changes (also shown below): <pre> --- a/pom.xml +++ b/pom.xml @@ -806,16 +806,16 @@ <id>hudson</id> <distributionManagement> <repository> - <id>hudson.scala-tools.org</id> - <url>file:///home/scala-tools.org/www/repo-snapshots</url> + <id>nexus.scala-tools.org</id> + <url>http://nexus.scala-tools.org/content/repositories/releases</url> </repository> <snapshotRepository> - <id>hudson.scala-tools.org</id> - <url>file:///home/scala-tools.org/www/repo-snapshots</url> + <id>nexus.scala-tools.org</id> + <url>http://nexus.scala-tools.org/content/repositories/snapshots</url> <uniqueVersion>false</uniqueVersion> </snapshotRepository> <site> - <id>hudson.scala-tools.org</id> + <id>nexus.scala-tools.org</id> <url>file:///home/scala-tools.org/www/mvnsites-snapshots/liftweb</url> </site> </distributionManagement> </pre>
or cancel

Lift's pom needs to be changed for the new nexus/hudson policies on scala-tools.org. I have a forked repo (jsuereth/liftweb) with the changes (also shown below):

--- a/pom.xml
+++ b/pom.xml
@@ -806,16 +806,16 @@
       hudson
       
         
-          hudson.scala-tools.org
-          file:///home/scala-tools.org/www/repo-snapshots
+          nexus.scala-tools.org
+          http://nexus.scala-tools.org/content/repositories/releases
         
         
-          hudson.scala-tools.org
-          file:///home/scala-tools.org/www/repo-snapshots
+          nexus.scala-tools.org
+          http://nexus.scala-tools.org/content/repositories/snapshots
           false
         
         
-          hudson.scala-tools.org
+          nexus.scala-tools.org
           file:///home/scala-tools.org/www/mvnsites-snapshots/liftweb
         
       

Comments

indrajitr Fri Nov 06 09:43:35 -0800 2009 | link

Applied from the fork queue. Thanks!

Comment
Applied from the fork queue. Thanks!
or cancel

Parsed with GitHub Flavored Markdown

161.

1 vote

indrajitr

x

Automated tests for all archetypes

1 comment Created about 1 month ago by dpp

Title

Body
Part of the build process should insure that archetypes are tested automatically
or cancel

Part of the build process should insure that archetypes are tested automatically

Comments

indrajitr Wed Nov 25 08:39:17 -0800 2009 | link

Merge archetype refactoring branch 'irc_issue_161'. Closed by 139c87b

Comment
Merge archetype refactoring branch 'irc_issue_161'. Closed by 139c87b9b3e7b7a3789570bfe93051517808acbd
or cancel

Parsed with GitHub Flavored Markdown

160.

0 votes

dpp

x

IN & OrderBy conflict in H2

1 comment Created about 1 month ago by dpp

Title

Body
I just noticed OrderBy statements cause Inner selects to break in h2: I query such as: User.findAll(In(User.id, Dog.owner, OrderBy(Dog.name, Ascending)), MaxRows(5)) Produces: Message: org.h2.jdbc.JdbcSQLException: Order by expression NAME must be in the result list in this case; SQL statement: SELECT DISTINCT OWNER AS _0 FROM PUBLIC.DOG /* PUBLIC.DOG_TABLE_SCAN */ ORDER BY =NAME [90068-117] Code to duplicate here: http://github.com/hoffrocket/lift_1_1_sample/commit/0093e2585e0d9d799b503f32da7496e212efd873 This works in M5. Any chance a workaround or fix could be put out before M7? Sorry, I didn't notice until today.
or cancel

I just noticed OrderBy statements cause Inner selects to break in h2:

I query such as: User.findAll(In(User.id, Dog.owner, OrderBy(Dog.name,
Ascending)), MaxRows(5))

Produces:

Message: org.h2.jdbc.JdbcSQLException: Order by expression NAME must
be in the result list in this case; SQL statement:
SELECT DISTINCT OWNER AS _0
FROM PUBLIC.DOG / PUBLIC.DOG_TABLE_SCAN /
ORDER BY =NAME [90068-117]

Code to duplicate here:

http://github.com/hoffrocket/lift_1_1_sample/commit/0093e2585e0d9d799b503f32da7496e212efd873

This works in M5. Any chance a workaround or fix could be put out
before M7? Sorry, I didn't notice until today.

Comments

dpp Thu Nov 05 15:34:14 -0800 2009 | link

It's an issue with H2 version 1.1, Please upgrade to 1.2

Comment
It's an issue with H2 version 1.1, Please upgrade to 1.2
or cancel

Parsed with GitHub Flavored Markdown

159.

0 votes

dpp

x

Implement Wizard multi-screen input forms

1 comment Created about 1 month ago by dpp

Title

Body

or cancel

Comments

dpp Tue Dec 01 11:23:01 -0800 2009 | link

Added to code base

Comment
Added to code base
or cancel

Parsed with GitHub Flavored Markdown

158.

0 votes

dpp

x

Upgrade Lift to build against Specs 1.6.1

1 comment Created about 1 month ago by dpp

Title

Body
And ScalaTest 1.0 and ScalaCheck 1.6
or cancel

And ScalaTest 1.0 and ScalaCheck 1.6

Comments

dpp Fri Nov 06 11:17:41 -0800 2009 | link

Committed

Comment
Committed
or cancel

Parsed with GitHub Flavored Markdown

157.

0 votes

hseeberger

x

MappedPassword contains misspelled key for unset password

1 comment Created about 1 month ago by hseeberger

Title

Body
password.must.set should be password.must.be.set, the later is in lift-core.properties
or cancel

password.must.set should be password.must.be.set, the later is in lift-core.properties

Comments

hseeberger Tue Nov 03 23:38:22 -0800 2009 | link

Commit 81ebc75

Comment
Commit 81ebc75711410d695b17d7091da58b713b01e26f
or cancel

Parsed with GitHub Flavored Markdown

156.

0 votes

indrajitr

x

JPADemo update pom dependencies hibernate-em 3.4.0GA and slf4j

3 comments Created about 1 month ago by econoplas

Title

Body
Opening an issue at Indrajit's request to update JPADemo/spa/pom.xml to use a newer version of hibernate-entitymanager 3.4.0.GA and resolve slf4j-1.4.2 impl dependencies. The hibernate-entitymanager 3.4.0.GA version update causes an update to hibernate-core to 3.3.0.SP1 which **fixes auto-increment column problem with MySQL and H2 databases**, which was present in the older hibernate 3.2.4 (which dated back to before they called it hibernate-core) upon which hibernate-entitymanager 3.3.1 was depending. Below is the configuration that worked for me. <dependency> <groupId>org.hibernate</groupId> <artifactId>hibernate-entitymanager</artifactId> <version>3.4.0.GA</version> <exclusions> <exclusion> <groupId>javax.transaction</groupId> <artifactId>jta</artifactId> </exclusion> </exclusions> </dependency> <dependency> <groupId>org.slf4j</groupId> <artifactId>slf4j-simple</artifactId> <version>1.4.2</version> </dependency> Had to manually install slf4j-simple/1.4.2 into to my local maven repo to avoid runtime exception for missing org.slf4j.impl.StaticLoggerBinder. By putting the slf4j-simple dependency in the spa/pom.xml this allows users to swap out different impl providers (for example slf4j-log4j12) as they see fit, in fact it might not hurt to have an example of switching this over to slf4j-log4j12 or some other provider, perhaps even commented out just below the other one right in the pom.xml such as: <!-- <dependency> <groupId>org.slf4j</groupId> <artifactId>slf4j-log4j12</artifactId> <version>1.4.2</version> </dependency> --> Thanks! Troy
or cancel

Opening an issue at Indrajit's request to update JPADemo/spa/pom.xml to use a newer version of hibernate-entitymanager 3.4.0.GA and resolve slf4j-1.4.2 impl dependencies.

The hibernate-entitymanager 3.4.0.GA version update causes an update to hibernate-core to 3.3.0.SP1 which fixes auto-increment column problem with MySQL and H2 databases, which was present in the older hibernate 3.2.4 (which dated back to before they called it hibernate-core) upon which hibernate-entitymanager 3.3.1 was depending.

Below is the configuration that worked for me.

<dependency>
 <groupId>org.hibernate</groupId>
 <artifactId>hibernate-entitymanager</artifactId>
  <version>3.4.0.GA</version>
  <exclusions>
   <exclusion>
    <groupId>javax.transaction</groupId>
    <artifactId>jta</artifactId>
   </exclusion>
  </exclusions>
</dependency>
<dependency>
 <groupId>org.slf4j</groupId>
 <artifactId>slf4j-simple</artifactId>
 <version>1.4.2</version>
</dependency>

Had to manually install slf4j-simple/1.4.2 into to my local maven repo to avoid runtime exception for missing org.slf4j.impl.StaticLoggerBinder. By putting the slf4j-simple dependency in the spa/pom.xml this allows users to swap out different impl providers (for example slf4j-log4j12) as they see fit, in fact it might not hurt to have an example of switching this over to slf4j-log4j12 or some other provider, perhaps even commented out just below the other one right in the pom.xml such as:

<!--
 <dependency>
  <groupId>org.slf4j</groupId>
  <artifactId>slf4j-log4j12</artifactId>
  <version>1.4.2</version>
 </dependency>
-->

Thanks! Troy

Comments

econoplas Tue Nov 03 05:18:20 -0800 2009 | link

Per Chris's suggestion, I updated the dependency in my description from slf4j-nop to slf4j-simple as that probably makes more sense for most users.

Comment
Per Chris's suggestion, I updated the dependency in my description from slf4j-nop to slf4j-simple as that probably makes more sense for most users.
or cancel

indrajitr Tue Nov 03 07:14:30 -0800 2009 | link

Thank you for super awesome ticket!
Fix on ReviewBoard: http://reviewboard.liftweb.net/r/90/

Comment
Thank you for super awesome ticket! Fix on ReviewBoard: http://reviewboard.liftweb.net/r/90/
or cancel

indrajitr Wed Nov 11 05:22:58 -0800 2009 | link

• Update hibernate-entitymanager to 3.4.0.GA
• Add slf4j-simple as runtime dependency as expected by hibernate-entitymanager
• Closed by 1b8340e

Comment
- Update hibernate-entitymanager to 3.4.0.GA - Add slf4j-simple as runtime dependency as expected by hibernate-entitymanager - Closed by 1b8340e1d01b8ba88692583cb09a661ae286bc3c
or cancel

Parsed with GitHub Flavored Markdown

154.

0 votes

dpp

x

Mapper's view bounds and conversions to Unit don't mix

1 comment Created about 1 month ago by dpp

Title

Body
MappedField's apply methods take view bounds. This causes a nasty interaction with Scala's mechanism for converting to Unit. So: val u: Unit = myModel.myForiegnKeyField(1L) // causes problems Fix: concrete apply method without view bound conversion.
or cancel

MappedField's apply methods take view bounds. This causes a nasty interaction with Scala's mechanism for converting to Unit. So:

val u: Unit = myModel.myForiegnKeyField(1L) // causes problems

Fix: concrete apply method without view bound conversion.

Comments

dpp Tue Nov 17 06:14:02 -0800 2009 | link

Added concrete setter methods

Comment
Added concrete setter methods
or cancel

Parsed with GitHub Flavored Markdown

153.

0 votes

aboisvert

x

Please update documentation for Msgs

2 comments Created 2 months ago by awhitford

Title

Body
Looking at: http://github.com/dpp/liftweb/blob/master/lift-base/lift-webkit/src/main/scala/net/liftweb/builtin/snippet/Msgs.scala The documentation suggests that certain elements (like error_class) can be overridden. But I did it using: <lift:Msgs> <lift:error_class>errorBox</lift:error_class> </lift:Msgs> I'm guessing that the <lift:snippet type="error_report"> is dated?
or cancel

Looking at: http://github.com/dpp/liftweb/blob/master/lift-base/lift-webkit/src/main/scala/net/liftweb/builtin/snippet/Msgs.scala

The documentation suggests that certain elements (like error_class) can be overridden. But I did it using:

<lift:Msgs>
    <lift:error_class>errorBox</lift:error_class>
</lift:Msgs>

I'm guessing that the <lift:snippet type="error_report"> is dated?

Comments

awhitford Sat Oct 31 11:08:27 -0700 2009 | link

P.S. I was really trying to add a class to the <ul> elements (because I am trying to work around an iWebKit bug). Unfortunately, that doesn't look possible.

Comment
P.S. I was really trying to add a class to the &lt;ul&gt; elements (because I am trying to work around an iWebKit bug). Unfortunately, that doesn't look possible.
or cancel

aboisvert Thu Nov 12 15:53:02 -0800 2009 | link

Ok, fixed the scaladoc. Thanks for reporting!

I'm afraid there's no (direct) wait to set a class on the

elements at this time, unless you want to use nested snippets to rewrite the HTML output and add the class attributes.

Comment
Ok, fixed the scaladoc. Thanks for reporting! I'm afraid there's no (direct) wait to set a class on the <ul> elements at this time, unless you want to use nested snippets to rewrite the HTML output and add the class attributes.
or cancel

Parsed with GitHub Flavored Markdown

152.

0 votes

dpp

x

ajax-loader not showing during ajax requests

1 comment Created 2 months ago by jeppenejsum

Title

Body
Details here: http://groups.google.com/group/liftweb/browse_thread/thread/bfc7da05da6a4ec2
or cancel

Details here: http://groups.google.com/group/liftweb/browse_thread/thread/bfc7da05da6a4ec2

Comments

dpp Thu Nov 05 13:11:48 -0800 2009 | link

Fixed in M7

Comment
Fixed in M7
or cancel

Parsed with GitHub Flavored Markdown

151.

0 votes

dpp

x

Work In Progress

x

Mapper MySQLSyntaxErrorException (related to issue #145)

1 comment Created 2 months ago by econoplas

Title

Body
Sorry, unfortunately after issue # 145 fix... I think we have a different kind of breakage now... Message: com.mysql.jdbc.exceptions.MySQLSyntaxErrorException: Unknown column 'project_type.val5' in 'field list' com.mysql.jdbc.SQLError.createSQLException(SQLError.java:936) com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:2985) com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:1631) com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:1723) com.mysql.jdbc.Connection.execSQL(Connection.java:3283) com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1332) com.mysql.jdbc.PreparedStatement.executeQuery(PreparedStatement.java:1467) net.liftweb.mapper.DB$$anonfun$exec$3.apply(DB.scala:323) net.liftweb.mapper.DB$$anonfun$exec$3.apply(DB.scala:322) net.liftweb.util.TimeHelpers$class.calcTime(TimeHelpers.scala:242) net.liftweb.util.Helpers$.calcTime(Helpers.scala:30) net.liftweb.mapper.DB$.exec(DB.scala:322) net.liftweb.mapper.MetaMapper$$anonfun$findMapFieldDb$1$$anonfun$apply$9.apply(MetaMapper.scala:334) net.liftweb.mapper.MetaMapper$$anonfun$findMapFieldDb$1$$anonfun$apply$9.apply(MetaMapper.scala:332) net.liftweb.mapper.DB$.runPreparedStatement(DB.scala:405) I think this happens because my database server (MySQL 5) is case sensitive for column and table names by default, and in this case my table & column name is actually PROJECT_TYPE.val5. I think we probably always want to preserve the original case of the overridden dbTableName and dbColumnName in SQL statements that you generate so the user can always override & get the right behavior in the resulting SQL. I think your fix is on the right track though. You probably want to lookup column names using case sensitive search first, then case insensitive search, using an algorithm similar to the following very hackerish pseudo-code (my apologies): colIndex = findColIndex(colName, columns.fieldName for all prepStmt.columns) orElse findColIndex(colName.lower, columns.fieldName.lower for all prepStmt.columns) orElse -1 value = columns(colIndex) Which would find an exact case match first (for those databases that allow a user to have MyCol1 and mycol1 both in the same table), and then fallback to a case insensitive match, and if that failed... throw some sort of column not found exception or return a null. I may be way off base, and if so feel free to ignore the suggestion if that leads us on another goose chase. Thanks, Troy
or cancel

Sorry, unfortunately after issue # 145 fix... I think we have a different kind of breakage now...

Message: com.mysql.jdbc.exceptions.MySQLSyntaxErrorException: Unknown column 'project_type.val5' in 'field list'

com.mysql.jdbc.SQLError.createSQLException(SQLError.java:936)

com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:2985)
com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:1631)
com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:1723)
com.mysql.jdbc.Connection.execSQL(Connection.java:3283)

com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1332)
com.mysql.jdbc.PreparedStatement.executeQuery(PreparedStatement.java:1467)
net.liftweb.mapper.DB$$anonfun$exec$3.apply(DB.scala:323)

net.liftweb.mapper.DB$$anonfun$exec$3.apply(DB.scala:322)
net.liftweb.util.TimeHelpers$class.calcTime(TimeHelpers.scala:242)
net.liftweb.util.Helpers$.calcTime(Helpers.scala:30)
net.liftweb.mapper.DB$.exec(DB.scala:322)

net.liftweb.mapper.MetaMapper$$anonfun$findMapFieldDb$1$$anonfun$apply$9.apply(MetaMapper.scala:334)

net.liftweb.mapper.MetaMapper$$anonfun$findMapFieldDb$1$$anonfun$apply$9.apply(MetaMapper.scala:332)
net.liftweb.mapper.DB$.runPreparedStatement(DB.scala:405)

I think this happens because my database server (MySQL 5) is case sensitive for column and table names by default, and in this case my table & column name is actually PROJECT_TYPE.val5.

I think we probably always want to preserve the original case of the overridden dbTableName and dbColumnName in SQL statements that you generate so the user can always override & get the right behavior in the resulting SQL.

I think your fix is on the right track though. You probably want to lookup column names using case sensitive search first, then case insensitive search, using an algorithm similar to the following very hackerish pseudo-code (my apologies):

colIndex = findColIndex(colName, columns.fieldName for all prepStmt.columns)
        orElse findColIndex(colName.lower, columns.fieldName.lower for all prepStmt.columns)
        orElse -1
value = columns(colIndex)

Which would find an exact case match first (for those databases that allow a user to have MyCol1 and mycol1 both in the same table), and then fallback to a case insensitive match, and if that failed... throw some sort of column not found exception or return a null.

I may be way off base, and if so feel free to ignore the suggestion if that leads us on another goose chase.

Thanks, Troy

Comments

dpp Mon Nov 02 10:34:27 -0800 2009 | link

Extensive tests for mixed case in queries. Closed by b55bdc6

Comment
Extensive tests for mixed case in queries. Closed by b55bdc69b32b9494c7548a7bda942806081e8ea3
or cancel

Parsed with GitHub Flavored Markdown

150.

0 votes

dpp

x

On Review Board

x

Connections never take from pool

1 comment Created 2 months ago by dpp

Title

Body
http://github.com/dpp/liftweb/issues/closed/#issue/124
or cancel

http://github.com/dpp/liftweb/issues/closed/#issue/124

Comments

dpp Mon Nov 02 10:44:36 -0800 2009 | link

connections removed from pool. closed by 4ab9484

Comment
connections removed from pool. closed by 4ab94846533e4b2743eac6c5aa9ee59b5321130b
or cancel

Parsed with GitHub Flavored Markdown