.gitignore @@ -2,7 +2,7 @@ CommaParser =========== This plugin allows you to accept commas from users for integer fields in -an ActiveRecord model. +an ActiveRecord model. It requires Rails 2.1 or higher. Example README @@ -1,11 +1,12 @@ module CommaParser - module SingletonMethods + module ParserMethods def allow_commas(*args) before_validation :strip_commas type_cast_array = [] args.each do |arg| + type_cast_array << "#{arg}_will_change!" type_cast_array << "#{arg}_before_type_cast.to_s.tr!(',', '').to_i" end @@ -20,4 +21,4 @@ module CommaParser end end -ActiveRecord::Base.extend CommaParser::SingletonMethods +ActiveRecord::Base.extend CommaParser::ParserMethods lib/comma_parser.rb @@ -15,21 +15,30 @@ class CommaParserTest < Test::Unit::TestCase @country.population = "1,000,000" @country.gross_domestic_product = "5,000,000" @country.save - assert_equal 1000000, @country.population - assert_equal 5000000, @country.gross_domestic_product + @country.reload + assert_equal 1_000_000, @country.population + assert_equal 5_000_000, @country.gross_domestic_product end def test_numbers_are_still_saved_correctly - @country.population = 1000000 - @country.gross_domestic_product = 5000000 + @country.population = 2_000_000 + @country.gross_domestic_product = 10_000_000 @country.save - assert_equal 1000000, @country.population - assert_equal 5000000, @country.gross_domestic_product + @country.reload + assert_equal 2_000_000, @country.population + assert_equal 10_000_000, @country.gross_domestic_product + @person.year_end_bonus = "500" + @person.save + @person.reload + assert_equal 500, @person.year_end_bonus end def test_commas_are_not_parsed_without_allow_commas @person.annual_income = "50,000" + @person.year_end_bonus = "1,000" @person.save + @person.reload assert_equal 50, @person.annual_income + assert_equal 1, @person.year_end_bonus end end test/comma_parser_test.rb @@ -12,6 +12,7 @@ ActiveRecord::Schema.define :version => 0 do t.column :first_name, :string, :limit => 25 t.column :last_name, :string, :limit => 25 t.column :annual_income, :integer + t.column :year_end_bonus, :integer t.column :created_at, :datetime t.column :updated_at, :datetime end test/schema.rb test/debug.log 821a17215228ab6f9c8397e006a354bfeb514e7b Doug Ramsay doug@intridea.com http://github.com/dramsay/comma_parser/commit/5ecfd656b88aed47fea3bcee233fe76cb555904e 5ecfd656b88aed47fea3bcee233fe76cb555904e 2008-10-06T13:17:08-07:00 2008-10-06T13:17:08-07:00 Forcing Rails to recognize that attribute has been changed - otherwise in Rails 2.1 it won't be sent to database cfdfca17e318b228e43d67644d24fcd63111548f Doug Ramsay doug@intridea.com