BZ-1063469: use try/catch/finally on IOService batch processing

kiegroup · Feb 10, 2014 · fdfc336 · fdfc336
1 parent ebed19c
commit fdfc336
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 26 deletions.
diff --git a/...g/kie/workbench/common/screens/projecteditor/backend/server/ProjectScreenServiceImpl.java b/...g/kie/workbench/common/screens/projecteditor/backend/server/ProjectScreenServiceImpl.java
@@ -4,8 +4,6 @@
 import javax.inject.Inject;
 import javax.inject.Named;
 
-import org.apache.commons.lang.StringUtils;
-import org.guvnor.common.services.project.backend.server.utils.IdentifierUtils;
 import org.guvnor.common.services.project.model.POM;
 import org.guvnor.common.services.project.model.Project;
 import org.guvnor.common.services.project.service.KModuleService;
@@ -77,21 +75,25 @@ public void save( final Path pathToPomXML,
                       final String comment ) {
         final Project project = projectService.resolveProject( pathToPomXML );
 
-        ioService.startBatch();
-        pomService.save( pathToPomXML,
-                         model.getPOM(),
-                         model.getPOMMetaData(),
-                         comment );
-        kModuleService.save( project.getKModuleXMLPath(),
-                             model.getKModule(),
-                             model.getKModuleMetaData(),
+        try {
+            ioService.startBatch();
+            pomService.save( pathToPomXML,
+                             model.getPOM(),
+                             model.getPOMMetaData(),
                              comment );
-        projectService.save( project.getImportsPath(),
-                             model.getProjectImports(),
-                             model.getProjectImportsMetaData(),
-                             comment );
-        ioService.endBatch();
-
+            kModuleService.save( project.getKModuleXMLPath(),
+                                 model.getKModule(),
+                                 model.getKModuleMetaData(),
+                                 comment );
+            projectService.save( project.getImportsPath(),
+                                 model.getProjectImports(),
+                                 model.getProjectImportsMetaData(),
+                                 comment );
+        } catch ( final Exception e ) {
+            throw new RuntimeException( e );
+        } finally {
+            ioService.endBatch();
+        }
     }
 
     @Override

diff --git a/...in/java/org/kie/workbench/common/screens/explorer/backend/server/ExplorerServiceImpl.java b/...in/java/org/kie/workbench/common/screens/explorer/backend/server/ExplorerServiceImpl.java
@@ -745,13 +745,12 @@ public void deleteItem( final FolderItem folderItem,
                                                                comment ),
                                           StandardDeleteOption.NON_EMPTY_DIRECTORIES );
             }
-
+        } catch ( final Exception e ) {
+            throw ExceptionUtilities.handleException( e );
+        } finally {
             if ( paths.size() > 1 ) {
                 ioService.endBatch();
             }
-
-        } catch ( final Exception e ) {
-            throw ExceptionUtilities.handleException( e );
         }
     }
 
@@ -797,11 +796,10 @@ public void renameItem( final FolderItem folderItem,
                     }
                 }
             }
-
-            ioService.endBatch();
-
         } catch ( final Exception e ) {
             throw ExceptionUtilities.handleException( e );
+        } finally {
+            ioService.endBatch();
         }
     }
 
@@ -847,11 +845,10 @@ public void copyItem( final FolderItem folderItem,
                     }
                 }
             }
-
-            ioService.endBatch();
-
         } catch ( final Exception e ) {
             throw ExceptionUtilities.handleException( e );
+        } finally {
+            ioService.endBatch();
         }
     }