Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message for Xarray pickling. #1472

Closed
19 tasks
DanielAdriaansen opened this issue Aug 25, 2020 · 1 comment
Closed
19 tasks

Add error message for Xarray pickling. #1472

DanielAdriaansen opened this issue Aug 25, 2020 · 1 comment
Assignees
Labels
MET: Python Embedding priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: bug Fix something that is not working

Comments

@DanielAdriaansen
Copy link
Contributor

DanielAdriaansen commented Aug 25, 2020

Describe the Problem

Here:

we exit(1) without printing an error message to the user! We should issue a bug fix to print an error message.

For met-10.0, we should implement support for Xarray Python embedding with pickling. That work is described in #1534 .

Expected Behavior

I expect a warning message instead of MET silently exiting and producing no output.

Environment

Describe your runtime environment:
*1. Machine: kiowa

To Reproduce

To force pickling, set the MET_PYTHON_EXE environment variable. This can be set to any version of Python I think, which just forces invocation of the pickling logic in MET which is necessary to reproduce the error.
export MET_PYTHON_EXE=/path/to/python

Call a test script I wrote for Xarray Python embedding
/usr/local/met-9.1/bin/plot_data_plane PYTHON_XARRAY testXR.ps 'name="/home/dadriaan/projects/remote/read_ascii_xarray.py /home/dadriaan/git/met/met/data/python/fcst.txt FCST";' -title "Testing" -v 10

Relevant Deadlines

NONE

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of master_<Version>.
    Branch name: bugfix_<Issue Number>_master_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into master_<Version> and link the pull request to this issue.
    Pull request: bugfix <Issue Number> master_<Version> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch and link the pull request to this issue.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
  • Close this issue.
@DanielAdriaansen DanielAdriaansen added type: bug Fix something that is not working type: enhancement Improve something that it is currently doing component: python interface priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Aug 25, 2020
@DanielAdriaansen DanielAdriaansen added this to the MET 9.1.1 (bugfix) milestone Aug 25, 2020
@DanielAdriaansen DanielAdriaansen added this to To do in MET-10.0.0-beta1 (10/22/20) via automation Aug 25, 2020
@JohnHalleyGotway JohnHalleyGotway added this to To do in METplus Version 3.1 Support via automation Aug 25, 2020
@JohnHalleyGotway JohnHalleyGotway changed the title Add error message for Xarray pickling, and complete support for Xarray pickling Add error message for Xarray pickling. Oct 21, 2020
@JohnHalleyGotway JohnHalleyGotway removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue type: enhancement Improve something that it is currently doing labels Oct 22, 2020
@JohnHalleyGotway JohnHalleyGotway moved this from To do to Done in METplus Version 3.1 Support Oct 22, 2020
@JohnHalleyGotway
Copy link
Collaborator

Committed minor tweaks to log messages in python_dataplane.cc directly to the main_v9.1 and develop branches. Note that this does not follow best practices of submitting PR's for code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Python Embedding priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: bug Fix something that is not working
Projects
No open projects
Development

No branches or pull requests

2 participants