Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GridDiag docs #1611

Closed
8 of 20 tasks
dwfncar opened this issue Dec 21, 2020 · 2 comments · Fixed by #1613
Closed
8 of 20 tasks

Update GridDiag docs #1611

dwfncar opened this issue Dec 21, 2020 · 2 comments · Fixed by #1613
Assignees
Labels
component: documentation Documentation issue priority: medium Medium Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: DTC/T&E General DTC Testing and Evaluation work type: task An actionable item of work
Milestone

Comments

@dwfncar
Copy link
Contributor

dwfncar commented Dec 21, 2020

Describe the Task

Update GridDiag documentation to clarify behavior when the
-data command line option is used twice.
e.g. -data fileA -data fileB.

Also confirm that the existing grid_diag unit tests include an example of using -data multiple times to specify different input datasets.

Time Estimate

4 hours.

Sub-Issues

Consider breaking the task down into sub-issues.
No sub-issues.

Relevant Deadlines

MET 10.0.0

Funding Source

None

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
    David Fillmore
  • Select scientist(s) or no scientist required
    None

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@dwfncar dwfncar added the type: task An actionable item of work label Dec 21, 2020
@dwfncar dwfncar added this to the MET 10.0.0 milestone Dec 21, 2020
@dwfncar dwfncar added this to To do in MET-10.0.0-beta3 (1/27/21) via automation Dec 21, 2020
@dwfncar dwfncar self-assigned this Dec 21, 2020
@dwfncar
Copy link
Contributor Author

dwfncar commented Dec 23, 2020

In a config data block with varA and varB.
-data fileA -data fileB can be used to have varA read from fileA and varB read from fileB.

@dwfncar dwfncar moved this from To do to Pull request review in MET-10.0.0-beta3 (1/27/21) Dec 23, 2020
@JohnHalleyGotway JohnHalleyGotway added component: documentation Documentation issue priority: medium Medium Priority requestor: DTC/T&E General DTC Testing and Evaluation work labels Dec 23, 2020
@JohnHalleyGotway JohnHalleyGotway linked a pull request Dec 23, 2020 that will close this issue
8 tasks
@dwfncar dwfncar moved this from Pull request review to Done in MET-10.0.0-beta3 (1/27/21) Dec 28, 2020
@dwfncar
Copy link
Contributor Author

dwfncar commented Dec 28, 2020

Merged to dev.

@dwfncar dwfncar closed this as completed Dec 28, 2020
@TaraJensen TaraJensen added the reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue priority: medium Medium Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: DTC/T&E General DTC Testing and Evaluation work type: task An actionable item of work
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants