@@ -41,12 +41,12 @@ Transmission.Remote = (function() {
});
};
- var torrentGet = function(args, callback) {
- rpc.bind(this)({ method: 'torrent-get', arguments: args }, callback);
+ var torrentGet = function(o, args, callback) {
+ rpc.bind(o)({ method: 'torrent-get', arguments: args }, callback);
};
var requestFields = function(ids, fields) {
- torrentGet.bind(this)({
+ torrentGet(this, {
ids: ids, fields: fields.concat('id')
}, function(args) {
var torrents_data = args.torrents;
@@ -90,7 +90,7 @@ Transmission.Remote = (function() {
this.dispatchEvent(event);
}.bind(this);
- torrentGet.bind(this)({ fields: [ 'id' ] }, callback);
+ torrentGet(this, { fields: [ 'id' ] }, callback);
};
var constructor = function(config) {
@@ -98,7 +98,7 @@ Transmission.Remote = (function() {
this.request_fields_groups = [];
};
- constructor.prototype = Transmission.extend(new Transmission.TorrentEventDispatcher(), {
+ constructor.prototype = Transmission.extend(Transmission.TorrentEventDispatcher.prototype, {
requestAllTorrentIds: requestAllTorrentIds,
requestFields: requestFields,
groupedRequestFields: groupedRequestFields
src/models/remote.js
@@ -25,6 +25,7 @@ return {
serverResponds('yada yada', 409),
successful_transport = new MockXmlHttpRequest().
+ setServerResponseHeader(Transmission.Remote.X_TRANSMISSION_SESSION_ID, transmission_session_id).
serverRespondsJSON({ arguments: { torrents: [ { id: 1 } ] }, result: 'success' }, 200);
jack.expect('Ajax.getTransport').exactly(2).returnValues(
@@ -156,7 +157,7 @@ return {
arguments: { torrents: [ fixtureTorrentData1 ] },
result: "success"
});
- jack.expect('Ajax.getTransport').exactly('2 times').returnValue(transport);
+ jack.expect('Ajax.getTransport').exactly(2).returnValue(transport);
remote.groupedRequestFields([ 1 ], requested_fields);
this.wait(1, function() {
test/unit/models/remote_test.js
0618812cfd8d8ed0e03ffabd8f277d013423465b
Duncan Beevers
duncanbeevers@gmail.com
http://github.com/duncanbeevers/transmission-web-ui/commit/80d421c5853099e063dfd1310f543abf5cb9ef09
80d421c5853099e063dfd1310f543abf5cb9ef09
2009-06-23T00:58:32-07:00
2009-06-23T00:58:32-07:00
Switch torrentGet signature to receive object to bind to as argument instead of binding twice
e9ccfcc5a7e1a63a1d253786352853a6ea117472
Duncan Beevers
duncanbeevers@gmail.com