Commit 0be1844a79e2d9ecd635e770faf479f3a221be87 to dustin's java-memcached-client

0be1844
all branches
- factory
- gh-pages
- gh-pages.lock
- master
- slab-reassign
- three
all tags
- 1.0.34
- 1.0.36
- 1.0.37
- 1.0.38
- 1.0.39
- 1.0.40
- 1.0.41
- 1.0.42
- 1.0.43
- 1.0.44
- 1.1
- 1.2
- 1.3
- 1.3.1
- 1.4
- 2.0
- 2.0-pre1
- 2.0-pre2
- 2.0-pre3
- 2.0-pre4
- 2.0-pre5
- 2.0-pre6
- 2.0-pre7
- 2.0-pre8
- 2.0-pre9
- 2.0.1
- 2.0.2
- 2.1
- 2.1rc1
- 2.1rc2
- 2.1rc3
- 2.2
- 2.2rc1
- 2.2rc2
- 2.3
- 2.3.1
- 2.3rc1
comments

dustin / java-memcached-client

Description:	A simple, asynchronous, single-threaded memcached client written in java. edit
Homepage:	http://code.google.com/p/spymemcached/ edit
Public Clone URL:	git://github.com/dustin/java-memcached-client.git Give this clone URL to anyone. `git clone git://github.com/dustin/java-memcached-client.git`
Your Clone URL:	git@github.com:dustin/java-memcached-client.git Use this clone URL yourself. `git clone git@github.com:dustin/java-memcached-client.git`

Read before writes and expect IllegalStateException.

These are two measures that are helping with the queue overflow
problems.

Firstly, the IllegalStateException is thrown whenever you attempted to
add to a queue that's full.  If that happens internally, I don't want
the IO thread to crash, so I add it to the normal ``expected
exceptions'' list.

Secondly, reading before writing helps keep the read buffer ready for
new data.  When writing first, the write will have to transition to a
read and may cause the read buffer to overflow.  It still may happen,
but by servicing the reads first I can at least get the complete ones
popped out before piling new ones in (since writes are almost always
smaller and likely to transition).

dustin (author)

Tue May 13 22:18:58 -0700 2008

commit 0be1844a79e2d9ecd635e770faf479f3a221be87
tree f17bbf319e48839119dfef8e39f58803338dbb87
parent 6a38bf7b3b190035e35133e8b08056ceb86d2eaf

src/main/java/net/spy/memcached/MemcachedClient.java
src/main/java/net/spy/memcached/MemcachedConnection.java

src/main/java/net/spy/memcached/MemcachedClient.java

0
@@ -1253,6 +1253,8 @@ public final class MemcachedClient extends SpyThread {
0
         logRunException(e);
0
       } catch(ClosedSelectorException e) {
0
         logRunException(e);
0
+      } catch(IllegalStateException e) {
0
+        logRunException(e);
0
       }
0
     }
0
     getLogger().info("Shut down memcached client");

src/main/java/net/spy/memcached/MemcachedConnection.java

0
@@ -258,12 +258,12 @@ public final class MemcachedConnection extends SpyObject {
0
           assert !channel.isConnected() : "connected";
0
         }
0
       } else {
0
-        if(sk.isWritable()) {
0
-          handleWrites(sk, qa);
0
-        }
0
         if(sk.isReadable()) {
0
           handleReads(sk, qa);
0
         }
0
+        if(sk.isWritable()) {
0
+          handleWrites(sk, qa);
0
+        }
0
       }
0
     } catch(Exception e) {
0
       // Various errors occur on Linux that wind up here.  However, any

Comments