0
@@ -41,8 +41,8 @@ public class BinaryConnectionFactory extends DefaultConnectionFactory {
0
   public MemcachedNode createMemcachedNode(SocketAddress sa,
0
       SocketChannel c, int bufSize) {
0
     return new BinaryMemcachedNodeImpl(sa, c, bufSize,
0
-      createOperationQueue(),
0
-      createOperationQueue(),
0
+      createReadOperationQueue(),
0
+      createWriteOperationQueue(),
0
       createOperationQueue());
0
   }
0
 

0
@@ -37,6 +37,19 @@ public interface ConnectionFactory {
0
   BlockingQueue<Operation> createOperationQueue();
0
 
0
   /**
0
+   * Create a BlockingQueue for the operations currently expecting to read
0
+   * responses from memcached.
0
+   */
0
+  BlockingQueue<Operation> createReadOperationQueue();
0
+
0
+  /**
0
+   * Create a BlockingQueue for the operations currently expecting to write
0
+   * requests to memcached.
0
+   */
0
+  BlockingQueue<Operation> createWriteOperationQueue();
0
+
0
+
0
+  /**
0
    * Create a NodeLocator instance for the given list of nodes.
0
    */
0
   NodeLocator createLocator(List<MemcachedNode> nodes);

0
@@ -18,7 +18,9 @@ import net.spy.memcached.protocol.ascii.AsciiOperationFactory;
0
  *
0
  * <p>
0
  * This implementation creates connections where each server worker queue is
0
- * implemented using an ArrayBlockingQueue.
0
+ * implemented using an ArrayBlockingQueue.  The read queue is automatically
0
+ * configured to be 10% larger than the specified op queue.  The write queue
0
+ * is and input queues are the same size.
0
  * </p>
0
  */
0
 public class DefaultConnectionFactory extends SpyObject
0
@@ -76,8 +78,8 @@ public class DefaultConnectionFactory extends SpyObject
0
   public MemcachedNode createMemcachedNode(SocketAddress sa,
0
       SocketChannel c, int bufSize) {
0
     return new AsciiMemcachedNodeImpl(sa, c, bufSize,
0
-        createOperationQueue(),
0
-        createOperationQueue(),
0
+        createReadOperationQueue(),
0
+        createWriteOperationQueue(),
0
         createOperationQueue());
0
   }
0
 
0
@@ -97,6 +99,21 @@ public class DefaultConnectionFactory extends SpyObject
0
   }
0
 
0
   /* (non-Javadoc)
0
+   * @see net.spy.memcached.ConnectionFactory#createReadOperationQueue()
0
+   */
0
+  public BlockingQueue<Operation> createReadOperationQueue() {
0
+    return new ArrayBlockingQueue<Operation>(
0
+      (int) (getOpQueueLen() * 1.1));
0
+  }
0
+
0
+  /* (non-Javadoc)
0
+   * @see net.spy.memcached.ConnectionFactory#createWriteOperationQueue()
0
+   */
0
+  public BlockingQueue<Operation> createWriteOperationQueue() {
0
+    return createOperationQueue();
0
+  }
0
+
0
+  /* (non-Javadoc)
0
    * @see net.spy.memcached.ConnectionFactory#createLocator(java.util.List)
0
    */
0
   public NodeLocator createLocator(List<MemcachedNode> nodes) {

0
@@ -20,4 +20,11 @@ public class ConnectionFactoryTest extends TestCase {
0
   public void testBinaryAnIntAnotherIntAndAHashAlgorithmCons() {
0
     new BinaryConnectionFactory(5, 5, HashAlgorithm.FNV1_64_HASH);
0
   }
0
+
0
+  public void testQueueSizes() {
0
+    ConnectionFactory cf=new DefaultConnectionFactory(100, 1024);
0
+    assertEquals(100, cf.createOperationQueue().remainingCapacity());
0
+    assertEquals(100, cf.createWriteOperationQueue().remainingCapacity());
0
+    assertEquals(110, cf.createReadOperationQueue().remainingCapacity());
0
+  }
0
 }