@@ -65,6 +65,11 @@ public class CASMutator<T> extends SpyObject { /** * CAS a new value in for a key. * + * <p> + * Note that if initial is null, this method will only update existing + * values. + * </p> + * * @param key the key to be CASed * @param initial the value to use when the object is not cached * @param initialExp the expiration time to use when initializing @@ -106,7 +111,10 @@ public class CASMutator<T> extends SpyObject { } } else { // No value found, try an add. - if(client.add(key, initialExp, initial, transcoder).get()) { + if(initial == null) { + done = true; + rv = null; + } else if(client.add(key, initialExp, initial, transcoder).get()) { done=true; rv=initial; } src/main/java/net/spy/memcached/CASMutator.java @@ -49,6 +49,19 @@ public class CASMutatorTest extends ClientBaseCase { } } + public void testCASUpdateWithNullInitial() throws Throwable { + client.set("x", 0, 1L); + Long rv=mutator.cas("x", (Long)null, 0, mutation); + assertEquals(rv, (Long)2L); + } + + public void testCASUpdateWithNullInitialNoExistingVal() throws Throwable { + assertNull(client.get("x")); + Long rv=mutator.cas("x", (Long)null, 0, mutation); + assertNull(rv); + assertNull(client.get("x")); + } + public void testCASValueToString() { CASValue<String> c=new CASValue<String>(717L, "hi"); assertEquals("{CasValue 717/hi}", c.toString()); src/test/java/net/spy/memcached/CASMutatorTest.java 4999cc49c3c37aa4d3eac9b4cb2134dc45df7862 Dustin Sallings dustin@spy.net http://github.com/dustin/java-memcached-client/commit/b634d0ae546a299bb570d8877434261ba32f76a7 b634d0ae546a299bb570d8877434261ba32f76a7 2009-06-20T18:43:11-07:00 2009-06-20T18:41:54-07:00 Allow CAS Mutator to work in a mutation-only mode. When initial is null, do not initialize the value. 8a965a92a1e95e547368153ede4ee9409f60e98d Dustin Sallings dustin@spy.net