09aa9d3c6fd365c80a262320c26f553138f0ac0d Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/836e5fde57b160024e31de02c5f1872b6fdc8659 836e5fde57b160024e31de02c5f1872b6fdc8659 2009-09-10T15:03:33-07:00 2009-09-10T15:03:33-07:00 Kill off redundant item_init. These are automatically initialized to 0 (both Trond and the spec says so, and I asserted it on all current builders at least once before killing it off). fd9b27c147459ed748d2afb9c5a86ba95879adb7 Dustin Sallings dustin@spy.net 8f488c65dbdd7b958044629330aa7da63728649f Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/09aa9d3c6fd365c80a262320c26f553138f0ac0d 09aa9d3c6fd365c80a262320c26f553138f0ac0d 2009-09-04T23:08:58-07:00 2009-06-22T00:23:48-07:00 Kill off redundant and incorrect sizing definition. It seems that in investigating the fencepost issue (issue59), it was revealed that the 255 value of LARGEST_ID was well beyond what was ever possible to be referenced. As actual value was limited to the POWER_LARGEST definition in practice, I have LARGEST_ID use POWER_LARGEST to define itself. ec139e6fef057abbc5a5d87f3979f4b5fdfbd7eb Dustin Sallings dustin@spy.net 52f16b3e0756c7cdf618a28dadb24eb5e5f58d7b Mat Hostetter mjhostetter@gmail.com http://github.com/dustin/memcached/commit/8f488c65dbdd7b958044629330aa7da63728649f 8f488c65dbdd7b958044629330aa7da63728649f 2009-09-04T23:08:58-07:00 2009-06-22T00:06:58-07:00 Clean up slab boundary checking. http://groups.google.com/group/memcached/browse_thread/thread/45b70cced2c4bd32 In items.c in memcached-1.2.8, these arrays allow indices up to but not including LARGEST_ID: ... static item *heads[LARGEST_ID]; static item *tails[LARGEST_ID]; So this comment (which appears twice) is confused: /* always true, warns: assert(it->slabs_clsid <= LARGEST_ID); */ The assert should be checking for clsid < LARGEST_ID, not <=. And then the warning would go away. Or was the intent always to have 256 entries in the arrays, not 255? Similarly, this code in items.c should be checking >=, not >, as heads[LARGEST_ID] would be out-of-bounds: if (slabs_clsid > LARGEST_ID) return NULL; it = heads[slabs_clsid]; IMHO the confusion stems from the fact that LARGEST_ID is not itself a valid id, as the name seems to imply. 0e851c850e5c3c9c6afe8a0da47d1c24597d6b52 Dustin Sallings dustin@spy.net 6ae66c84ecac2be85f5cbead57c5d9fd7d373974 Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/52f16b3e0756c7cdf618a28dadb24eb5e5f58d7b 52f16b3e0756c7cdf618a28dadb24eb5e5f58d7b 2009-09-02T16:08:18-07:00 2009-09-02T14:23:57-07:00 binary set with cas does not return the new cas id (dustin) I updated the perl test to check for this when it's doing CAS stuff. Found some bugs in the perl test that took too long to fix. ff66b0161f6e3f9e4c744303676718b1e59703a9 Dustin Sallings dustin@spy.net 23c6f665db78f17ff850c98f447f8c2dc0514cd1 Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/6ae66c84ecac2be85f5cbead57c5d9fd7d373974 6ae66c84ecac2be85f5cbead57c5d9fd7d373974 2009-09-02T16:08:08-07:00 2009-08-27T06:30:38-07:00 Add more tests on the binary protocol 0ca98d8edae73dc54e9626e35abf5a0f0dae6e92 Dustin Sallings dustin@spy.net 8cb285bc7eba95cdd3ad23d749bef2bc8c01d9d7 Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/23c6f665db78f17ff850c98f447f8c2dc0514cd1 23c6f665db78f17ff850c98f447f8c2dc0514cd1 2009-09-02T16:08:07-07:00 2009-08-27T06:24:37-07:00 Print an error message when we receive an invalid command in the binary protocol 32a0a41f3d154bf37f9f046038c12c47753f14d2 Dustin Sallings dustin@spy.net 9791b7794e5439baaced1fd4afa26e09f33cfc36 Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/8cb285bc7eba95cdd3ad23d749bef2bc8c01d9d7 8cb285bc7eba95cdd3ad23d749bef2bc8c01d9d7 2009-09-02T16:08:07-07:00 2009-08-27T06:22:49-07:00 Print a message on stderr when the timeout occurs d90d98ead33116c49308f002563e7b29c7a04c4d Dustin Sallings dustin@spy.net f9bc2b11edf151ce4b33efbe011bd807f14180ca Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/9791b7794e5439baaced1fd4afa26e09f33cfc36 9791b7794e5439baaced1fd4afa26e09f33cfc36 2009-09-02T16:08:07-07:00 2009-08-26T14:44:30-07:00 Issue: #83: Refactor: use htonll or ntohll if the os provides them 65b2efb41ec41a3bfe98ed970ee183e6cba76cf8 Dustin Sallings dustin@spy.net c6f208712a90e07ef502ab46c59ede40d75fa8ea Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/f9bc2b11edf151ce4b33efbe011bd807f14180ca f9bc2b11edf151ce4b33efbe011bd807f14180ca 2009-09-02T14:57:09-07:00 2009-09-02T14:57:09-07:00 Test for binary set/add returning CAS value. 59512b33610f25d21073239f79a7bebe7c59635b Dustin Sallings dustin@spy.net a24b1b17a3b0cb426ab640c4a5f29f10a332617e Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/c6f208712a90e07ef502ab46c59ede40d75fa8ea c6f208712a90e07ef502ab46c59ede40d75fa8ea 2009-09-01T13:42:22-07:00 2009-09-01T13:42:22-07:00 Fix reference to memcached.spec.in in whitespace test. 3871fc09fd58af4a6e85b25271e0dcfe70faf342 Dustin Sallings dustin@spy.net 0bc6f264f46fdc6e9892ebf0df7c3ce9b1a6e61f Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/a24b1b17a3b0cb426ab640c4a5f29f10a332617e a24b1b17a3b0cb426ab640c4a5f29f10a332617e 2009-08-29T16:36:12-07:00 2009-08-26T14:51:21-07:00 Issue 84: binary quitq doesn't close the connection... Update (dustin): I wrote the test for this condition and verified nastiness occurred under master. 4710747b39bf3671279b1b726c529642d7e1e08b Dustin Sallings dustin@spy.net 9a0357e9253361edbc319fe7f32c08a5cd02c1c7 James Cohen james.cohen@gmail.com http://github.com/dustin/memcached/commit/0bc6f264f46fdc6e9892ebf0df7c3ce9b1a6e61f 0bc6f264f46fdc6e9892ebf0df7c3ce9b1a6e61f 2009-08-29T15:34:13-07:00 2009-08-23T15:46:19-07:00 Track files in the include directory in the rpm spec. 7c2cca44b083089374a452e26e6934c8bc291d96 dormando dormando@rydia.net 4f5679356a2f98ffeb905840f28b2bc5a1498293 Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/9a0357e9253361edbc319fe7f32c08a5cd02c1c7 9a0357e9253361edbc319fe7f32c08a5cd02c1c7 2009-08-29T15:34:07-07:00 2009-08-23T15:23:09-07:00 Deal with C tests running as root. 8a102d7c56929066268d5a4539508a87676a5e6d dormando dormando@rydia.net 483e82adc89c984cbe040857d9cf43fc725883cd Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/4f5679356a2f98ffeb905840f28b2bc5a1498293 4f5679356a2f98ffeb905840f28b2bc5a1498293 2009-08-29T15:34:00-07:00 2009-08-23T01:01:50-07:00 Generate the memcached.spec along with the version number. 3d5c5c31c55c04ac5d0b56b37550595ad5715fe9 dormando dormando@rydia.net 18e75bdc19992c846f96f688297ca9904de37379 dormando dormando@rydia.net http://github.com/dustin/memcached/commit/483e82adc89c984cbe040857d9cf43fc725883cd 483e82adc89c984cbe040857d9cf43fc725883cd 2009-08-26T02:51:06-07:00 2009-08-26T02:36:14-07:00 Fix memory corruption issue with bad item lengths Partially fixed in 1.2.8, unfixed somewhere since, now fully fixed. Negative values allowed memory corruption, and high values also allowed corruption in swallow mode. Length is now guaranteed to be positive. Fixes issue 70. 41d96327e1c0109536d16397d5aba02f5dcd7e66 Trond Norbye Trond.Norbye@sun.com ca51c3d4e8fbbed8563b8e789537435d1ec973d5 dormando dormando@rydia.net http://github.com/dustin/memcached/commit/18e75bdc19992c846f96f688297ca9904de37379 18e75bdc19992c846f96f688297ca9904de37379 2009-08-25T00:19:12-07:00 2009-08-25T00:19:12-07:00 Documented mem_requested stat 65cff8939d1570b5fef0988a74a02038312c653d Dustin Sallings dustin@spy.net b939a46b0b9415487494410745adc5508a5a2aca Mat Hostetter mjhostetter@gmail.com http://github.com/dustin/memcached/commit/ca51c3d4e8fbbed8563b8e789537435d1ec973d5 ca51c3d4e8fbbed8563b8e789537435d1ec973d5 2009-08-23T12:39:52-07:00 2009-08-23T12:38:29-07:00 Fix caching of alignment requirement detection. FWIW I previously sent a patch against 1.4.0 to fix incorrect reuse of the ac_cv_c_endian variable in configure.ac. If reconfiguring with cached results from a previous configure, that bug would cause you to get a messed up configuration that was neither ENDIAN_BIG nor ENDIAN_LITTLE, because, on platforms that need alignment, ac_cv_c_endian gets cached as "need" instead of "big" or "little". be676d4e915cc97b6a9b7273aaec2eed2d234097 Dustin Sallings dustin@spy.net 89d5126bdb65fa9bcc945dd77fdf71261becd72e Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/b939a46b0b9415487494410745adc5508a5a2aca b939a46b0b9415487494410745adc5508a5a2aca 2009-08-23T00:44:22-07:00 2009-08-23T00:44:22-07:00 Clarify documentation about quiet mutation commands (issue 80). d7af700a8b973e075f05f7e66802ca47ce64cd02 Dustin Sallings dustin@spy.net b416a193b56e597bc94955cb19f562f94f31e972 Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/89d5126bdb65fa9bcc945dd77fdf71261becd72e 89d5126bdb65fa9bcc945dd77fdf71261becd72e 2009-08-22T23:38:12-07:00 2009-08-20T23:37:57-07:00 Issue #77: Bug in the realloc code caused the previous allocated buffer to be reused... 4f67eb78d5e3b4da98ab2ea708746e5322d62844 Dustin Sallings dustin@spy.net 3fa313718559d7bb044511e4c8c5094d44bf0818 Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/b416a193b56e597bc94955cb19f562f94f31e972 b416a193b56e597bc94955cb19f562f94f31e972 2009-08-22T23:38:12-07:00 2009-08-20T23:35:58-07:00 Use -pthread when compiling threaded code with gcc 81e8b80ea3c160acbf1330fc6c2bb0588667e490 Dustin Sallings dustin@spy.net d747f593606d61e3bd60cb6ebb0144b05edb41cb Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/3fa313718559d7bb044511e4c8c5094d44bf0818 3fa313718559d7bb044511e4c8c5094d44bf0818 2009-08-22T23:38:12-07:00 2009-08-20T10:56:51-07:00 Remove compilation errors from gcc on Solaris ed8e461cf4b1b6d106588152319fdb0a5fd5bbfb Dustin Sallings dustin@spy.net f46e5e0f02bfebae8c87b2a462a59413d6507c14 Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/d747f593606d61e3bd60cb6ebb0144b05edb41cb d747f593606d61e3bd60cb6ebb0144b05edb41cb 2009-08-22T23:38:12-07:00 2009-08-22T23:17:17-07:00 Configure fix for CC that's not in path. 0daada32588e2255bb18c137758651215ae1e1e3 Dustin Sallings dustin@spy.net 1f8e86d1db1af7221f46f4c99e5216147116a2fa Matt Ingenthron ingenthr@cep.net http://github.com/dustin/memcached/commit/f46e5e0f02bfebae8c87b2a462a59413d6507c14 f46e5e0f02bfebae8c87b2a462a59413d6507c14 2009-08-19T23:40:56-07:00 2009-08-19T15:53:11-07:00 Updated documentation comments for DTrace probes. The DTrace probes were not very clear about return type, so that was fixed. While in there, I also fixed some typos/English things. ada567f51bbb47f1dbd300a785096cca68c12753 Dustin Sallings dustin@spy.net 88a68689e4503a1c919f36fbc588b32fb6a5a12b Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/1f8e86d1db1af7221f46f4c99e5216147116a2fa 1f8e86d1db1af7221f46f4c99e5216147116a2fa 2009-08-19T18:24:01-07:00 2009-08-19T18:19:55-07:00 Issue #79: buffer overrun in stats_prefix_find 1e69443e09171cebd1a6a496e768e16b8674c0ae Dustin Sallings dustin@spy.net f5c6053b7d57c523225b8c474485a9e5ebd5bf1f Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/88a68689e4503a1c919f36fbc588b32fb6a5a12b 88a68689e4503a1c919f36fbc588b32fb6a5a12b 2009-08-19T15:43:39-07:00 2009-08-19T15:25:13-07:00 Clean up some assumed buffer sizes with stats (issue 64). 207adbffae33e23f1d7872e355f6a88e7497b8b0 Trond Norbye Trond.Norbye@sun.com 0fd0bc18df57a40ed8a5de59c8090a3c0f7a7cd2 Monty Taylor mordred@inaugust.com http://github.com/dustin/memcached/commit/f5c6053b7d57c523225b8c474485a9e5ebd5bf1f f5c6053b7d57c523225b8c474485a9e5ebd5bf1f 2009-08-19T15:38:59-07:00 2009-08-19T15:35:19-07:00 Man page was not properly escaping -. issue 53 Working on updating the deb for memcached, hit this lintian warning: http://lintian.debian.org/tags/hyphen-used-as-minus-sign.html The fix is a simple patch to escape the minus signs in the code with a backslash when they are referring to command line arguments. 1d889d49d9eba61538da47406f5b6b60a7172c5a Dustin Sallings dustin@spy.net 7a82822b2b991791b97441b6daec6d25e9b08238 Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/0fd0bc18df57a40ed8a5de59c8090a3c0f7a7cd2 0fd0bc18df57a40ed8a5de59c8090a3c0f7a7cd2 2009-08-19T15:08:53-07:00 2009-08-19T15:08:53-07:00 Replace an sprintf with an snprintf and avoid a strlen. This is part of issue 64. d91ce720f6ab038b8aed548af6aa6f518d71ac66 Dustin Sallings dustin@spy.net e4d074e89b7f65b572290a91405ca21ab006ebdd Trond Norbye Trond.Norbye@sun.com http://github.com/dustin/memcached/commit/7a82822b2b991791b97441b6daec6d25e9b08238 7a82822b2b991791b97441b6daec6d25e9b08238 2009-08-19T14:51:18-07:00 2009-04-07T16:47:29-07:00 Issue 42: Stats slabs should include the number of requested bytes cac38f5f06a602b18cbebab99db99a7b6cd118de Dustin Sallings dustin@spy.net 3635549e07b9cdf8ed636add0a7a2ac33b09cad5 Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/e4d074e89b7f65b572290a91405ca21ab006ebdd e4d074e89b7f65b572290a91405ca21ab006ebdd 2009-08-19T12:31:04-07:00 2009-08-15T01:31:29-07:00 Error check socket sends in the binary test. acb758f8578184f124af6d2af0eabec9a71a7a26 Trond Norbye Trond.Norbye@sun.com 891082f349304fb802c3df7491e337b47771eab1 Dustin Sallings dustin@spy.net http://github.com/dustin/memcached/commit/3635549e07b9cdf8ed636add0a7a2ac33b09cad5 3635549e07b9cdf8ed636add0a7a2ac33b09cad5 2009-08-19T12:29:39-07:00 2009-07-14T23:28:42-07:00 Use vperror for perror with context (issue 63). 555b27488f1ae8174fda7d1d544c9f111c8cc4c3 Trond Norbye Trond.Norbye@sun.com