GitHub Sale: sign up for any paid plan this week and pay nothing until January 1, 2009!  [ hide ]

public
Rubygem
Description: Resource-oriented open source Ruby framework for Web apps.
Homepage: http://rubywaves.com/
Clone URL: git://github.com/dyoder/waves.git

Comments for dyoder's waves   feed

automatthew commented on dyoder/waves Mon Nov 03 05:47:28 -0800 2008
Comment in 2063205:

Not confusing people is a win.

automatthew commented on dyoder/waves Fri Sep 26 18:45:48 -0700 2008
Comment on lib/runtime/runtime.rb L13 in 0c8a399:

The reason I had a definition in Waves.mode, instead of delegating to the runtime, is that it makes unit testing very painful. You couldn’t get an instance of Waves::Request, for example, without having a runtime loaded or stubbed.

ab5tract commented on dyoder/waves Mon Sep 22 11:16:00 -0700 2008
Comment in 1e0be87:

nice :)

automatthew commented on dyoder/waves Sat Sep 20 17:50:04 -0700 2008
Comment in 4ccf0f8:

Are we just going to "borrow" the mime-types hash from Mongrel?

automatthew commented on dyoder/waves Fri Aug 29 07:27:43 -0700 2008
Comment in a37e5ca:

Ah, 0e82fb must be on a different branch.

automatthew commented on dyoder/waves Fri Aug 29 07:25:58 -0700 2008
Comment in a37e5ca:

The change to the pattern_matching spec is a regression, and the change to Views::Mixin appears to be a dupe of 0e82fb.
This may be a case for git-revert.

automatthew commented on dyoder/waves Sun Aug 24 15:22:02 -0700 2008
Comment in 7b573cd:

That is some very fine tuning.

automatthew commented on dyoder/waves Tue Jul 22 18:24:15 -0700 2008
Comment in 01c32d4:

What do we do about Waves::Application.instance ?

automatthew commented on dyoder/waves Sun Jun 15 18:16:41 -0700 2008
Comment in f7087c5:

Sorry I didn’t give you better warning, as I have no desire to even appear to be stepping on people’s toes. I noted briefly my intent in an earlier commit, but not on the first line, so it’s likely buried.
I think these kind of helpers should go in a layer anyway. Even if they get included in the Default foundation, we can allow for swappability. This seems like an opportune time to start a waves-more project on github.

psq commented on dyoder/waves Sun Jun 15 17:25:19 -0700 2008
Comment in f7087c5:

Makes sense. Most of them are either cherry picked from rails, or simplifications of the existing ones

automatthew commented on dyoder/waves Sun Jun 15 07:57:07 -0700 2008
Comment in f7087c5:

These helpers will still be in master and the next release. I’m only removing them from 0.7.5 because of the lack of tests and uncredited provenance.
My goal is to get 0.7.5 wrapped and released today/tomorrow, so we can move on with 0.8.x development.
We’ll cherry-pick doc patches from 0.7.5 into the mainline instead of merging, so we don’t remove these helpers.

psq commented on dyoder/waves Sat Jun 14 21:37:42 -0700 2008
Comment in f7087c5:

Why remove these? Not much you can do in erubis without these. Or should they go in a separate gem?

automatthew commented on dyoder/waves Wed Jun 04 09:33:35 -0700 2008
Comment in 962aa9f:

I’m sure there is, but I don’t know what version Dan was developing against at this stage. I also don’t know enough Sequel to quickly determine what versions are lacking methods referenced in Waves.
The Base controller uses the "set" method which is replaced by "set_with_params" in Sequel 2.0.0, thus the addition of the dependency here.

jdunphy commented on dyoder/waves Wed Jun 04 09:05:34 -0700 2008
Comment in 962aa9f:

There’s no minimum version for sequel?

automatthew commented on dyoder/waves Mon May 12 06:51:05 -0700 2008
Comment in 6068a06:

Logical.

automatthew commented on dyoder/waves Thu Apr 17 19:35:13 -0700 2008
Comment in 7b1f939:

Good call.

dyoder commented on dyoder/waves Thu Apr 17 17:56:08 -0700 2008
Comment in 7b05902:

Matthew, I think you nailed it.

automatthew commented on dyoder/waves Tue Apr 15 06:51:38 -0700 2008
Comment on verify/mapping/.port/filters.rb in 106274b:

What’s the rationale for a hidden directory?

automatthew commented on dyoder/waves Tue Apr 15 06:50:47 -0700 2008
Comment in 106274b:

This is stellar work. I’ll have to rewrite the ORM extraction now, but it’s worth it.